anchao commented on code in PR #11140: URL: https://github.com/apache/nuttx/pull/11140#discussion_r1390424666
########## include/nuttx/spinlock.h: ########## @@ -32,12 +32,12 @@ #include <nuttx/irq.h> -#ifdef CONFIG_RW_SPINLOCK -#include <stdatomic.h> +#if defined(CONFIG_RW_SPINLOCK) && !defined(__cplusplus) Review Comment: What GCC version are you using? ########## include/nuttx/spinlock.h: ########## @@ -32,12 +32,12 @@ #include <nuttx/irq.h> -#ifdef CONFIG_RW_SPINLOCK -#include <stdatomic.h> +#if defined(CONFIG_RW_SPINLOCK) && !defined(__cplusplus) Review Comment: ``` $ arm-none-eabi-gcc -v Using built-in specs. COLLECT_GCC=arm-none-eabi-gcc COLLECT_LTO_WRAPPER=/home/archer/code/k03/k1/prebuilts/gcc/linux/arm/bin/../libexec/gcc/arm-none-eabi/11.3.1/lto-wrapper Target: arm-none-eabi Configured with: /data/jenkins/workspace/GNU-toolchain/arm-11/src/gcc/configure --target=arm-none-eabi --prefix=/data/jenkins/workspace/GNU-toolchain/arm-11/build-arm-none-eabi/install --with-gmp=/data/jenkins/workspace/GNU-toolchain/arm-11/build-arm-none-eabi/host-tools --with-mpfr=/data/jenkins/workspace/GNU-toolchain/arm-11/build-arm-none-eabi/host-tools --with-mpc=/data/jenkins/workspace/GNU-toolchain/arm-11/build-arm-none-eabi/host-tools --with-isl=/data/jenkins/workspace/GNU-toolchain/arm-11/build-arm-none-eabi/host-tools --disable-shared --disable-nls --disable-threads --disable-tls --enable-checking=release --enable-languages=c,c++,fortran --with-newlib --with-gnu-as --with-gnu-ld --with-sysroot=/data/jenkins/workspace/GNU-toolchain/arm-11/build-arm-none-eabi/install/arm-none-eabi --with-multilib-list=aprofile,rmprofile --with-pkgversion='Arm GNU Toolchain 11.3.Rel1' --with-bugurl=https://bugs.linaro.org/ Thread model: single Supported LTO compression algorithms: zlib gcc version 11.3.1 20220712 (Arm GNU Toolchain 11.3.Rel1) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
