xiaoxiang781216 commented on code in PR #2201:
URL: https://github.com/apache/nuttx-apps/pull/2201#discussion_r1396772343
##########
testing/sd_stress/sd_stress_main.c:
##########
@@ -272,14 +272,14 @@ static bool rename_dir(const char *old_dir, const char
*new_dir)
return true;
}
-struct timespec get_abs_time(void)
+static struct timespec get_abs_time(void)
{
struct timespec ts;
clock_gettime(CLOCK_MONOTONIC, &ts);
return ts;
}
-uint64_t get_time_delta(const struct timespec *start,
+static uint64_t get_time_delta(const struct timespec *start,
const struct timespec *end)
Review Comment:
```suggestion
const struct timespec *end)
```
##########
testing/sd_bench/sd_bench_main.c:
##########
@@ -107,26 +107,26 @@ static int read_test(int fd, sdb_config_t *cfg, uint8_t
*block,
int block_size);
static uint64_t time_fsync_us(int fd);
-struct timespec get_abs_time(void);
-uint64_t get_elapsed_time_us(const struct timespec *start);
-uint64_t time_fsync_us(int fd);
-float ts_to_kb(uint64_t bytes, uint64_t elapsed);
-float block_count_to_mb(size_t blocks, size_t block_size);
+static struct timespec get_abs_time(void);
+static uint64_t get_elapsed_time_us(const struct timespec *start);
+static uint64_t time_fsync_us(int fd);
+static float ts_to_kb(uint64_t bytes, uint64_t elapsed);
+static float block_count_to_mb(size_t blocks, size_t block_size);
static const char *print_bool(const bool value);
static void usage(void);
/****************************************************************************
* Private Functions
****************************************************************************/
-struct timespec get_abs_time(void)
+static struct timespec get_abs_time(void)
{
struct timespec ts;
clock_gettime(CLOCK_MONOTONIC, &ts);
return ts;
}
-uint64_t get_time_delta_us(const struct timespec *start,
+static uint64_t get_time_delta_us(const struct timespec *start,
const struct timespec *end)
Review Comment:
```suggestion
const struct timespec *end)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
