xiaoxiang781216 commented on code in PR #11288:
URL: https://github.com/apache/nuttx/pull/11288#discussion_r1410177761
##########
libs/libc/machine/arm/armv8-m/gnu/arch_strlen.S:
##########
@@ -169,6 +184,9 @@ def_fn strlen p2align=6
clz data1a, data1a
ldrd r4, r5, [sp], #8
add result, result, data1a, lsr #3 /* Bits -> Bytes. */
+#if __ARM_FEATURE_PAC_DEFAULT
+ aut ip, lr, sp
Review Comment:
align `ip` with other line
##########
libs/libc/machine/arm/armv8-m/gnu/arch_strcpy.S:
##########
@@ -63,6 +71,13 @@
.type strcpy, %function
strcpy:
+#if __ARM_FEATURE_PAC_DEFAULT
+# if __ARM_FEATURE_BTI_DEFAULT
+ pacbti ip, lr, sp
+# else
+ pac ip, lr, sp
Review Comment:
let's use the indent style
##########
libs/libc/machine/arm/armv8-m/gnu/arch_strlen.S:
##########
@@ -108,6 +116,13 @@
#define tmp2 r5
def_fn strlen p2align=6
+#if __ARM_FEATURE_PAC_DEFAULT
+# if __ARM_FEATURE_BTI_DEFAULT
+ pacbti ip, lr, sp
+# else
+ pac ip, lr, sp
Review Comment:
ditto
##########
libs/libc/machine/arm/armv8-m/gnu/arch_strcpy.S:
##########
@@ -209,6 +224,9 @@ strcpy:
mov tmp3, #0
strb tmp3, [dst]
pop {result, tmp1, tmp2, tmp3, src_offset}
+#if __ARM_FEATURE_PAC_DEFAULT
+ aut ip, lr, sp
Review Comment:
align
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
