xiaoxiang781216 commented on code in PR #11008:
URL: https://github.com/apache/nuttx/pull/11008#discussion_r1408123417
##########
drivers/video/video.c:
##########
@@ -1015,6 +1017,18 @@ static void cleanup_resources(FAR video_mng_t *vmng)
cleanup_scenes_parameter(vmng);
}
+static void cleanup_private_data(FAR struct inode *inode)
+{
+ FAR video_mng_t *priv = inode->i_private;
Review Comment:
```suggestion
FAR video_mng_t *priv = inode->i_private;
```
##########
drivers/video/video.c:
##########
@@ -3410,7 +3416,16 @@ int video_initialize(FAR const char *devpath)
int video_uninitialize(FAR const char *devpath)
{
- return video_unregister(devpath);
Review Comment:
but if user call video_unregister instead video_uninitialize, the leak still
happen too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
