xiaoxiang781216 commented on code in PR #11303:
URL: https://github.com/apache/nuttx/pull/11303#discussion_r1413153628
##########
tools/Unix.mk:
##########
@@ -279,10 +279,16 @@ include/arch:
$(Q) $(DIRLINK) $(TOPDIR)/$(ARCH_DIR)/include $@
# Link the boards/<arch>/<chip>/<board>/include directory to include/arch/board
+# If the above path does not exist, then we try to link to common
+
+LINK_INCLUDE_DIR=$(BOARD_DIR)/include
Review Comment:
need change Win.mk
##########
tools/configure.sh:
##########
@@ -167,8 +167,12 @@ if [ ! -r ${src_makedefs} ]; then
src_makedefs=${configpath}/../../scripts/Make.defs
if [ ! -r ${src_makedefs} ]; then
- echo "File Make.defs could not be found"
- exit 4
+ src_makedefs=${configpath}/../../../common/scripts/Make.defs
+
+ if [ ! -r ${src_makedefs} ]; then
Review Comment:
need change tools/configure.c
##########
tools/Unix.mk:
##########
@@ -283,7 +283,9 @@ include/arch:
LINK_INCLUDE_DIR=$(BOARD_DIR)/include
ifeq ($(wildcard $(LINK_INCLUDE_DIR)),)
- LINK_INCLUDE_DIR = $(BOARD_COMMON_DIR)/include
+ ifneq ($(strip $(BOARD_COMMON_DIR)),)
+ LINK_INCLUDE_DIR = $(BOARD_COMMON_DIR)/include
Review Comment:
merge to previous patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
