xiaoxiang781216 commented on PR #11301: URL: https://github.com/apache/nuttx/pull/11301#issuecomment-1838665147
> > > > what's error report from toolchain's math library? > > > > > > > > > I explained the issue over here : [#11269 (comment)](https://github.com/apache/nuttx/pull/11269#issuecomment-1833939123) > > > If you have any other suggestion i am open to them. > > > > > > let's remove `#if` statement: > > ``` > > #if defined(__need_wint_t) || defined(__need_mbstate_t) > > > > #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) > > #pragma GCC system_header > > #endif > > > > #include_next <wchar.h> > > ``` > > I was thinking of creating a patch file that we apply when compiling. But depends on what we want to do. Should we merge this and keep a note somewhere saying if you face our problem activate the LIBM option? many defconfig doesn't use the internal math library, here is the list: ``` boards/arm/imx6/sabre-6quad/configs/libcxx/defconfig boards/arm/mx8mp/verdin-mx8mp/configs/nsh/defconfig boards/sim/sim/sim/configs/citest/defconfig boards/sim/sim/sim/configs/libcxxtest/defconfig ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
