Author: lektran Date: Tue Jun 19 02:21:08 2007 New Revision: 548665 URL: http://svn.apache.org/viewvc?view=rev&rev=548665 Log: Uncommented a code block and added a comment about why it's there
Modified: ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java Modified: ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java?view=diff&rev=548665&r1=548664&r2=548665 ============================================================================== --- ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java (original) +++ ofbiz/trunk/applications/workeffort/src/org/ofbiz/workeffort/workeffort/WorkEffortServices.java Tue Jun 19 02:21:08 2007 @@ -304,12 +304,9 @@ tempWorkEfforts = delegator.findByAnd("WorkEffort", entityExprList, UtilMisc.toList("estimatedStartDate")); } - // FIXME: I think that now the following code can be removed. - // It was probably here to remove duplicated workeffort ids caused - // by the query on the WorkEffortAndPartyAssign view when no party was - // specified; now it is no more necessary since, when no party is specified, - // the query is done on the WorkEffort entity. - /* + // This block needs to be here to filter duplicate workeffort ids when + // more than one of the selected party ids is assigned to the WorkEffort + Set tempWeKeys = new HashSet(); Iterator tempWorkEffortIter = tempWorkEfforts.iterator(); while (tempWorkEffortIter.hasNext()) { @@ -321,7 +318,7 @@ tempWeKeys.add(tempWorkEffortId); } } - */ + validWorkEfforts = new ArrayList(tempWorkEfforts); } catch (GenericEntityException e) { Debug.logWarning(e, module);