Author: jacopoc
Date: Wed Dec 23 18:52:37 2009
New Revision: 893593
URL: http://svn.apache.org/viewvc?rev=893593&view=rev
Log:
Disabling setUnitPriceAsLastPrice service (the service was triggered to
automatically create a new SupplierProduct record when, during order entry or
receive, the unit price/cost was manually set): the service is not considering
currency uom id and this is dangerous because, if the facility currency is
different from the currency of the order/supplier product then the order
receive screen automatically converts the unit price into the currency of the
facility; this was causing an update of the supplier product record with a
wrong currency.
I am also not sure if it is a good idea in general to automatically update a
SupplierProduct record that can be part of a signed agreement with a supplier.
We may want to discuss this and take a decision (deprecate or enhance the
service), but for now it is safer to disable this.
Thanks to Giorgio Tomaselli for the bug report.
Modified:
ofbiz/trunk/applications/order/servicedef/secas.xml
Modified: ofbiz/trunk/applications/order/servicedef/secas.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/servicedef/secas.xml?rev=893593&r1=893592&r2=893593&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/servicedef/secas.xml (original)
+++ ofbiz/trunk/applications/order/servicedef/secas.xml Wed Dec 23 18:52:37 2009
@@ -32,21 +32,27 @@
<eca service="storeOrder" event="return">
<action service="balanceOrderItemsWithNegativeReservations"
mode="sync"/>
</eca>
+ <!--
<eca service="storeOrder" event="return">
<condition field-name="orderTypeId" operator="equals"
value="PURCHASE_ORDER"/>
<action service="setUnitPriceAsLastPrice" mode="sync"/>
</eca>
+ -->
<eca service="storeOrder" event="return">
<action service="setOrderReservationPriority" mode="sync"/>
</eca>
+ <!--
<eca service="updateOrderItems" event="commit">
<condition field-name="orderTypeId" operator="equals"
value="PURCHASE_ORDER"/>
<action service="setUnitPriceAsLastPrice" mode="sync"/>
</eca>
+ -->
<eca service="receiveInventoryProduct" event="commit">
<condition field-name="facilityId" operator="is-not-empty"/>
<action service="addProductsBackToCategory" mode="sync"/>
+ <!--
<action service="setUnitPriceAsLastPrice" mode="sync"/>
+ -->
</eca>
<eca service="receiveInventoryProduct" event="commit">
<condition field-name="facilityId" operator="is-not-empty"/>
