Author: jleroux
Date: Sat Jul 31 13:07:13 2010
New Revision: 981051

URL: http://svn.apache.org/viewvc?rev=981051&view=rev
Log:
A patch from Rene Scheibe "Click Expand or Colaspe All does not work as 
expected" (https://issues.apache.org/jira/browse/OFBIZ-3744) - OFBIZ-3744

Reported by Sam Hamilton:
If you are on say this page - 
https://localhost:8443/catalog/control/EditProduct?productId=WG-9943
clicking on Expand All it will expand all the ones not expanded and then 
collapse the ones that were already open
clicking on Collapse All it will collapse all the ones open and open all the 
ones that were collapsed.

fixed issue

    * css.style.visible cannot be true/false as used so in collapseAll()
    * now using the $() container and calling visible() which returns true/false

Modified:
    ofbiz/trunk/framework/images/webapp/images/selectall.js

Modified: ofbiz/trunk/framework/images/webapp/images/selectall.js
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/images/webapp/images/selectall.js?rev=981051&r1=981050&r2=981051&view=diff
==============================================================================
--- ofbiz/trunk/framework/images/webapp/images/selectall.js (original)
+++ ofbiz/trunk/framework/images/webapp/images/selectall.js Sat Jul 31 13:07:13 
2010
@@ -547,7 +547,7 @@ function expandAll(expanded) {
             groupbody=divs1[j];
           }
         }
-        if(groupbody.style.visible != expanded) {
+        if($(groupbody).visible() != expanded) {
           toggleCollapsiblePanel(links[0], groupbody.id, 'expand', 'collapse');
         }
       }


Reply via email to