Author: jleroux
Date: Wed Jan 19 19:45:12 2011
New Revision: 1060933
URL: http://svn.apache.org/viewvc?rev=1060933&view=rev
Log:
A fix suggested by Jeremy Wickersheimer "updateGiftCard service NPE when card
number not given"
The updateGiftCard service has the cardNumber parameter optional but will have
an NPE if the card number is not given.
I'd suggest to make this parameter non optional, I'am not sure if a gift card
without number makes much sense anyway...
JLR: I checked the code, it's the better solution IMO
Modified:
ofbiz/trunk/applications/accounting/servicedef/services_paymentmethod.xml
Modified:
ofbiz/trunk/applications/accounting/servicedef/services_paymentmethod.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/servicedef/services_paymentmethod.xml?rev=1060933&r1=1060932&r2=1060933&view=diff
==============================================================================
--- ofbiz/trunk/applications/accounting/servicedef/services_paymentmethod.xml
(original)
+++ ofbiz/trunk/applications/accounting/servicedef/services_paymentmethod.xml
Wed Jan 19 19:45:12 2011
@@ -114,7 +114,7 @@ under the License.
<attribute name="thruDate" type="Timestamp" mode="IN" optional="true"/>
<attribute name="description" type="String" mode="IN" optional="true"/>
<attribute name="paymentMethodId" type="String" mode="INOUT"
optional="false"/>
- <attribute name="cardNumber" type="String" mode="IN" optional="true"/>
+ <attribute name="cardNumber" type="String" mode="IN" optional="false"/>
<attribute name="pinNumber" type="String" mode="IN" optional="true"/>
<attribute name="expireDate" type="String" mode="IN" optional="true"/>
<attribute name="expMonth" type="String" mode="IN" optional="true"/>
