svn commit: r1061239 - in /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart: ShoppingCart.java ShoppingCartEvents.java

[mor]

Author: mor
Date: Thu Jan 20 11:45:02 2011
New Revision: 1061239

URL: http://svn.apache.org/viewvc?rev=1061239&view=rev
Log:
Slight improvements to my previous commit (r1061192). Noticed by Chirag Manocha.

Modified:
    
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
    
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java

Modified: 
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java?rev=1061239&r1=1061238&r2=1061239&view=diff
==============================================================================
--- 
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
 (original)
+++ 
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCart.java
 Thu Jan 20 11:45:02 2011
@@ -3246,16 +3246,11 @@ public class ShoppingCart implements Ite
         }
     }
 
-    public String addProductPromoCode(String productPromoCodeId, 
LocalDispatcher dispatcher) {
-        return this.addProductPromoCode(productPromoCodeId, null, dispatcher);
-    }
-
     /** Adds a promotion code to the cart, checking if it is valid. If it is 
valid this will return null, otherwise it will return a message stating why it 
was not valid
      * @param productPromoCodeId The promotion code to check and add
-     * @param cart Shopping Cart Object
      * @return String that is null if valid, and added to cart, or an error 
message of the code was not valid and not added to the cart.
      */
-    public String addProductPromoCode(String productPromoCodeId, ShoppingCart 
cart, LocalDispatcher dispatcher) {
+    public String addProductPromoCode(String productPromoCodeId, 
LocalDispatcher dispatcher) {
         if (this.productPromoCodes.contains(productPromoCodeId)) {
             return UtilProperties.getMessage(resource_error, 
"productpromoworker.promotion_code_already_been_entered", 
UtilMisc.toMap("productPromoCodeId", productPromoCodeId), locale);
         }
@@ -3264,7 +3259,7 @@ public class ShoppingCart implements Ite
             return null;
         }
         // if the promo code requires it make sure the code is valid
-        String checkResult = 
ProductPromoWorker.checkCanUsePromoCode(productPromoCodeId, this.getPartyId(), 
this.getDelegator(), cart, locale);
+        String checkResult = 
ProductPromoWorker.checkCanUsePromoCode(productPromoCodeId, this.getPartyId(), 
this.getDelegator(), this, locale);
         if (checkResult == null) {
             this.productPromoCodes.add(productPromoCodeId);
             // new promo code, re-evaluate promos

Modified: 
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java?rev=1061239&r1=1061238&r2=1061239&view=diff
==============================================================================
--- 
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
 (original)
+++ 
ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
 Thu Jan 20 11:45:02 2011
@@ -85,7 +85,7 @@ public class ShoppingCartEvents {
         ShoppingCart cart = getCartObject(request);
         String productPromoCodeId = request.getParameter("productPromoCodeId");
         if (UtilValidate.isNotEmpty(productPromoCodeId)) {
-            String checkResult = cart.addProductPromoCode(productPromoCodeId, 
cart, dispatcher);
+            String checkResult = cart.addProductPromoCode(productPromoCodeId, 
dispatcher);
             if (UtilValidate.isNotEmpty(checkResult)) {
                 request.setAttribute("_ERROR_MESSAGE_", checkResult);
                 return "error";