svn commit: r1173518 - /ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java

[sascharodekamp]

Author: sascharodekamp
Date: Wed Sep 21 07:31:11 2011
New Revision: 1173518

URL: http://svn.apache.org/viewvc?rev=1173518&view=rev
Log:
EntityListIterator not being closed after storing incoming email 
(https://issues.apache.org/jira/browse/OFBIZ-4424). A slightly modified  patch 
from Varun Bhansaly which closes the entity Iterator after use: 
CommunicationEventServices.buildListOfWorkEffortInfoFromEmailAddresses() does 
not close the entity list iterator resulting in error messages.

Modified:
    
ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java

Modified: 
ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java?rev=1173518&r1=1173517&r2=1173518&view=diff
==============================================================================
--- 
ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java
 (original)
+++ 
ofbiz/trunk/applications/party/src/org/ofbiz/party/communication/CommunicationEventServices.java
 Wed Sep 21 07:31:11 2011
@@ -1149,6 +1149,12 @@ public class CommunicationEventServices 
                             tempResults.addAll(filteredList);
                         } catch (GenericEntityException e) {
                             Debug.logError(e, module);
+                        } finally {
+                            try {
+                                listIt.close();
+                            } catch (GenericEntityException e) {
+                                Debug.logError(e, module);
+                            }
                         }
                     }
                 }