Author: jleroux
Date: Sun Jan  1 10:50:27 2012
New Revision: 1226231

URL: http://svn.apache.org/viewvc?rev=1226231&view=rev
Log:
A patch from Philippe Mouawad "Remove Synchronized in internalBegin" 
https://issues.apache.org/jira/browse/OFBIZ-4292

InternalBegin is uselessly synchronized , since it is a static method it is a 
very big useless Contention Point since not unthread safe instance variable is 
used

jleroux: see comments in Jira 4282 for more

Modified:
    
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java

Modified: 
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java?rev=1226231&r1=1226230&r2=1226231&view=diff
==============================================================================
--- 
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java
 (original)
+++ 
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java
 Sun Jan  1 10:50:27 2012
@@ -194,7 +194,7 @@ public class TransactionUtil implements 
         }
     }
 
-    protected static synchronized void internalBegin(UserTransaction ut, int 
timeout) throws SystemException, NotSupportedException {
+    protected static void internalBegin(UserTransaction ut, int timeout) 
throws SystemException, NotSupportedException {
         // set the timeout for THIS transaction
         if (timeout > 0) {
             ut.setTransactionTimeout(timeout);


Reply via email to