Author: sascharodekamp Date: Wed Feb 15 08:53:07 2012 New Revision: 1244401
URL: http://svn.apache.org/viewvc?rev=1244401&view=rev Log: BUGFIX: return value of String.replace(CharSequence, CharSequence) ignored in org.ofbiz.widget.form.[Macro/Html]FormRenderer.appendExternalLoginKey(String) (https://issues.apache.org/jira/browse/OFBIZ-4694): A patch from Michael Brohl Same error in both Classes MacroFormRenderer and HtmlFormRenderer. Will provide a patch. Modified: ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/MacroFormRenderer.java ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlFormRenderer.java Modified: ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/MacroFormRenderer.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/MacroFormRenderer.java?rev=1244401&r1=1244400&r2=1244401&view=diff ============================================================================== --- ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/MacroFormRenderer.java (original) +++ ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/MacroFormRenderer.java Wed Feb 15 08:53:07 2012 @@ -2256,7 +2256,7 @@ public class MacroFormRenderer implement if (questionIndex == -1) { result += sessionId; } else { - result.replace("?", sessionId + "?"); + result = result.replace("?", sessionId + "?"); } return result; } Modified: ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlFormRenderer.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlFormRenderer.java?rev=1244401&r1=1244400&r2=1244401&view=diff ============================================================================== --- ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlFormRenderer.java (original) +++ ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlFormRenderer.java Wed Feb 15 08:53:07 2012 @@ -2327,7 +2327,7 @@ public class HtmlFormRenderer extends Ht if (questionIndex == -1) { result += sessionId; } else { - result.replace("?", sessionId + "?"); + result = result.replace("?", sessionId + "?"); } return result; }
