svn commit: r1618411 - in /ofbiz/trunk/applications: order/config/OrderErrorUiLabels.xml product/script/org/ofbiz/shipment/shipment/ShipmentServices.xml

[apatel]

Author: apatel
Date: Sat Aug 16 20:40:20 2014
New Revision: 1618411

URL: http://svn.apache.org/r1618411
Log:
[OFBIZ-4459] call to Quickshipdrop should be make on approved orders. Thanks to 
Kiran Gawde and ofbiz.us team for contributions.

Modified:
    ofbiz/trunk/applications/order/config/OrderErrorUiLabels.xml
    
ofbiz/trunk/applications/product/script/org/ofbiz/shipment/shipment/ShipmentServices.xml

Modified: ofbiz/trunk/applications/order/config/OrderErrorUiLabels.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/config/OrderErrorUiLabels.xml?rev=1618411&r1=1618410&r2=1618411&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/config/OrderErrorUiLabels.xml (original)
+++ ofbiz/trunk/applications/order/config/OrderErrorUiLabels.xml Sat Aug 16 
20:40:20 2014
@@ -35,6 +35,9 @@
         <value xml:lang="zh">必须为销售订单选择一个产品店铺。 
</value>
         <value xml:lang="zh_TW">必é 
ˆç‚ºéŠ·å”®è¨‚單選擇一個產品店鋪。 </value>
     </property>
+    <property key="OrderApproveOrderBeforeQuickDropShip">
+        <value xml:lang="en">Order must be approved before complete drop 
shipment.</value>
+    </property>
     <property 
key="OrderAnAlternateGwpProductIdWasInPlaceButWasEitherNotValidOrIsNoLongerInStockForId">
         <value xml:lang="de">Ein alternative Gratisbeigabe ist vorhanden, aber 
entweder nicht mehr gültig oder nicht mehr auf Lager : 
${alternateGwpProductId}</value>
         <value xml:lang="en">An alternateGwpProductId was in place, but was 
either not valid or is no longer in stock for ID : 
${alternateGwpProductId}</value>

Modified: 
ofbiz/trunk/applications/product/script/org/ofbiz/shipment/shipment/ShipmentServices.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/script/org/ofbiz/shipment/shipment/ShipmentServices.xml?rev=1618411&r1=1618410&r2=1618411&view=diff
==============================================================================
--- 
ofbiz/trunk/applications/product/script/org/ofbiz/shipment/shipment/ShipmentServices.xml
 (original)
+++ 
ofbiz/trunk/applications/product/script/org/ofbiz/shipment/shipment/ShipmentServices.xml
 Sat Aug 16 20:40:20 2014
@@ -1339,6 +1339,13 @@ under the License.
     </simple-method>
 
     <simple-method method-name="quickDropShipOrder" short-description="Create 
and complete a drop shipment for a ship group">
+        <entity-one entity-name="OrderHeader" value-field="orderHeader"/>
+        <if-compare field="orderHeader.statusId" operator="equals" 
value="ORDER_CREATED">
+            <add-error>
+                <fail-property resource="OrderErrorUiLabels" 
property="OrderApproveOrderBeforeQuickDropShip"/>
+            </add-error>
+            <check-errors/>
+        </if-compare>
         <set from-field="parameters.orderId" 
field="shipmentContext.primaryOrderId"/>
         <set from-field="parameters.shipGroupSeqId" 
field="shipmentContext.primaryShipGroupSeqId"/>
         <set value="PURCH_SHIP_CREATED" field="shipmentContext.statusId"/>