Author: ashish
Date: Sat Nov 22 11:26:20 2014
New Revision: 1641044

URL: http://svn.apache.org/r1641044
Log:
Applied product folder related changes from jira issue - OFBIZ-5844 - Convert 
java files to EntityQuery.
Thanks Arun for the contribution.

Modified:
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/catalog/CatalogWorker.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CatalogUrlServlet.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryContentWrapper.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryServices.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryWorker.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigItemContentWrapper.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigWorker.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigWrapper.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/feature/ParametricSearch.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/feature/ProductFeatureServices.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/FrameImage.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementHelper.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementServices.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ReplaceImage.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/inventory/InventoryServices.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/inventory/InventoryWorker.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/price/PriceServices.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/KeywordIndex.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductContentWrapper.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductEvents.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductPromoContentWrapper.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearch.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearchEvents.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductSearchSession.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductServices.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductUtilServices.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/ProductWorker.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/product/VariantEvents.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/promo/PromoServices.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/spreadsheetimport/ImportProductHelper.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/store/ProductStoreEvents.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/store/ProductStoreWorker.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/product/subscription/SubscriptionServices.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/PackingSession.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/PackingSessionLine.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/shipment/picklist/PickListServices.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/shipment/shipment/ShipmentServices.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/shipment/thirdparty/dhl/DhlServices.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/shipment/thirdparty/fedex/FedexServices.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/shipment/thirdparty/ups/UpsServices.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/shipment/thirdparty/usps/UspsServices.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/shipment/verify/VerifyPickSession.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/shipment/verify/VerifyPickSessionRow.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/shipment/weightPackage/WeightPackageServices.java
    
ofbiz/trunk/applications/product/src/org/ofbiz/shipment/weightPackage/WeightPackageSession.java

Modified: 
ofbiz/trunk/applications/product/src/org/ofbiz/product/catalog/CatalogWorker.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/catalog/CatalogWorker.java?rev=1641044&r1=1641043&r2=1641044&view=diff
==============================================================================
--- 
ofbiz/trunk/applications/product/src/org/ofbiz/product/catalog/CatalogWorker.java
 (original)
+++ 
ofbiz/trunk/applications/product/src/org/ofbiz/product/catalog/CatalogWorker.java
 Sat Nov 22 11:26:20 2014
@@ -73,7 +73,7 @@ public class CatalogWorker {
         List<GenericValue> catalogs = null;
         Delegator delegator = (Delegator) request.getAttribute("delegator");
         try {
-            catalogs = delegator.findList("ProdCatalog", null, null, 
UtilMisc.toList("catalogName"), null, false);
+            catalogs = 
EntityQuery.use(delegator).from("ProdCatalog").orderBy("catalogName").queryList();
         } catch (GenericEntityException e) {
             Debug.logError(e, "Error looking up all catalogs", module);
         }
@@ -93,7 +93,7 @@ public class CatalogWorker {
 
     public static List<GenericValue> getStoreCatalogs(Delegator delegator, 
String productStoreId) {
         try {
-            return 
EntityUtil.filterByDate(delegator.findByAnd("ProductStoreCatalog", 
UtilMisc.toMap("productStoreId", productStoreId), 
UtilMisc.toList("sequenceNum", "prodCatalogId"), true), true);
+            return 
EntityQuery.use(delegator).from("ProductStoreCatalog").where("productStoreId", 
productStoreId).orderBy("sequenceNum", 
"prodCatalogId").cache(true).filterByDate().queryList();
         } catch (GenericEntityException e) {
             Debug.logError(e, "Error looking up store catalogs for store with 
id " + productStoreId, module);
         }
@@ -117,7 +117,7 @@ public class CatalogWorker {
         }
 
         try {
-            return 
EntityUtil.filterByDate(delegator.findByAnd("ProdCatalogRole", 
UtilMisc.toMap("partyId", partyId, "roleTypeId", "CUSTOMER"), 
UtilMisc.toList("sequenceNum", "prodCatalogId"), true), true);
+            return 
EntityQuery.use(delegator).from("ProdCatalogRole").where("partyId", partyId, 
"roleTypeId", "CUSTOMER").orderBy("sequenceNum", 
"prodCatalogId").cache(true).filterByDate().queryList();
         } catch (GenericEntityException e) {
             Debug.logError(e, "Error looking up ProdCatalog Roles for party 
with id " + partyId, module);
         }
@@ -131,9 +131,12 @@ public class CatalogWorker {
 
     public static List<GenericValue> getProdCatalogCategories(Delegator 
delegator, String prodCatalogId, String prodCatalogCategoryTypeId) {
         try {
-            List<GenericValue> prodCatalogCategories = 
EntityUtil.filterByDate(delegator.findByAnd("ProdCatalogCategory",
-                        UtilMisc.toMap("prodCatalogId", prodCatalogId),
-                        UtilMisc.toList("sequenceNum", "productCategoryId"), 
true), true);
+            List<GenericValue> prodCatalogCategories = 
EntityQuery.use(delegator).from("ProdCatalogCategory")
+                    .where("prodCatalogId", prodCatalogId)
+                    .orderBy("sequenceNum", "productCategoryId")
+                    .cache(true)
+                    .filterByDate()
+                    .queryList();
 
             if (UtilValidate.isNotEmpty(prodCatalogCategoryTypeId) && 
prodCatalogCategories != null) {
                 prodCatalogCategories = 
EntityUtil.filterByAnd(prodCatalogCategories,

Modified: 
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java?rev=1641044&r1=1641043&r2=1641044&view=diff
==============================================================================
--- 
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java
 (original)
+++ 
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java
 Sat Nov 22 11:26:20 2014
@@ -91,11 +91,11 @@ public class CatalogUrlFilter extends Co
                     List<EntityCondition> productContentConds = 
FastList.newInstance();
                     
productContentConds.add(EntityCondition.makeCondition("productContentTypeId", 
"ALTERNATIVE_URL"));
                     productContentConds.add(EntityUtil.getFilterByDateExpr());
-                    List<GenericValue> productContentInfos = 
delegator.findList("ProductContentAndInfo", 
EntityCondition.makeCondition(productContentConds), null, 
UtilMisc.toList("-fromDate"), null, true);
+                    List<GenericValue> productContentInfos = 
EntityQuery.use(delegator).from("ProductContentAndInfo").where(productContentConds).orderBy("-fromDate").cache(true).queryList();
                     if (UtilValidate.isNotEmpty(productContentInfos)) {
                         for (GenericValue productContentInfo : 
productContentInfos){
                             String contentId = (String) 
productContentInfo.get("contentId");
-                            List<GenericValue> ContentAssocDataResourceViewTos 
= delegator.findByAnd("ContentAssocDataResourceViewTo", 
UtilMisc.toMap("contentIdStart", contentId, "caContentAssocTypeId", 
"ALTERNATE_LOCALE", "drDataResourceTypeId", "ELECTRONIC_TEXT"), null, true);
+                            List<GenericValue> ContentAssocDataResourceViewTos 
= 
EntityQuery.use(delegator).where("ContentAssocDataResourceViewTo").where("contentIdStart",
 contentId, "caContentAssocTypeId", "ALTERNATE_LOCALE", "drDataResourceTypeId", 
"ELECTRONIC_TEXT").cache(true).queryList();
                             if 
(UtilValidate.isNotEmpty(ContentAssocDataResourceViewTos)){
                                 for (GenericValue 
ContentAssocDataResourceViewTo : ContentAssocDataResourceViewTos) {
                                     GenericValue ElectronicText = 
ContentAssocDataResourceViewTo.getRelatedOne("ElectronicText", true);
@@ -116,7 +116,7 @@ public class CatalogUrlFilter extends Co
                                 }
                             } 
                             if (UtilValidate.isEmpty(productId)) {
-                                List<GenericValue> contentDataResourceViews = 
delegator.findByAnd("ContentDataResourceView", UtilMisc.toMap("contentId", 
contentId, "drDataResourceTypeId", "ELECTRONIC_TEXT"), null, true);
+                                List<GenericValue> contentDataResourceViews = 
EntityQuery.use(delegator).where("ContentDataResourceView").where("contentId", 
contentId, "drDataResourceTypeId", "ELECTRONIC_TEXT").cache(true).queryList();
                                 for (GenericValue contentDataResourceView : 
contentDataResourceViews) {
                                     GenericValue ElectronicText = 
contentDataResourceView.getRelatedOne("ElectronicText", true);
                                     if 
(UtilValidate.isNotEmpty(ElectronicText)) {
@@ -146,11 +146,11 @@ public class CatalogUrlFilter extends Co
                     List<EntityCondition> productCategoryContentConds = 
FastList.newInstance();
                     
productCategoryContentConds.add(EntityCondition.makeCondition("prodCatContentTypeId",
 "ALTERNATIVE_URL"));
                     
productCategoryContentConds.add(EntityUtil.getFilterByDateExpr());
-                    List<GenericValue> productCategoryContentInfos = 
delegator.findList("ProductCategoryContentAndInfo", 
EntityCondition.makeCondition(productCategoryContentConds), null, 
UtilMisc.toList("-fromDate"), null, true);
+                    List<GenericValue> productCategoryContentInfos = 
EntityQuery.use(delegator).from("ProductCategoryContentAndInfo").where(productCategoryContentConds).orderBy("-fromDate").cache(true).queryList();
                     if (UtilValidate.isNotEmpty(productCategoryContentInfos)) {
                         for (GenericValue productCategoryContentInfo : 
productCategoryContentInfos){
                             String contentId = (String) 
productCategoryContentInfo.get("contentId");
-                            List<GenericValue> ContentAssocDataResourceViewTos 
= delegator.findByAnd("ContentAssocDataResourceViewTo", 
UtilMisc.toMap("contentIdStart", contentId, "caContentAssocTypeId", 
"ALTERNATE_LOCALE", "drDataResourceTypeId", "ELECTRONIC_TEXT"), null, true);
+                            List<GenericValue> ContentAssocDataResourceViewTos 
= 
EntityQuery.use(delegator).from("ContentAssocDataResourceViewTo").where("contentIdStart",
 contentId, "caContentAssocTypeId", "ALTERNATE_LOCALE", "drDataResourceTypeId", 
"ELECTRONIC_TEXT").cache(true).queryList();
                             if 
(UtilValidate.isNotEmpty(ContentAssocDataResourceViewTos)){
                                 for (GenericValue 
ContentAssocDataResourceViewTo : ContentAssocDataResourceViewTos) {
                                     GenericValue ElectronicText = 
ContentAssocDataResourceViewTo.getRelatedOne("ElectronicText", true);
@@ -173,7 +173,7 @@ public class CatalogUrlFilter extends Co
                                 }
                             } 
                             if (UtilValidate.isEmpty(productCategoryId)) {
-                                List<GenericValue> contentDataResourceViews = 
delegator.findByAnd("ContentDataResourceView", UtilMisc.toMap("contentId", 
contentId, "drDataResourceTypeId", "ELECTRONIC_TEXT"), null, true);
+                                List<GenericValue> contentDataResourceViews = 
EntityQuery.use(delegator).from("ContentDataResourceView").where("contentId", 
contentId, "drDataResourceTypeId", "ELECTRONIC_TEXT").cache(true).queryList();
                                 for (GenericValue contentDataResourceView : 
contentDataResourceViews) {
                                     GenericValue ElectronicText = 
contentDataResourceView.getRelatedOne("ElectronicText", true);
                                     if 
(UtilValidate.isNotEmpty(ElectronicText)) {
@@ -211,7 +211,7 @@ public class CatalogUrlFilter extends Co
                     List<EntityCondition> conds = FastList.newInstance();
                     conds.add(EntityCondition.makeCondition("productId", 
productId));
                     conds.add(EntityUtil.getFilterByDateExpr());
-                    List<GenericValue> productCategoryMembers = 
delegator.findList("ProductCategoryMember", 
EntityCondition.makeCondition(conds), UtilMisc.toSet("productCategoryId"), 
UtilMisc.toList("-fromDate"), null, true);
+                    List<GenericValue> productCategoryMembers = 
EntityQuery.use(delegator).select("productCategoryId").from("ProductCategoryMember").where(conds).orderBy("-fromDate").cache(true).queryList();
                     if (UtilValidate.isNotEmpty(productCategoryMembers)) {
                         GenericValue productCategoryMember = 
EntityUtil.getFirst(productCategoryMembers);
                         productCategoryId = 
productCategoryMember.getString("productCategoryId");
@@ -236,7 +236,7 @@ public class CatalogUrlFilter extends Co
                     List<EntityCondition> rolllupConds = 
FastList.newInstance();
                     
rolllupConds.add(EntityCondition.makeCondition("productId", productId));
                     rolllupConds.add(EntityUtil.getFilterByDateExpr());
-                    List<GenericValue> productCategoryMembers = 
delegator.findList("ProductCategoryMember", 
EntityCondition.makeCondition(rolllupConds), null, 
UtilMisc.toList("-fromDate"), null, true);
+                    List<GenericValue> productCategoryMembers = 
EntityQuery.use(delegator).from("ProductCategoryMember").where(rolllupConds).orderBy("-fromDate").cache(true).queryList();
                     for (GenericValue productCategoryMember : 
productCategoryMembers) {
                         String trailCategoryId = 
productCategoryMember.getString("productCategoryId");
                         if (trailCategoryIds.contains(trailCategoryId)) {
@@ -260,7 +260,7 @@ public class CatalogUrlFilter extends Co
                         List<EntityCondition> rolllupConds = 
FastList.newInstance();
                         
rolllupConds.add(EntityCondition.makeCondition("productCategoryId", 
parentProductCategoryId));
                         rolllupConds.add(EntityUtil.getFilterByDateExpr());
-                        List<GenericValue> productCategoryRollups = 
delegator.findList("ProductCategoryRollup", 
EntityCondition.makeCondition(rolllupConds), null, 
UtilMisc.toList("-fromDate"), null, true);
+                        List<GenericValue> productCategoryRollups = 
EntityQuery.use(delegator).from("ProductCategoryRollup").where(rolllupConds).orderBy("-fromDate").cache(true).queryList();
                         if (UtilValidate.isNotEmpty(productCategoryRollups)) {
                             // add only categories that belong to the top 
category to trail
                             for (GenericValue productCategoryRollup : 
productCategoryRollups) {

Modified: 
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CatalogUrlServlet.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CatalogUrlServlet.java?rev=1641044&r1=1641043&r2=1641044&view=diff
==============================================================================
--- 
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CatalogUrlServlet.java
 (original)
+++ 
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CatalogUrlServlet.java
 Sat Nov 22 11:26:20 2014
@@ -36,6 +36,7 @@ import org.ofbiz.base.util.UtilMisc;
 import org.ofbiz.base.util.UtilValidate;
 import org.ofbiz.entity.Delegator;
 import org.ofbiz.entity.GenericEntityException;
+import org.ofbiz.entity.util.EntityQuery;
 
 /**
  * ControlServlet.java - Master servlet for the web application.
@@ -84,7 +85,7 @@ public class CatalogUrlServlet extends H
         String productId = null;
         try {
             String lastPathElement = pathElements.get(pathElements.size() - 1);
-            if (lastPathElement.startsWith("p_") || 
delegator.findOne("Product", UtilMisc.toMap("productId", lastPathElement), 
true) != null) {
+            if (lastPathElement.startsWith("p_") || 
EntityQuery.use(delegator).from("Product").where("productId", 
lastPathElement).cache(true).queryOne() != null) {
                 if (lastPathElement.startsWith("p_")) {
                     productId = lastPathElement.substring(2);
                 } else {

Modified: 
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryContentWrapper.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryContentWrapper.java?rev=1641044&r1=1641043&r2=1641044&view=diff
==============================================================================
--- 
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryContentWrapper.java
 (original)
+++ 
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryContentWrapper.java
 Sat Nov 22 11:26:20 2014
@@ -141,7 +141,7 @@ public class CategoryContentWrapper impl
             }
         }
 
-        List<GenericValue> categoryContentList = 
delegator.findByAnd("ProductCategoryContent", 
UtilMisc.toMap("productCategoryId", productCategoryId, "prodCatContentTypeId", 
prodCatContentTypeId), UtilMisc.toList("-fromDate"), true);
+        List<GenericValue> categoryContentList = 
EntityQuery.use(delegator).from("ProductCategoryContent").where("productCategoryId",
 productCategoryId, "prodCatContentTypeId", 
prodCatContentTypeId).orderBy("-fromDate").cache(true).queryList();
         categoryContentList = EntityUtil.filterByDate(categoryContentList);
         GenericValue categoryContent = 
EntityUtil.getFirst(categoryContentList);
         if (categoryContent != null) {

Modified: 
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryServices.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryServices.java?rev=1641044&r1=1641043&r2=1641044&view=diff
==============================================================================
--- 
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryServices.java
 (original)
+++ 
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryServices.java
 Sat Nov 22 11:26:20 2014
@@ -105,7 +105,7 @@ public class CategoryServices {
         List<GenericValue> productCategoryMembers;
         try {
             productCategory = 
EntityQuery.use(delegator).from("ProductCategory").where("productCategoryId", 
categoryId).cache().queryOne();
-            productCategoryMembers = delegator.findByAnd(entityName, 
UtilMisc.toMap("productCategoryId", categoryId), orderByFields, true);
+            productCategoryMembers = 
EntityQuery.use(delegator).from(entityName).where("productCategoryId", 
categoryId).orderBy(orderByFields).cache(true).queryList();
         } catch (GenericEntityException e) {
             Debug.logInfo(e, "Error finding previous/next product info: " + 
e.toString(), module);
             return 
ServiceUtil.returnFailure(UtilProperties.getMessage(resourceError, 
"categoryservices.error_find_next_products", UtilMisc.toMap("errMessage", 
e.getMessage()), locale));
@@ -276,7 +276,7 @@ public class CategoryServices {
         try {
             String productStoreId = (String) context.get("productStoreId");
             if (UtilValidate.isNotEmpty(productStoreId)) {
-                GenericValue productStore = delegator.findOne("ProductStore", 
UtilMisc.toMap("productStoreId", productStoreId), false);
+                GenericValue productStore = 
EntityQuery.use(delegator).from("ProductStore").where("productStoreId", 
productStoreId).queryOne();
                 if (productStore != null && 
"N".equals(productStore.getString("showOutOfStockProducts"))) {
                     filterOutOfStock = true;
                 }
@@ -288,7 +288,7 @@ public class CategoryServices {
         if (productCategory != null) {
             try {
                 if (useCacheForMembers) {
-                    productCategoryMembers = delegator.findByAnd(entityName, 
UtilMisc.toMap("productCategoryId", productCategoryId), orderByFields, true);
+                    productCategoryMembers = 
EntityQuery.use(delegator).from(entityName).where("productCategoryId", 
productCategoryId).orderBy(orderByFields).cache(true).queryList();
                     if (activeOnly) {
                         productCategoryMembers = 
EntityUtil.filterByDate(productCategoryMembers, true);
                     }
@@ -351,10 +351,8 @@ public class CategoryServices {
                     EntityCondition mainCond = 
EntityCondition.makeCondition(mainCondList, EntityOperator.AND);
 
                     // set distinct on
-                    EntityFindOptions findOpts = new EntityFindOptions(true, 
EntityFindOptions.TYPE_SCROLL_INSENSITIVE, EntityFindOptions.CONCUR_READ_ONLY, 
false);
-                    findOpts.setMaxRows(highIndex);
                     // using list iterator
-                    EntityListIterator pli = delegator.find(entityName, 
mainCond, null, null, orderByFields, findOpts);
+                    EntityListIterator pli = 
EntityQuery.use(delegator).from(entityName).where(mainCond).orderBy(orderByFields).cursorScrollInsensitive().maxRows(highIndex).queryIterator();
 
                     // get the partial list for this page
                     if (limitView) {
@@ -455,17 +453,16 @@ public class CategoryServices {
         List<String> sortList = 
org.ofbiz.base.util.UtilMisc.toList("sequenceNum", "title");
         
         try {
-            GenericValue category = delegator.findOne(entityName 
,UtilMisc.toMap(primaryKeyName, productCategoryId), false);
+            GenericValue category = 
EntityQuery.use(delegator).from(entityName).where(primaryKeyName, 
productCategoryId).queryOne();
             if (UtilValidate.isNotEmpty(category)) {
                 if (isCatalog.equals("true") && 
isCategoryType.equals("false")) {
                     CategoryWorker.getRelatedCategories(request, 
"ChildCatalogList", CatalogWorker.getCatalogTopCategoryId(request, 
productCategoryId), true);
                     childOfCats = EntityUtil.filterByDate((List<GenericValue>) 
request.getAttribute("ChildCatalogList"));
                     
                 } else if(isCatalog.equals("false") && 
isCategoryType.equals("false")){
-                    childOfCats = 
EntityUtil.filterByDate(delegator.findByAnd("ProductCategoryRollupAndChild", 
UtilMisc.toMap(
-                            "parentProductCategoryId", productCategoryId ), 
null, false));
+                    childOfCats = 
EntityQuery.use(delegator).from("ProductCategoryRollupAndChild").where("parentProductCategoryId",
 productCategoryId).filterByDate().queryList();
                 } else {
-                    childOfCats = 
EntityUtil.filterByDate(delegator.findByAnd("ProdCatalogCategory", 
UtilMisc.toMap("prodCatalogId", productCategoryId), null, false));
+                    childOfCats = 
EntityQuery.use(delegator).from("ProdCatalogCategory").where("prodCatalogId", 
productCategoryId).filterByDate().queryList();
                 }
                 if (UtilValidate.isNotEmpty(childOfCats)) {
                         
@@ -481,11 +478,10 @@ public class CategoryServices {
                         List<GenericValue> childList = null;
                         
                         // Get the child list of chosen category
-                        childList = 
EntityUtil.filterByDate(delegator.findByAnd("ProductCategoryRollup", 
UtilMisc.toMap(
-                                    "parentProductCategoryId", catId), null, 
false));
+                        childList = 
EntityQuery.use(delegator).from("ProductCategoryRollup").where("parentProductCategoryId",
 catId).filterByDate().queryList();
                         
                         // Get the chosen category information for the 
categoryContentWrapper
-                        GenericValue cate = 
delegator.findOne("ProductCategory" ,UtilMisc.toMap("productCategoryId",catId), 
false);
+                        GenericValue cate = 
EntityQuery.use(delegator).from("ProductCategory").where("productCategoryId",catId).queryOne();
                         
                         // If chosen category's child exists, then put the 
arrow before category icon
                         if (UtilValidate.isNotEmpty(childList)) {

Modified: 
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryWorker.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryWorker.java?rev=1641044&r1=1641043&r2=1641044&view=diff
==============================================================================
--- 
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryWorker.java
 (original)
+++ 
ofbiz/trunk/applications/product/src/org/ofbiz/product/category/CategoryWorker.java
 Sat Nov 22 11:26:20 2014
@@ -90,7 +90,7 @@ public class CategoryWorker {
         Collection<GenericValue> results = FastList.newInstance();
 
         try {
-            Collection<GenericValue> allCategories = 
delegator.findList("ProductCategory", null, null, null, null, false);
+            Collection<GenericValue> allCategories = 
EntityQuery.use(delegator).from("ProductCategory").queryList();
 
             for (GenericValue curCat: allCategories) {
                 Collection<GenericValue> parentCats = 
curCat.getRelated("CurrentProductCategoryRollup", null, null, true);
@@ -148,9 +148,7 @@ public class CategoryWorker {
         List<GenericValue> rollups = null;
 
         try {
-            rollups = delegator.findByAnd("ProductCategoryRollup",
-                        UtilMisc.toMap("parentProductCategoryId", parentId),
-                        UtilMisc.toList("sequenceNum"), true);
+            rollups = 
EntityQuery.use(delegator).from("ProductCategoryRollup").where("parentProductCategoryId",
 parentId).orderBy("sequenceNum").cache(true).queryList();
             if (limitView) {
                 rollups = EntityUtil.filterByDate(rollups, true);
             }
@@ -213,7 +211,7 @@ public class CategoryWorker {
         Delegator delegator = category.getDelegator();
         long count = 0;
         try {
-            count = delegator.findCountByCondition("ProductCategoryMember", 
buildCountCondition("productCategoryId", 
category.getString("productCategoryId")), null, null);
+            count = 
EntityQuery.use(delegator).from("ProductCategoryMember").where("productCategoryId",
 category.getString("productCategoryId")).queryCount();
         } catch (GenericEntityException e) {
             Debug.logError(e, module);
         }
@@ -225,7 +223,7 @@ public class CategoryWorker {
         Delegator delegator = category.getDelegator();
         long count = 0;
         try {
-            count = delegator.findCountByCondition("ProductCategoryRollup", 
buildCountCondition("parentProductCategoryId", 
category.getString("productCategoryId")), null, null);
+            count = 
EntityQuery.use(delegator).from("ProductCategoryRollup").where("parentProductCategoryId",
 category.getString("productCategoryId")).queryCount();
         } catch (GenericEntityException e) {
             Debug.logError(e, module);
         }
@@ -363,8 +361,11 @@ public class CategoryWorker {
         if (productCategoryId == null) return false;
         if (UtilValidate.isEmpty(productId)) return false;
 
-        List<GenericValue> productCategoryMembers = 
EntityUtil.filterByDate(delegator.findByAnd("ProductCategoryMember",
-                UtilMisc.toMap("productCategoryId", productCategoryId, 
"productId", productId), null, true), true);
+        List<GenericValue> productCategoryMembers = 
EntityQuery.use(delegator).from("ProductCategoryMember")
+                .where("productCategoryId", productCategoryId, "productId", 
productId)
+                .cache(true)
+                .filterByDate()
+                .queryList();
         if (UtilValidate.isEmpty(productCategoryMembers)) {
             //before giving up see if this is a variant product, and if so 
look up the virtual product and check it...
             GenericValue product = 
EntityQuery.use(delegator).from("Product").where("productId", 
productId).cache().queryOne();
@@ -451,8 +452,7 @@ public class CategoryWorker {
                 List<EntityCondition> rolllupConds = FastList.newInstance();
                 
rolllupConds.add(EntityCondition.makeCondition("productCategoryId", 
parentProductCategoryId));
                 rolllupConds.add(EntityUtil.getFilterByDateExpr());
-                List<GenericValue> productCategoryRollups = 
delegator.findList("ProductCategoryRollup", 
-                        EntityCondition.makeCondition(rolllupConds), null, 
UtilMisc.toList("sequenceNum"), null, true);
+                List<GenericValue> productCategoryRollups = 
EntityQuery.use(delegator).from("ProductCategoryRollup").where(rolllupConds).orderBy("sequenceNum").cache(true).queryList();
                 if (UtilValidate.isNotEmpty(productCategoryRollups)) {
                     // add only categories that belong to the top category to 
trail
                     for (GenericValue productCategoryRollup : 
productCategoryRollups) {

Modified: 
ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigItemContentWrapper.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigItemContentWrapper.java?rev=1641044&r1=1641043&r2=1641044&view=diff
==============================================================================
--- 
ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigItemContentWrapper.java
 (original)
+++ 
ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigItemContentWrapper.java
 Sat Nov 22 11:26:20 2014
@@ -162,9 +162,12 @@ public class ProductConfigItemContentWra
             }
         }
 
-        List<GenericValue> productConfigItemContentList = 
delegator.findByAnd("ProdConfItemContent", UtilMisc.toMap("configItemId", 
configItemId, "confItemContentTypeId", confItemContentTypeId), 
UtilMisc.toList("-fromDate"), true);
-        productConfigItemContentList = 
EntityUtil.filterByDate(productConfigItemContentList);
-        GenericValue productConfigItemContent = 
EntityUtil.getFirst(productConfigItemContentList);
+        GenericValue productConfigItemContent = 
EntityQuery.use(delegator).from("ProdConfItemContent")
+                .where("configItemId", configItemId, "confItemContentTypeId", 
confItemContentTypeId)
+                .orderBy("-fromDate")
+                .cache(true)
+                .filterByDate()
+                .queryFirst();
         if (productConfigItemContent != null) {
             // when rendering the product config item content, always include 
the ProductConfigItem and ProdConfItemContent records that this comes from
             Map<String, Object> inContext = FastMap.newInstance();

Modified: 
ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigWorker.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigWorker.java?rev=1641044&r1=1641043&r2=1641044&view=diff
==============================================================================
--- 
ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigWorker.java
 (original)
+++ 
ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigWorker.java
 Sat Nov 22 11:26:20 2014
@@ -22,6 +22,7 @@ import java.util.List;
 import java.util.Locale;
 import java.util.Map;
 import java.util.Enumeration;
+
 import javax.servlet.http.HttpServletRequest;
 
 import javolution.util.FastList;
@@ -35,6 +36,7 @@ import org.ofbiz.base.util.UtilValidate;
 import org.ofbiz.entity.Delegator;
 import org.ofbiz.entity.GenericEntityException;
 import org.ofbiz.entity.GenericValue;
+import org.ofbiz.entity.util.EntityQuery;
 import org.ofbiz.product.catalog.CatalogWorker;
 import org.ofbiz.product.config.ProductConfigWrapper.ConfigItem;
 import org.ofbiz.product.config.ProductConfigWrapper.ConfigOption;
@@ -210,7 +212,7 @@ public class ProductConfigWorker {
                 configItemId = 
ci.getConfigItemAssoc().getString("configItemId");
                 sequenceNum = ci.getConfigItemAssoc().getLong("sequenceNum");
                 try {
-                    List<GenericValue> configs = 
delegator.findByAnd("ProductConfigConfig", 
UtilMisc.toMap("configItemId",configItemId,"sequenceNum", sequenceNum), null, 
false);
+                    List<GenericValue> configs = 
EntityQuery.use(delegator).from("ProductConfigConfig").where("configItemId",configItemId,"sequenceNum",
 sequenceNum).queryList();
                     for (GenericValue productConfigConfig: configs) {
                         for (ConfigOption oneOption: selectedOptions) {
                             String configOptionId = 
oneOption.configOption.getString("configOptionId");
@@ -233,9 +235,9 @@ public class ProductConfigWorker {
             for (GenericValue productConfigConfig: configsToCheck) {
                 String tempConfigId = 
productConfigConfig.getString("configId");
                 try {
-                    List<GenericValue> tempResult = 
delegator.findByAnd("ProductConfigConfig", 
UtilMisc.toMap("configId",tempConfigId), null, false);
+                    List<GenericValue> tempResult = 
EntityQuery.use(delegator).from("ProductConfigConfig").where("configId",tempConfigId).queryList();
                     if (tempResult.size() == selectedOptionSize && 
configsToCheck.containsAll(tempResult)) {
-                        List<GenericValue> configOptionProductOptions = 
delegator.findByAnd("ConfigOptionProductOption", 
UtilMisc.toMap("configId",tempConfigId), null, false);
+                        List<GenericValue> configOptionProductOptions = 
EntityQuery.use(delegator).from("ConfigOptionProductOption").where("configId",tempConfigId).queryList();
                         if 
(UtilValidate.isNotEmpty(configOptionProductOptions)) {
 
                             //  check for variant product equality

Modified: 
ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigWrapper.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigWrapper.java?rev=1641044&r1=1641043&r2=1641044&view=diff
==============================================================================
--- 
ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigWrapper.java
 (original)
+++ 
ofbiz/trunk/applications/product/src/org/ofbiz/product/config/ProductConfigWrapper.java
 Sat Nov 22 11:26:20 2014
@@ -125,8 +125,7 @@ public class ProductConfigWrapper implem
         }
         questions = FastList.newInstance();
         if ("AGGREGATED".equals(product.getString("productTypeId")) || 
"AGGREGATED_SERVICE".equals(product.getString("productTypeId"))) {
-            List<GenericValue> questionsValues = 
delegator.findByAnd("ProductConfig", UtilMisc.toMap("productId", productId), 
UtilMisc.toList("sequenceNum"), false);
-            questionsValues = EntityUtil.filterByDate(questionsValues);
+            List<GenericValue> questionsValues = 
EntityQuery.use(delegator).from("ProductConfig").where("productId", 
productId).orderBy("sequenceNum").filterByDate().queryList();
             Set<String> itemIds = FastSet.newInstance();
             for (GenericValue questionsValue: questionsValues) {
                 ConfigItem oneQuestion = new ConfigItem(questionsValue);
@@ -137,7 +136,7 @@ public class ProductConfigWrapper implem
                     
itemIds.add(oneQuestion.getConfigItem().getString("configItemId"));
                 }
                 questions.add(oneQuestion);
-                List<GenericValue> configOptions = 
delegator.findByAnd("ProductConfigOption", UtilMisc.toMap("configItemId", 
oneQuestion.getConfigItemAssoc().getString("configItemId")), 
UtilMisc.toList("sequenceNum"), false);
+                List<GenericValue> configOptions = 
EntityQuery.use(delegator).from("ProductConfigOption").where("configItemId", 
oneQuestion.getConfigItemAssoc().getString("configItemId")).orderBy("sequenceNum").queryList();
                 for (GenericValue configOption: configOptions) {
                     ConfigOption option = new ConfigOption(delegator, 
dispatcher, configOption, oneQuestion, catalogId, webSiteId, currencyUomId, 
autoUserLogin);
                     oneQuestion.addOption(option);
@@ -151,7 +150,7 @@ public class ProductConfigWrapper implem
         //configure ProductConfigWrapper according to ProductConfigConfig 
entity
         if (UtilValidate.isNotEmpty(configId)) {
             this.configId = configId;
-            List<GenericValue> productConfigConfig = 
delegator.findByAnd("ProductConfigConfig", UtilMisc.toMap("configId", 
configId), null, false);
+            List<GenericValue> productConfigConfig = 
EntityQuery.use(delegator).from("ProductConfigConfig").where("configId", 
configId).queryList();
             if (UtilValidate.isNotEmpty(productConfigConfig)) {
                 for (GenericValue pcc: productConfigConfig) {
                     String configItemId = pcc.getString("configItemId");

Modified: 
ofbiz/trunk/applications/product/src/org/ofbiz/product/feature/ParametricSearch.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/feature/ParametricSearch.java?rev=1641044&r1=1641043&r2=1641044&view=diff
==============================================================================
--- 
ofbiz/trunk/applications/product/src/org/ofbiz/product/feature/ParametricSearch.java
 (original)
+++ 
ofbiz/trunk/applications/product/src/org/ofbiz/product/feature/ParametricSearch.java
 Sat Nov 22 11:26:20 2014
@@ -64,11 +64,11 @@ public class ParametricSearch {
     public static Map<String, List<GenericValue>> 
makeCategoryFeatureLists(String productCategoryId, Delegator delegator, int 
perTypeMaxSize) {
         Map<String, Map<String, GenericValue>> productFeaturesByTypeMap = 
FastMap.newInstance();
         try {
-            List<GenericValue> productFeatureCategoryAppls = 
delegator.findByAnd("ProductFeatureCategoryAppl", 
UtilMisc.toMap("productCategoryId", productCategoryId), null, true);
+            List<GenericValue> productFeatureCategoryAppls = 
EntityQuery.use(delegator).from("ProductFeatureCategoryAppl").where("productCategoryId",
 productCategoryId).cache(true).queryList();
             productFeatureCategoryAppls = 
EntityUtil.filterByDate(productFeatureCategoryAppls, true);
             if (productFeatureCategoryAppls != null) {
                 for (GenericValue productFeatureCategoryAppl: 
productFeatureCategoryAppls) {
-                    List<GenericValue> productFeatures = 
delegator.findByAnd("ProductFeature", 
UtilMisc.toMap("productFeatureCategoryId", 
productFeatureCategoryAppl.get("productFeatureCategoryId")), null, true);
+                    List<GenericValue> productFeatures = 
EntityQuery.use(delegator).from("ProductFeature").where("productFeatureCategoryId",
 
productFeatureCategoryAppl.get("productFeatureCategoryId")).cache(true).queryList();
                     for (GenericValue productFeature: productFeatures) {
                         String productFeatureTypeId = 
productFeature.getString("productFeatureTypeId");
                         Map<String, GenericValue> featuresByType = 
productFeaturesByTypeMap.get(productFeatureTypeId);
@@ -87,11 +87,11 @@ public class ParametricSearch {
         }
 
         try {
-            List<GenericValue> productFeatureCatGrpAppls = 
delegator.findByAnd("ProductFeatureCatGrpAppl", 
UtilMisc.toMap("productCategoryId", productCategoryId), null, true);
+            List<GenericValue> productFeatureCatGrpAppls = 
EntityQuery.use(delegator).from("ProductFeatureCatGrpAppl").where("productCategoryId",
 productCategoryId).cache(true).queryList();
             productFeatureCatGrpAppls = 
EntityUtil.filterByDate(productFeatureCatGrpAppls, true);
             if (productFeatureCatGrpAppls != null) {
                 for (GenericValue productFeatureCatGrpAppl: 
productFeatureCatGrpAppls) {
-                    List<GenericValue> productFeatureGroupAppls = 
delegator.findByAnd("ProductFeatureGroupAppl", 
UtilMisc.toMap("productFeatureGroupId", 
productFeatureCatGrpAppl.get("productFeatureGroupId")), null, true);
+                    List<GenericValue> productFeatureGroupAppls = 
EntityQuery.use(delegator).from("ProductFeatureGroupAppl").where("productFeatureGroupId",
 productFeatureCatGrpAppl.get("productFeatureGroupId")).cache(true).queryList();
                     for (GenericValue productFeatureGroupAppl: 
productFeatureGroupAppls) {
                         GenericValue productFeature = 
EntityQuery.use(delegator).from("ProductFeature").where("productFeatureId", 
productFeatureGroupAppl.get("productFeatureId")).cache().queryOne();
 
@@ -128,7 +128,7 @@ public class ParametricSearch {
         Map<String, List<GenericValue>> productFeaturesByTypeMap = 
FastMap.newInstance();
         try {
             Set<String> typesWithOverflowMessages = FastSet.newInstance();
-            EntityListIterator productFeatureEli = 
delegator.find("ProductFeature", null, null, null, 
UtilMisc.toList("description"), null);
+            EntityListIterator productFeatureEli = 
EntityQuery.use(delegator).from("ProductFeature").orderBy("description").queryIterator();
             GenericValue productFeature = null;
             while ((productFeature = productFeatureEli.next()) != null) {
                 String productFeatureTypeId = 
productFeature.getString("productFeatureTypeId");

Modified: 
ofbiz/trunk/applications/product/src/org/ofbiz/product/feature/ProductFeatureServices.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/feature/ProductFeatureServices.java?rev=1641044&r1=1641043&r2=1641044&view=diff
==============================================================================
--- 
ofbiz/trunk/applications/product/src/org/ofbiz/product/feature/ProductFeatureServices.java
 (original)
+++ 
ofbiz/trunk/applications/product/src/org/ofbiz/product/feature/ProductFeatureServices.java
 Sat Nov 22 11:26:20 2014
@@ -36,6 +36,7 @@ import org.ofbiz.base.util.UtilValidate;
 import org.ofbiz.entity.Delegator;
 import org.ofbiz.entity.GenericEntityException;
 import org.ofbiz.entity.GenericValue;
+import org.ofbiz.entity.util.EntityQuery;
 import org.ofbiz.entity.util.EntityUtil;
 import org.ofbiz.service.DispatchContext;
 import org.ofbiz.service.GenericServiceException;
@@ -93,7 +94,7 @@ public class ProductFeatureServices {
 
         try {
             // get all product features in this feature category
-            List<GenericValue> allFeatures = 
delegator.findByAnd(entityToSearch, UtilMisc.toMap(fieldToSearch, 
valueToSearch), orderBy, false);
+            List<GenericValue> allFeatures = 
EntityQuery.use(delegator).from(entityToSearch).where(fieldToSearch, 
valueToSearch).orderBy(orderBy).queryList();
 
             if (entityToSearch.equals("ProductFeatureAndAppl") && 
productFeatureApplTypeId != null)
                 allFeatures = EntityUtil.filterByAnd(allFeatures, 
UtilMisc.toMap("productFeatureApplTypeId", productFeatureApplTypeId));
@@ -141,7 +142,7 @@ public class ProductFeatureServices {
              * see if it has every single feature in the list of 
productFeatureAppls as a STANDARD_FEATURE.  If so, then
              * it qualifies and add it to the list of 
existingVariantProductIds.
              */
-            List<GenericValue> productAssocs = 
EntityUtil.filterByDate(delegator.findByAnd("ProductAssoc", 
UtilMisc.toMap("productId", productId, "productAssocTypeId", 
"PRODUCT_VARIANT"), null, false));
+            List<GenericValue> productAssocs = 
EntityQuery.use(delegator).from("ProductAssoc").where("productId", productId, 
"productAssocTypeId", "PRODUCT_VARIANT").filterByDate().queryList();
             for (GenericValue productAssoc: productAssocs) {
 
                 //for each associated product, if it has all standard 
features, display it's productId
@@ -153,7 +154,7 @@ public class ProductFeatureServices {
 
                     //Debug.logInfo("Using findByMap: " + findByMap);
 
-                    List<GenericValue> standardProductFeatureAndAppls = 
EntityUtil.filterByDate(delegator.findByAnd("ProductFeatureAppl", findByMap, 
null, false));
+                    List<GenericValue> standardProductFeatureAndAppls = 
EntityQuery.use(delegator).from("ProductFeatureAppl").where(findByMap).filterByDate().queryList();
                     if (UtilValidate.isEmpty(standardProductFeatureAndAppls)) {
                         // Debug.logInfo("Does NOT have this standard 
feature");
                         hasAllFeatures = false;

Modified: 
ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/FrameImage.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/FrameImage.java?rev=1641044&r1=1641043&r2=1641044&view=diff
==============================================================================
--- 
ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/FrameImage.java
 (original)
+++ 
ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/FrameImage.java
 Sat Nov 22 11:26:20 2014
@@ -412,8 +412,7 @@ public class FrameImage {
         
         String frameDataResourceId = null;
         try {
-            List<GenericValue> contentDataResources = 
delegator.findByAnd("ContentDataResourceView", UtilMisc.toMap("contentId", 
frameContentId), null, false);
-            GenericValue contentDataResource = 
EntityUtil.getFirst(contentDataResources);
+            GenericValue contentDataResource = 
EntityQuery.use(delegator).from("ContentDataResourceView").where("contentId", 
frameContentId).queryFirst();
             frameDataResourceId = 
contentDataResource.getString("dataResourceId");
         } catch (Exception e) {
             request.setAttribute("_ERROR_MESSAGE_", e.getMessage());

Modified: 
ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementHelper.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementHelper.java?rev=1641044&r1=1641043&r2=1641044&view=diff
==============================================================================
--- 
ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementHelper.java
 (original)
+++ 
ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementHelper.java
 Sat Nov 22 11:26:20 2014
@@ -29,6 +29,7 @@ import org.ofbiz.base.util.UtilValidate;
 import org.ofbiz.entity.Delegator;
 import org.ofbiz.entity.GenericEntityException;
 import org.ofbiz.entity.GenericValue;
+import org.ofbiz.entity.util.EntityQuery;
 import org.ofbiz.entity.util.EntityUtil;
 
 public class ImageManagementHelper {
@@ -40,14 +41,14 @@ public class ImageManagementHelper {
         if (request == null) return internalImageUrl; 
         try {
             Delegator delegator = (Delegator) 
request.getAttribute("delegator");
-            List<GenericValue> defaultImageList = 
delegator.findByAnd("ProductContentAndInfo", UtilMisc.toMap("productId", 
productId, "productContentTypeId", "DEFAULT_IMAGE", "statusId", "IM_APPROVED", 
"drIsPublic", "N"), UtilMisc.toList("sequenceNum"), false);
+            List<GenericValue> defaultImageList = 
EntityQuery.use(delegator).from("ProductContentAndInfo").where("productId", 
productId, "productContentTypeId", "DEFAULT_IMAGE", "statusId", "IM_APPROVED", 
"drIsPublic", "N").orderBy("sequenceNum").queryList();
             if (UtilValidate.isNotEmpty(defaultImageList)) {
                 GenericValue productContent = 
EntityUtil.getFirst(defaultImageList);
                 if 
(UtilValidate.isNotEmpty(productContent.get("drObjectInfo"))) {
                     internalImageUrl = (String) 
productContent.get("drObjectInfo");
                 }
             } else {
-                List<GenericValue> productContentList = 
delegator.findByAnd("ProductContentAndInfo", UtilMisc.toMap("productId", 
productId, "productContentTypeId", "IMAGE", "statusId", "IM_APPROVED", 
"drIsPublic", "N"), UtilMisc.toList("sequenceNum"), false);
+                List<GenericValue> productContentList = 
EntityQuery.use(delegator).from("ProductContentAndInfo").where("productId", 
productId, "productContentTypeId", "IMAGE", "statusId", "IM_APPROVED", 
"drIsPublic", "N").orderBy("sequenceNum").queryList();
                 if (UtilValidate.isNotEmpty(productContentList)) {
                     GenericValue productContent = 
EntityUtil.getFirst(productContentList);
                     if 
(UtilValidate.isNotEmpty(productContent.get("drObjectInfo"))) {

Modified: 
ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementServices.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementServices.java?rev=1641044&r1=1641043&r2=1641044&view=diff
==============================================================================
--- 
ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementServices.java
 (original)
+++ 
ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementServices.java
 Sat Nov 22 11:26:20 2014
@@ -131,7 +131,7 @@ public class ImageManagementServices {
             
             List<GenericValue> fileExtension = FastList.newInstance();
             try {
-                fileExtension = delegator.findByAnd("FileExtension", 
UtilMisc.toMap("mimeTypeId", fileContentType ), null, false);
+                fileExtension = 
EntityQuery.use(delegator).from("FileExtension").where("mimeTypeId", 
fileContentType).queryList();
             } catch (GenericEntityException e) {
                 Debug.logError(e, module);
                 return ServiceUtil.returnError(e.getMessage());
@@ -543,7 +543,7 @@ public class ImageManagementServices {
         
         List<GenericValue> fileExtensionThumb = FastList.newInstance();
         try {
-            fileExtensionThumb = delegator.findByAnd("FileExtension", 
UtilMisc.toMap("mimeTypeId", fileContentType), null, false);
+            fileExtensionThumb = 
EntityQuery.use(delegator).from("FileExtension").where("mimeTypeId", 
fileContentType).queryList();
         } catch (GenericEntityException e) {
             Debug.logError(e, module);
             return ServiceUtil.returnError(e.getMessage());
@@ -795,8 +795,7 @@ public class ImageManagementServices {
         String imageUrl = imageServerUrl + "/" + productId + "/" + 
filenameToUse;
         
         try {
-            List<GenericValue> productContentList = 
delegator.findByAnd("ProductContentAndInfo", UtilMisc.toMap("productId", 
productId, "contentId", contentId, "productContentTypeId", "IMAGE"), null, 
false);
-            GenericValue productContent = 
EntityUtil.getFirst(productContentList);
+            GenericValue productContent = 
EntityQuery.use(delegator).from("ProductContentAndInfo").where("productId", 
productId, "contentId", contentId, "productContentTypeId", 
"IMAGE").queryFirst();
             String dataResourceName = (String) 
productContent.get("drDataResourceName");
             String mimeType = 
filenameToUse.substring(filenameToUse.lastIndexOf("."));
             
@@ -848,12 +847,12 @@ public class ImageManagementServices {
                     }
                 }
                 
-                List<GenericValue> contentAssocList = 
delegator.findByAnd("ContentAssoc", UtilMisc.toMap("contentId", contentId, 
"contentAssocTypeId", "IMAGE_THUMBNAIL"), null, false);
+                List<GenericValue> contentAssocList = 
EntityQuery.use(delegator).from("ContentAssoc").where("contentId", contentId, 
"contentAssocTypeId", "IMAGE_THUMBNAIL").queryList();
                 if (contentAssocList.size() > 0) {
                     for (int i = 0; i < contentAssocList.size(); i++) {
                         GenericValue contentAssoc = contentAssocList.get(i);
                         
-                        List<GenericValue> dataResourceAssocList = 
delegator.findByAnd("ContentDataResourceView", UtilMisc.toMap("contentId", 
contentAssoc.get("contentIdTo")), null, false);
+                        List<GenericValue> dataResourceAssocList = 
EntityQuery.use(delegator).from("ContentDataResourceView").where("contentId", 
contentAssoc.get("contentIdTo")).queryList();
                         GenericValue dataResourceAssoc = 
EntityUtil.getFirst(dataResourceAssocList);
                         
                         String drDataResourceNameAssoc = (String) 
dataResourceAssoc.get("drDataResourceName");

Modified: 
ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ReplaceImage.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ReplaceImage.java?rev=1641044&r1=1641043&r2=1641044&view=diff
==============================================================================
--- 
ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ReplaceImage.java
 (original)
+++ 
ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ReplaceImage.java
 Sat Nov 22 11:26:20 2014
@@ -34,6 +34,7 @@ import org.ofbiz.base.util.UtilValidate;
 import org.ofbiz.base.util.string.FlexibleStringExpander;
 import org.ofbiz.entity.Delegator;
 import org.ofbiz.entity.GenericValue;
+import org.ofbiz.entity.util.EntityQuery;
 import org.ofbiz.entity.util.EntityUtil;
 import org.ofbiz.service.DispatchContext;
 import org.ofbiz.service.LocalDispatcher;
@@ -79,19 +80,16 @@ public class ReplaceImage{
             BufferedImage bufImg = ImageIO.read(new File(imageServerPath + "/" 
+ productId + "/" + dataResourceNameReplace));
             ImageIO.write(bufImg, "jpg", new File(imageServerPath + "/" + 
productId + "/" + dataResourceNameExist));
             
-            List<GenericValue> contentAssocReplaceList = 
delegator.findByAnd("ContentAssoc", UtilMisc.toMap("contentId", 
contentIdReplace, "contentAssocTypeId", "IMAGE_THUMBNAIL"), null, false);
+            List<GenericValue> contentAssocReplaceList = 
EntityQuery.use(delegator).from("ContentAssoc").where("contentId", 
contentIdReplace, "contentAssocTypeId", "IMAGE_THUMBNAIL").queryList();
             if (contentAssocReplaceList.size() > 0) {
                 for (int i = 0; i < contentAssocReplaceList.size(); i++) {
                     GenericValue contentAssocReplace = 
contentAssocReplaceList.get(i);
                     
-                    List<GenericValue> dataResourceAssocReplaceList = 
delegator.findByAnd("ContentDataResourceView", UtilMisc.toMap("contentId", 
contentAssocReplace.get("contentIdTo")), null, false);
-                    GenericValue dataResourceAssocReplace = 
EntityUtil.getFirst(dataResourceAssocReplaceList);
+                    GenericValue dataResourceAssocReplace = 
EntityQuery.use(delegator).from("ContentDataResourceView").where("contentId", 
contentAssocReplace.get("contentIdTo")).queryFirst();
                     
-                    List<GenericValue> contentAssocExistList = 
delegator.findByAnd("ContentAssoc", UtilMisc.toMap("contentId", contentIdExist, 
"contentAssocTypeId", "IMAGE_THUMBNAIL", "mapKey", 
contentAssocReplace.get("mapKey")), null, false);
-                    GenericValue contentAssocExist = 
EntityUtil.getFirst(contentAssocExistList);
+                    GenericValue contentAssocExist = 
EntityQuery.use(delegator).from("ContentAssoc").where("contentId", 
contentIdExist, "contentAssocTypeId", "IMAGE_THUMBNAIL", "mapKey", 
contentAssocReplace.get("mapKey")).queryFirst();
                     
-                    List<GenericValue> dataResourceAssocExistList = 
delegator.findByAnd("ContentDataResourceView", UtilMisc.toMap("contentId", 
contentAssocExist.get("contentIdTo")), null, false);
-                    GenericValue dataResourceAssocExist = 
EntityUtil.getFirst(dataResourceAssocExistList);
+                    GenericValue dataResourceAssocExist = 
EntityQuery.use(delegator).from("ContentDataResourceView").where("contentId", 
contentAssocExist.get("contentIdTo")).queryFirst();
                     
                     if (UtilValidate.isNotEmpty(dataResourceAssocExist)) {
                         BufferedImage bufImgAssocReplace = ImageIO.read(new 
File(imageServerPath + "/" + productId + "/" + 
dataResourceAssocReplace.get("drDataResourceName")));
@@ -104,8 +102,7 @@ public class ReplaceImage{
                 }
             }
             
-            List<GenericValue> productContentList = 
delegator.findByAnd("ProductContent", UtilMisc.toMap("productId", productId, 
"contentId", contentIdReplace, "productContentTypeId", "IMAGE"), null, false);
-            GenericValue productContent = 
EntityUtil.getFirst(productContentList);
+            GenericValue productContent = 
EntityQuery.use(delegator).from("ProductContent").where("productId", productId, 
"contentId", contentIdReplace, "productContentTypeId", "IMAGE").queryFirst();
             
             if (productContent != null) {
                 Map<String, Object> productContentCtx = FastMap.newInstance();

Modified: 
ofbiz/trunk/applications/product/src/org/ofbiz/product/inventory/InventoryServices.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/inventory/InventoryServices.java?rev=1641044&r1=1641043&r2=1641044&view=diff
==============================================================================
--- 
ofbiz/trunk/applications/product/src/org/ofbiz/product/inventory/InventoryServices.java
 (original)
+++ 
ofbiz/trunk/applications/product/src/org/ofbiz/product/inventory/InventoryServices.java
 Sat Nov 22 11:26:20 2014
@@ -226,8 +226,7 @@ public class InventoryServices {
         Locale locale = (Locale) context.get("locale");
 
         try {
-            inventoryTransfer = delegator.findOne("InventoryTransfer",
-                    UtilMisc.toMap("inventoryTransferId", 
inventoryTransferId), false);
+            inventoryTransfer = 
EntityQuery.use(delegator).from("InventoryTransfer").where("inventoryTransferId",
 inventoryTransferId).queryOne();
             inventoryItem = inventoryTransfer.getRelatedOne("InventoryItem", 
false);
             destinationFacility = 
inventoryTransfer.getRelatedOne("ToFacility", false);
         } catch (GenericEntityException e) {
@@ -339,8 +338,7 @@ public class InventoryServices {
         Locale locale = (Locale) context.get("locale");
 
         try {
-            inventoryTransfer = delegator.findOne("InventoryTransfer",
-                    UtilMisc.toMap("inventoryTransferId", 
inventoryTransferId), false);
+            inventoryTransfer = 
EntityQuery.use(delegator).from("InventoryTransfer").where("inventoryTransferId",
 inventoryTransferId).queryOne();
             if (UtilValidate.isEmpty(inventoryTransfer)) {
                 return 
ServiceUtil.returnError(UtilProperties.getMessage(resource, 
                         "ProductInventoryItemTransferNotFound", 
@@ -429,8 +427,7 @@ public class InventoryServices {
         // find all inventory items w/ a negative ATP
         List<GenericValue> inventoryItems = null;
         try {
-            EntityExpr ee = 
EntityCondition.makeCondition("availableToPromiseTotal", 
EntityOperator.LESS_THAN, BigDecimal.ZERO);
-            inventoryItems = delegator.findList("InventoryItem", ee, null, 
null, null, false);
+            inventoryItems = 
EntityQuery.use(delegator).from("InventoryItem").where(EntityCondition.makeCondition("availableToPromiseTotal",
 EntityOperator.LESS_THAN, BigDecimal.ZERO)).queryList();
         } catch (GenericEntityException e) {
             Debug.logError(e, "Trouble getting inventory items", module);
             return ServiceUtil.returnError(UtilProperties.getMessage(resource, 
@@ -454,8 +451,7 @@ public class InventoryServices {
                 exprs.add(EntityCondition.makeCondition("statusId", 
EntityOperator.NOT_EQUAL, "SHIPMENT_DELIVERED"));
                 exprs.add(EntityCondition.makeCondition("statusId", 
EntityOperator.NOT_EQUAL, "SHIPMENT_CANCELLED"));
 
-                EntityConditionList<EntityExpr> ecl = 
EntityCondition.makeCondition(exprs, EntityOperator.AND);
-                shipmentAndItems = delegator.findList("ShipmentAndItem", ecl, 
null, UtilMisc.toList("estimatedArrivalDate"), null, false);
+                shipmentAndItems = 
EntityQuery.use(delegator).from("ShipmentAndItem").where(EntityCondition.makeCondition(exprs,
 EntityOperator.AND)).orderBy("estimatedArrivalDate").queryList();
             } catch (GenericEntityException e) {
                 Debug.logError(e, "Problem getting ShipmentAndItem records", 
module);
                 return 
ServiceUtil.returnError(UtilProperties.getMessage(resource, 
@@ -593,8 +589,7 @@ public class InventoryServices {
 
             List<GenericValue> orderItemShipGroups = null;
             try {
-                orderItemShipGroups= delegator.findByAnd("OrderItemShipGroup",
-                        UtilMisc.toMap("orderId", orderId), null, false);
+                orderItemShipGroups= 
EntityQuery.use(delegator).from("OrderItemShipGroup").where("orderId", 
orderId).queryList();
             } catch (GenericEntityException e) {
                 Debug.logError(e, "Cannot get OrderItemShipGroups from 
orderId" + orderId, module);
             }
@@ -603,12 +598,7 @@ public class InventoryServices {
                 List<GenericValue> orderItems = FastList.newInstance();
                 List<GenericValue> orderItemShipGroupAssoc = null;
                 try {
-                    orderItemShipGroupAssoc =
-                        delegator.findByAnd("OrderItemShipGroupAssoc",
-                                UtilMisc.toMap("shipGroupSeqId",
-                                        
orderItemShipGroup.get("shipGroupSeqId"),
-                                        "orderId",
-                                        orderId), null, false);
+                    orderItemShipGroupAssoc = 
EntityQuery.use(delegator).from("OrderItemShipGroupAssoc").where("shipGroupSeqId",
 orderItemShipGroup.get("shipGroupSeqId"), "orderId", orderId).queryList();
 
                     for (GenericValue assoc: orderItemShipGroupAssoc) {
                         GenericValue orderItem = 
assoc.getRelatedOne("OrderItem", false);
@@ -784,9 +774,9 @@ public class InventoryServices {
         List<GenericValue> facilities = null;
         try {
             if (facilityId != null) {
-                facilities = delegator.findByAnd("Facility", 
UtilMisc.toMap("facilityId", facilityId), null, false);
+                facilities = 
EntityQuery.use(delegator).from("Facility").where("facilityId", 
facilityId).queryList();
             } else {
-                facilities = delegator.findList("Facility", null, null, null, 
null, false);
+                facilities = 
EntityQuery.use(delegator).from("Facility").queryList();
             }
         } catch (GenericEntityException e) {
             return ServiceUtil.returnError(UtilProperties.getMessage(resource, 
@@ -921,7 +911,7 @@ public class InventoryServices {
 
         List<GenericValue> productPrices = null;
         try {
-            productPrices = delegator.findByAnd("ProductPrice", 
UtilMisc.toMap("productId",productId), UtilMisc.toList("-fromDate"), true);
+            productPrices = 
EntityQuery.use(delegator).from("ProductPrice").where("productId",productId).orderBy("-fromDate").cache(true).queryList();
         } catch (GenericEntityException e) {
             // TODO Auto-generated catch block
             e.printStackTrace();
@@ -979,17 +969,16 @@ public class InventoryServices {
             // Make a query against the sales usage view entity
             EntityListIterator salesUsageIt = null;
             try {
-                salesUsageIt = 
delegator.findListIteratorByCondition(salesUsageViewEntity,
-                        EntityCondition.makeCondition(
-                            UtilMisc.toList(
-                                EntityCondition.makeCondition("facilityId", 
EntityOperator.EQUALS, facilityId),
-                                EntityCondition.makeCondition("productId", 
EntityOperator.EQUALS, productId),
-                                EntityCondition.makeCondition("statusId", 
EntityOperator.IN, UtilMisc.toList("ORDER_COMPLETED", "ORDER_APPROVED", 
"ORDER_HELD")),
-                                EntityCondition.makeCondition("orderTypeId", 
EntityOperator.EQUALS, "SALES_ORDER"),
-                                EntityCondition.makeCondition("orderDate", 
EntityOperator.GREATER_THAN_EQUAL_TO, checkTime)
-                           ),
-                        EntityOperator.AND),
-                    null, null, null, null);
+                EntityCondition cond = EntityCondition.makeCondition(
+                        UtilMisc.toList(
+                            EntityCondition.makeCondition("facilityId", 
EntityOperator.EQUALS, facilityId),
+                            EntityCondition.makeCondition("productId", 
EntityOperator.EQUALS, productId),
+                            EntityCondition.makeCondition("statusId", 
EntityOperator.IN, UtilMisc.toList("ORDER_COMPLETED", "ORDER_APPROVED", 
"ORDER_HELD")),
+                            EntityCondition.makeCondition("orderTypeId", 
EntityOperator.EQUALS, "SALES_ORDER"),
+                            EntityCondition.makeCondition("orderDate", 
EntityOperator.GREATER_THAN_EQUAL_TO, checkTime)
+                       ),
+                    EntityOperator.AND);
+                salesUsageIt = 
EntityQuery.use(delegator).from(salesUsageViewEntity).where(cond).queryIterator();
             } catch (GenericEntityException e2) {
                 // TODO Auto-generated catch block
                 e2.printStackTrace();
@@ -1017,16 +1006,15 @@ public class InventoryServices {
             // Make a query against the production usage view entity
             EntityListIterator productionUsageIt = null;
             try {
-                productionUsageIt = 
delegator.findListIteratorByCondition(productionUsageViewEntity,
-                        EntityCondition.makeCondition(
+                EntityCondition conditions = EntityCondition.makeCondition(
                             UtilMisc.toList(
                                 EntityCondition.makeCondition("facilityId", 
EntityOperator.EQUALS, facilityId),
                                 EntityCondition.makeCondition("productId", 
EntityOperator.EQUALS, productId),
                                 
EntityCondition.makeCondition("workEffortTypeId", EntityOperator.EQUALS, 
"PROD_ORDER_TASK"),
                                 
EntityCondition.makeCondition("actualCompletionDate", 
EntityOperator.GREATER_THAN_EQUAL_TO, checkTime)
                            ),
-                        EntityOperator.AND),
-                    null, null, null, null);
+                        EntityOperator.AND);
+                productionUsageIt = 
EntityQuery.use(delegator).from(productionUsageViewEntity).where(conditions).queryIterator();
             } catch (GenericEntityException e1) {
                 // TODO Auto-generated catch block
                 e1.printStackTrace();

Modified: 
ofbiz/trunk/applications/product/src/org/ofbiz/product/inventory/InventoryWorker.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/inventory/InventoryWorker.java?rev=1641044&r1=1641043&r2=1641044&view=diff
==============================================================================
--- 
ofbiz/trunk/applications/product/src/org/ofbiz/product/inventory/InventoryWorker.java
 (original)
+++ 
ofbiz/trunk/applications/product/src/org/ofbiz/product/inventory/InventoryWorker.java
 Sat Nov 22 11:26:20 2014
@@ -36,6 +36,7 @@ import org.ofbiz.entity.GenericValue;
 import org.ofbiz.entity.condition.EntityCondition;
 import org.ofbiz.entity.condition.EntityConditionList;
 import org.ofbiz.entity.condition.EntityOperator;
+import org.ofbiz.entity.util.EntityQuery;
 
 public class InventoryWorker {
 
@@ -57,8 +58,10 @@ public class InventoryWorker {
                     EntityCondition.makeCondition("itemStatusId", 
EntityOperator.NOT_EQUAL, "ITEM_REJECTED"));
             
purchaseOrderConditions.add(EntityCondition.makeCondition("orderTypeId", 
EntityOperator.EQUALS, "PURCHASE_ORDER"));
             
purchaseOrderConditions.add(EntityCondition.makeCondition("productId", 
EntityOperator.EQUALS, productId));
-            List<GenericValue> purchaseOrders = 
delegator.findList("OrderHeaderAndItems", 
EntityCondition.makeCondition(purchaseOrderConditions, EntityOperator.AND),
-                    null, UtilMisc.toList("estimatedDeliveryDate DESC", 
"orderDate"), null, false);
+            List<GenericValue> purchaseOrders = 
EntityQuery.use(delegator).from("OrderHeaderAndItems")
+                    
.where(EntityCondition.makeCondition(purchaseOrderConditions, 
EntityOperator.AND))
+                    .orderBy("estimatedDeliveryDate DESC", "orderDate")
+                    .queryList();
             return purchaseOrders;
         } catch (GenericEntityException ex) {
             Debug.logError("Unable to find outstanding purchase orders for 
product [" + productId + "] due to " + ex.getMessage() + " - returning null", 
module);
@@ -123,7 +126,7 @@ public class InventoryWorker {
 
         Map<String, BigDecimal> results = FastMap.newInstance();
         try {
-            List<GenericValue> orderedProducts = 
delegator.findList("OrderItemQuantityReportGroupByProduct", conditions, 
fieldsToSelect, null, null, false);
+            List<GenericValue> orderedProducts = 
EntityQuery.use(delegator).select(fieldsToSelect).from("OrderItemQuantityReportGroupByProduct").where(conditions).queryList();
             for (GenericValue value: orderedProducts) {
                 results.put(value.getString("productId"), 
value.getBigDecimal("quantityOpen"));
             }


Reply via email to