Author: mridulpathak
Date: Sat Apr 16 13:59:54 2016
New Revision: 1739463
URL: http://svn.apache.org/viewvc?rev=1739463&view=rev
Log:
[OFBIZ-6781] Incorrect order adjustment after order item is cancelled. Thanks
Vyom Jain for reporting the issue and Suraj Khurana for providing the patch.
Modified:
ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderServices.xml
Modified:
ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderServices.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderServices.xml?rev=1739463&r1=1739462&r2=1739463&view=diff
==============================================================================
---
ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderServices.xml
(original)
+++
ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderServices.xml
Sat Apr 16 13:59:54 2016
@@ -577,7 +577,10 @@ under the License.
<iterate list="orderAdjustments" entry="orderAdjustment">
<if>
<condition>
- <not><if-empty
field="orderAdjustment.productPromoId"/></not>
+ <and>
+ <not><if-empty
field="orderAdjustment.orderAdjustmentTypeId"/></not>
+ <if-compare operator="equals"
value="PROMOTION_ADJUSTMENT"
field="orderAdjustment.orderAdjustmentTypeId"></if-compare>
+ </and>
</condition>
<then>
<calculate field="existingOrderAdjustmentTotal"
decimal-scale="3">
@@ -633,7 +636,10 @@ under the License.
<iterate list="adjustments" entry="adjustment">
<if>
<condition>
- <not><if-empty field="adjustment.productPromoId"/></not>
+ <and>
+ <not><if-empty
field="adjustment.productPromoId"/></not>
+ <if-empty field="adjustment.orderAdjustmentId"/>
+ </and>
</condition>
<then>
<calculate field="newOrderAdjustmentTotal"
decimal-scale="3">
