Author: pranayp
Date: Mon Jun 13 13:17:21 2016
New Revision: 1748218
URL: http://svn.apache.org/viewvc?rev=1748218&view=rev
Log:
[OFBIZ-7115] Fixed terminal errors on Timesheet overview page of projectmgr and
scrum. Removed the check on workEffortId which was not making difference or
directing any purpose and causing errors.
Thanks Vaibhav Jain for reporting the issue and providing initial patch, thanks
Amardeep Singh Jhajj and Jacques for reviewing the patch and providing your
comments, thanks Montalbano Florian for providing final patch including Scrum
component.
Modified:
ofbiz/trunk/specialpurpose/projectmgr/widget/forms/TimeSheetForms.xml
ofbiz/trunk/specialpurpose/scrum/widget/MyWorkForms.xml
ofbiz/trunk/specialpurpose/scrum/widget/TimeSheetForms.xml
Modified: ofbiz/trunk/specialpurpose/projectmgr/widget/forms/TimeSheetForms.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/projectmgr/widget/forms/TimeSheetForms.xml?rev=1748218&r1=1748217&r2=1748218&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/projectmgr/widget/forms/TimeSheetForms.xml
(original)
+++ ofbiz/trunk/specialpurpose/projectmgr/widget/forms/TimeSheetForms.xml Mon
Jun 13 13:17:21 2016
@@ -42,7 +42,7 @@
<entity-order-by field-name="sequenceNum"/>
<entity-order-by field-name="workEffortName"/>
</entity-options>
- <sub-hyperlink target="taskView"
description="${groovy:workEffortId!=void&&!"Totals".equals(workEffortId)?workEffortId:""}">
+ <sub-hyperlink target="taskView" description="${workEffortId}">
<parameter param-name="workEffortId"/>
<parameter param-name="my"/>
</sub-hyperlink>
@@ -206,9 +206,7 @@
<form name="QuickCreateTimeEntry" target="createQuickTimeEntry" title=""
type="single"
header-row-style="header-row" default-table-style="basic-table">
<actions>
- <entity-one entity-name="WorkEffort">
- <field-map field-name="workEffortId" from-field=""/>
- </entity-one>
+ <entity-one entity-name="WorkEffort" value-field="workEffortId"/>
</actions>
<field name="timesheetId" map-name="currentTimesheet"><hidden/></field>
<field name="partyId" map-name="userLogin"><hidden/></field>
Modified: ofbiz/trunk/specialpurpose/scrum/widget/MyWorkForms.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/scrum/widget/MyWorkForms.xml?rev=1748218&r1=1748217&r2=1748218&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/scrum/widget/MyWorkForms.xml (original)
+++ ofbiz/trunk/specialpurpose/scrum/widget/MyWorkForms.xml Mon Jun 13 13:17:21
2016
@@ -132,7 +132,7 @@
<drop-down allow-empty="true"
current-description="${result.projectId} ${product.productId} -
${result.projectName}${product.internalName} - ${result.sprintName} -
${groovy:result.backlogName.toString().substring(0,Math.min(result.backlogName.toString().length(),30))}[${result.backlogId}]
-
${groovy:result.taskName.toString().substring(0,Math.min(result.taskName.toString().length(),30))}[${result.taskId}]">
<list-options key-name="taskId" list-name="taskListDropdown"
description="${projectId}${productId} - ${projectName} ${productName} -
${sprintName} - ${groovy: if (description)
description.substring(0,Math.min(description.length(),30))} [${custRequestId}]
- ${groovy:taskName.substring(0,Math.min(taskName.length(),20))}[${taskId}]"/>
<entity-options entity-name="EmplLeaveType"
key-field-name="leaveTypeId"/>
- <sub-hyperlink target="taskView"
description="${groovy:workEffortId!=void&&!"Totals".equals(workEffortId)?workEffortId:""}"
target-window="_blank">
+ <sub-hyperlink target="taskView" description="${workEffortId}">
<parameter param-name="taskId" from-field="workEffortId"/>
</sub-hyperlink>
</drop-down>
@@ -163,4 +163,4 @@
<field name="updateButton"><submit button-type="button"/></field>
<field name="_rowSubmit" title="${uiLabelMap.ScrumRowSubmit}"><hidden
value="Y"/></field>
</form>
-</forms>
\ No newline at end of file
+</forms>
Modified: ofbiz/trunk/specialpurpose/scrum/widget/TimeSheetForms.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/scrum/widget/TimeSheetForms.xml?rev=1748218&r1=1748217&r2=1748218&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/scrum/widget/TimeSheetForms.xml (original)
+++ ofbiz/trunk/specialpurpose/scrum/widget/TimeSheetForms.xml Mon Jun 13
13:17:21 2016
@@ -145,7 +145,7 @@
<drop-down allow-empty="true"
current-description="${result.projectId} ${product.productId} -
${result.projectName}${product.internalName} - ${result.sprintName} -
${groovy:result.backlogName.toString().substring(0,Math.min(result.backlogName.toString().length(),30))}[${result.backlogId}]
-
${groovy:result.taskName.toString().substring(0,Math.min(result.taskName.toString().length(),30))}[${result.taskId}]">
<list-options key-name="taskId" list-name="taskListDropdown"
description="${projectId}${productId} - ${projectName} ${productName} -
${sprintName} - ${groovy: if (description)
description.substring(0,Math.min(description.length(),30))} [${custRequestId}]
- ${groovy:taskName.substring(0,Math.min(taskName.length(),20))}[${taskId}]"/>
<entity-options entity-name="EmplLeaveType"
key-field-name="leaveTypeId"/>
- <sub-hyperlink target="taskView"
description="${groovy:workEffortId!=void&&!"Totals".equals(workEffortId)?workEffortId:""}"
target-window="_blank">
+ <sub-hyperlink target="taskView" description="${workEffortId}">
<parameter param-name="taskId" from-field="workEffortId"/>
</sub-hyperlink>
</drop-down>
@@ -198,4 +198,4 @@
<field entry-name="dummy" name="requiredDate"
title="${uiLabelMap.ScrumSelectedDate}"><date-time type="date"/></field>
<field name="addButton"><submit/></field>
</form>
-</forms>
\ No newline at end of file
+</forms>
