Author: jleroux
Revision: 1804843
Modified property: svn:log

Modified: svn:log at Fri Aug 11 19:26:48 2017
------------------------------------------------------------------------------
--- svn:log (original)
+++ svn:log Fri Aug 11 19:26:48 2017
@@ -1,12 +1,13 @@
-Fixed: Missing action in empty if-statement in 
accounting.PaymentGatewayServices
-(OFBIZ-9530)
+Fixed: [FB] Package org.apache.ofbiz.accounting.payment (Additional Bugs)
+(OFBIZ-9529)
 
-In the method processAuthResult() line 1889 there is an empty if-statement for 
-the case that authResult is null. It seems like somebody was planning to cover 
-the case but forgot to add code.
+This patch resolves bugs from GiftCertificateServices
 
-I would suggest to return a service error when the authResult is null since 
-otherwise it cannot be determined if the payment is authorized or not.
+PaymentGatewayServices.java:1889, UCF_USELESS_CONTROL_FLOW
 
+UCF: Useless control flow in 
+PaymentGatewayServices.processAuthResult(DispatchContext, Map)
+This method contains a useless control flow statement, where control flow 
continues onto 
+the same place regardless of whether or not the branch is taken.
 
 Thanks: Kyra Pritzel-Hentley

Reply via email to