Author: deepak
Date: Sat Feb 24 10:22:18 2018
New Revision: 1825205

URL: http://svn.apache.org/viewvc?rev=1825205&view=rev
Log:
Alert message : Developer: for lookups to work you must provide a form name! 
appears when try to select contentId from Lookup.
Applied slightly modified patch (OFBIZ-10012)
Thanks  Sonal for reporting and Aditya Sharma for providing patch for the issue

Modified:
    ofbiz/ofbiz-framework/trunk/applications/content/widget/CommonScreens.xml
    
ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
    
ofbiz/ofbiz-framework/trunk/themes/common-theme/template/includes/HtmlTemplate.ftl
    
ofbiz/ofbiz-framework/trunk/themes/common-theme/template/macro/HtmlFormMacroLibrary.ftl
    
ofbiz/ofbiz-framework/trunk/themes/common-theme/webapp/common/js/util/OfbizUtil.js
    
ofbiz/ofbiz-framework/trunk/themes/common-theme/webapp/common/js/util/fieldlookup.js
    ofbiz/ofbiz-framework/trunk/themes/flatgrey/webapp/flatgrey/style.css
    
ofbiz/ofbiz-framework/trunk/themes/rainbowstone/webapp/rainbowstone/style.css
    ofbiz/ofbiz-framework/trunk/themes/tomahawk/webapp/tomahawk/css/style.css

Modified: 
ofbiz/ofbiz-framework/trunk/applications/content/widget/CommonScreens.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/content/widget/CommonScreens.xml?rev=1825205&r1=1825204&r2=1825205&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/content/widget/CommonScreens.xml 
(original)
+++ ofbiz/ofbiz-framework/trunk/applications/content/widget/CommonScreens.xml 
Sat Feb 24 10:22:18 2018
@@ -33,7 +33,6 @@ under the License.
                 <set field="layoutSettings.companyName" 
from-field="uiLabelMap.ContentCompanyName" global="true"/>
                 <set field="layoutSettings.companySubtitle" 
from-field="uiLabelMap.ContentCompanySubtitle" global="true"/>
                 <set field="layoutSettings.styleSheets[]" 
value="/contentimages/css/contentForum.css" global="true"/>
-                <set field="layoutSettings.javaScripts[]" 
value="/common/js/util/OfbizUtil.js" global="true"/>
                 <set field="activeApp" value="contentmgr" global="true"/>
                 <set field="applicationMenuName" value="ContentAppBar" 
global="true"/>
                 <set field="applicationMenuLocation" 
value="component://content/widget/content/ContentMenus.xml" global="true"/>

Modified: 
ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java?rev=1825205&r1=1825204&r2=1825205&view=diff
==============================================================================
--- 
ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
 (original)
+++ 
ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
 Sat Feb 24 10:22:18 2018
@@ -2182,17 +2182,8 @@ public final class MacroFormRenderer imp
             lookupPresentation = "";
         }
         String lookupHeight = lookupField.getLookupHeight();
-        if (UtilValidate.isEmpty(lookupHeight)) {
-            lookupHeight = "";
-        }
         String lookupWidth = lookupField.getLookupWidth();
-        if (UtilValidate.isEmpty(lookupWidth)) {
-            lookupWidth = "";
-        }
         String lookupPosition = lookupField.getLookupPosition();
-        if (UtilValidate.isEmpty(lookupPosition)) {
-            lookupPosition = "";
-        }
         String fadeBackground = lookupField.getFadeBackground();
         if (UtilValidate.isEmpty(fadeBackground)) {
             fadeBackground = "false";
@@ -2262,12 +2253,18 @@ public final class MacroFormRenderer imp
         sr.append(Boolean.toString(ajaxEnabled));
         sr.append(" presentation=\"");
         sr.append(lookupPresentation);
-        sr.append("\" height=\"");
-        sr.append(lookupHeight);
-        sr.append("\" width=\"");
-        sr.append(lookupWidth);
-        sr.append("\" position=\"");
-        sr.append(lookupPosition);
+        if (UtilValidate.isNotEmpty(lookupHeight)) {
+            sr.append("\" height=\"");
+            sr.append(lookupHeight);
+        }
+        if (UtilValidate.isNotEmpty(lookupWidth)) {
+            sr.append("\" width=\"");
+            sr.append(lookupWidth);
+        }
+        if (UtilValidate.isNotEmpty(lookupPosition)) {
+            sr.append("\" position=\"");
+            sr.append(lookupPosition);
+        }
         sr.append("\" fadeBackground=\"");
         sr.append(fadeBackground);
         sr.append("\" clearText=\"");

Modified: 
ofbiz/ofbiz-framework/trunk/themes/common-theme/template/includes/HtmlTemplate.ftl
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/themes/common-theme/template/includes/HtmlTemplate.ftl?rev=1825205&r1=1825204&r2=1825205&view=diff
==============================================================================
--- 
ofbiz/ofbiz-framework/trunk/themes/common-theme/template/includes/HtmlTemplate.ftl
 (original)
+++ 
ofbiz/ofbiz-framework/trunk/themes/common-theme/template/includes/HtmlTemplate.ftl
 Sat Feb 24 10:22:18 2018
@@ -17,7 +17,7 @@ specific language governing permissions
 under the License.
 -->
 
-<#macro lookupField className="" alert="" name="" value="" size="20" 
maxlength="20" id="" event="" action="" readonly="" autocomplete="" 
descriptionFieldName="" formName="" fieldFormName="" targetParameterIter="" 
imgSrc="" ajaxUrl="" ajaxEnabled="" presentation="layer" width="" height="" 
position="topleft" fadeBackground="true" clearText="" showDescription="" 
initiallyCollapsed="" tabindex="">
+<#macro lookupField className="" alert="" name="" value="" size="20" 
maxlength="20" id="" event="" action="" readonly="" autocomplete="" 
descriptionFieldName="" formName="" fieldFormName="" targetParameterIter="" 
imgSrc="" ajaxUrl="" ajaxEnabled="" presentation="layer" 
width=modelTheme.getLookupWidth() height=modelTheme.getLookupHeight() 
position="topleft" fadeBackground="true" clearText="" showDescription="" 
initiallyCollapsed="" tabindex="">
   <#if (!ajaxEnabled?has_content)>
     <#assign javascriptEnabled = 
Static["org.apache.ofbiz.base.util.UtilHttp"].isJavaScriptEnabled(request) />
     <#if (javascriptEnabled)>

Modified: 
ofbiz/ofbiz-framework/trunk/themes/common-theme/template/macro/HtmlFormMacroLibrary.ftl
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/themes/common-theme/template/macro/HtmlFormMacroLibrary.ftl?rev=1825205&r1=1825204&r2=1825205&view=diff
==============================================================================
--- 
ofbiz/ofbiz-framework/trunk/themes/common-theme/template/macro/HtmlFormMacroLibrary.ftl
 (original)
+++ 
ofbiz/ofbiz-framework/trunk/themes/common-theme/template/macro/HtmlFormMacroLibrary.ftl
 Sat Feb 24 10:22:18 2018
@@ -612,69 +612,50 @@ Parameter: lastViewName, String, optiona
 Parameter: tabindex, String, optional - HTML tabindex number.
 Parameter: delegatorName, String, optional - name of the delegator in context.
 -->
-<#macro renderLookupField name formName fieldFormName className="" 
alert="false" value="" size="" maxlength="" id="" event="" action="" 
readonly=false autocomplete="" descriptionFieldName="" targetParameterIter="" 
imgSrc="" ajaxUrl="" ajaxEnabled=javaScriptEnabled presentation="layer" 
width="" height="" position="" fadeBackground="true" clearText="" 
showDescription="" initiallyCollapsed="" lastViewName="main" tabindex="" 
delegatorName="default">
+<#macro renderLookupField name formName fieldFormName className="" 
alert="false" value="" size="" maxlength="" id="" event="" action="" 
readonly=false autocomplete="" descriptionFieldName="" targetParameterIter="" 
imgSrc="" ajaxUrl="" ajaxEnabled=javaScriptEnabled presentation="layer" 
width=modelTheme.getLookupWidth() height=modelTheme.getLookupHeight() 
position=modelTheme.getLookupPosition() fadeBackground="true" clearText="" 
showDescription="" initiallyCollapsed="" lastViewName="main" tabindex="" 
delegatorName="default">
   <#if 
Static["org.apache.ofbiz.widget.model.ModelWidget"].widgetBoundaryCommentsEnabled(context)><#--
 context is always null here, but this is handled in 
widgetBoundaryCommentsEnabled -->
   <!-- @renderLookupField -->
   </#if>
-  <#if (!ajaxUrl?has_content) && ajaxEnabled?has_content && ajaxEnabled>
-    <#local ajaxUrl = requestAttributes._REQUEST_HANDLER_.makeLink(request, 
response, fieldFormName)/>
-    <#local ajaxUrl = id + "," + ajaxUrl + ",ajaxLookup=Y" />
-  </#if>
   <#if (!showDescription?has_content)>
-    <#local showDescriptionProp = modelTheme.getLookupShowDescription()>
-    <#if "Y" == showDescriptionProp>
+    <#local showDescription = "false" />
+    <#if "Y" == modelTheme.getLookupShowDescription()>
       <#local showDescription = "true" />
-    <#else>
-      <#local showDescription = "false" />
     </#if>
   </#if>
-  <#if (!position?has_content)>
-    <#local position = modelTheme.getLookupPosition()>
-  </#if>
-  <#if (!width?has_content)>
-    <#local width = modelTheme.getLookupWidth()>
-  </#if>
-  <#if (!height?has_content)>
-    <#local height = modelTheme.getLookupHeight()>
+  <#if (!ajaxUrl?has_content) && ajaxEnabled?has_content && ajaxEnabled>
+    <#local ajaxUrl = requestAttributes._REQUEST_HANDLER_.makeLink(request, 
response, fieldFormName)/>
+    <#local ajaxUrl = id + "," + ajaxUrl + ",ajaxLookup=Y" />
   </#if>
-  <#if ajaxEnabled?has_content && ajaxEnabled>
-    <script type="text/javascript">
-      jQuery(document).ready(function(){
-        if (!jQuery('form[name="${formName}"]').length) {
-          alert("Developer: for lookups to work you must provide a form name!")
-        }
-      });
-    </script>
+  <#if ajaxEnabled?has_content && ajaxEnabled && (presentation?has_content && 
"window" == presentation)>
+    <#local ajaxUrl = ajaxUrl + "&amp;_LAST_VIEW_NAME_=" + lastViewName />
   </#if>
   <span class="field-lookup">
     <#if size?has_content && size=="0">
-      <input type="hidden" <#if name?has_content> name="${name}"/></#if><#if 
tabindex?has_content> tabindex="${tabindex}"</#if><#rt/>
+      <input type="hidden" <#if name?has_content> name="${name}"</#if><#if 
tabindex?has_content> tabindex="${tabindex}"</#if><#rt/>
     <#else>
       <input type="text" <@renderClass className alert /><#if 
name?has_content> name="${name}"</#if><#if value?has_content> 
value="${value}"</#if><#if tabindex?has_content> 
tabindex="${tabindex}"</#if><#rt/>
         <#if size?has_content> size="${size}"</#if><#if maxlength?has_content> 
maxlength="${maxlength}"</#if><#if id?has_content> id="${id}"</#if><#rt/>
         <#if readonly?has_content && readonly> 
readonly="readonly"</#if><#rt/><#if event?has_content && action?has_content> 
${event}="${action}"</#if><#rt/>
-        <#if autocomplete?has_content> autocomplete="off"</#if>/><#rt/></#if>
+        <#if autocomplete?has_content> autocomplete="off"</#if><#rt/>
+    </#if>
+      data-lookup-ajax-enabled="<#if 
ajaxEnabled?has_content>${ajaxEnabled?string}<#else>false</#if>" <#rt/>
+      data-lookup-presentation="${presentation!}" <#rt>
     <#if presentation?has_content && descriptionFieldName?has_content && 
"window" == presentation>
-      <a 
href="javascript:call_fieldlookup3(document.${formName?html}.${name?html},document.${formName?html}.${descriptionFieldName},'${fieldFormName}',
 '${presentation}'<#rt/>
+      data-lookup-field-formname="${fieldFormName}" 
data-lookup-form-name="${formName?html}" <#if 
descriptionFieldName?has_content>data-lookup-description-field="${descriptionFieldName}"</#if>
 <#rt>
       <#if targetParameterIter?has_content>
-        <#list targetParameterIter as item>
-          ,document.${formName}.${item}.value<#rt>
-        </#list>
+        <#assign args = "${targetParameterIter?join(', ')}">
       </#if>
-      );"></a><#rt>
+      data-lookup-args="${args!}" <#rt>
     <#elseif presentation?has_content && "window" == presentation>
-      <a 
href="javascript:call_fieldlookup2(document.${formName?html}.${name?html},'${fieldFormName}',
 '${presentation}'<#rt/>
+      data-lookup-field-formname="${fieldFormName}" <#rt>
       <#if targetParameterIter?has_content>
-        <#list targetParameterIter as item>
-          ,document.${formName}.${item}.value<#rt>
-        </#list>
+        <#assign args = "${targetParameterIter?join(', ')}">
       </#if>
-      );"></a><#rt>
+      data-lookup-args="${args!}" <#rt>
     <#else>
       <#if ajaxEnabled?has_content && ajaxEnabled>
         <#assign defaultMinLength = 
modelTheme.getAutocompleterDefaultMinLength()>
         <#assign defaultDelay = modelTheme.getAutocompleterDefaultDelay()>
-        <#local ajaxUrl = ajaxUrl + "&amp;_LAST_VIEW_NAME_=" + lastViewName />
         <#if !ajaxUrl?contains("searchValueFieldName=")>
           <#if descriptionFieldName?has_content && "true" == showDescription>
             <#local ajaxUrl = ajaxUrl + "&amp;searchValueFieldName=" + 
descriptionFieldName />
@@ -683,63 +664,28 @@ Parameter: delegatorName, String, option
           </#if>
         </#if>
       </#if>
-      <script type="text/javascript">
-        jQuery(document).ready(function(){
-          var options = {
-            requestUrl : "${fieldFormName}",
-            inputFieldId : "${id}",
-            dialogTarget : document.${formName?html}.${name?html},
-            dialogOptionalTarget : <#if 
descriptionFieldName?has_content>document.${formName?html}.${descriptionFieldName}<#else>null</#if>,
-            formName : "${formName?html}",
-            width : "${width}",
-            height : "${height}",
-            position : "${position}",
-            modal : "${fadeBackground}",
-            ajaxUrl : <#if ajaxEnabled?has_content && 
ajaxEnabled>"${ajaxUrl}"<#else>""</#if>,
-            showDescription : <#if ajaxEnabled?has_content && 
ajaxEnabled>"${showDescription}"<#else>false</#if>,
-            presentation : "${presentation!}",
-            defaultMinLength : "${defaultMinLength!2}",
-            defaultDelay : "${defaultDelay!300}",
-            args :
-              <#rt/>
-                <#if targetParameterIter?has_content>
-                  <#assign isFirst = true>
-                  <#lt/>[<#rt/>
-                  <#list targetParameterIter as item>
-                    <#if isFirst>
-                      <#lt/>document.${formName}.${item}<#rt/>
-                      <#assign isFirst = false>
-                    <#else>
-                      <#lt/> ,document.${formName}.${item}<#rt/>
-                    </#if>
-                  </#list>
-                  <#lt/>]<#rt/>
-                <#else>[]
-                </#if>
-                <#lt/>
-          };
-          new Lookup(options).init();
-        });
-      </script>
+      data-lookup-request-url="${fieldFormName}" 
data-lookup-form-name="${formName?html}" <#rt>
+      data-lookup-optional-target="<#if 
descriptionFieldName?has_content>${descriptionFieldName}</#if>" <#rt>
+      data-lookup-width="${width}" data-lookup-height="${height}" 
data-lookup-position="${position}" <#rt>
+      data-lookup-modal="${fadeBackground}" <#rt>
+      data-lookup-show-description=<#if ajaxEnabled?has_content && 
ajaxEnabled>"${showDescription}"<#else>"false"</#if> <#rt>
+      data-lookup-default-minlength="${defaultMinLength!2}" <#rt>
+      data-lookup-default-delay="${defaultDelay!300}" <#rt>
+      <#if targetParameterIter?has_content>
+        <#assign args = "${targetParameterIter?join(', ')}">
+      </#if>
+      data-lookup-args="${args!}"
     </#if>
+    data-lookup-ajax-url="${ajaxUrl}" <#rt>
+    /><#rt/>
     <#if readonly?has_content && readonly>
       <a id="${id}_clear" 
         style="background:none;margin-left:5px;margin-right:15px;" 
-        class="clearField" 
-        href="javascript:void(0);" 
-        onclick="javascript:document.${formName}.${name}.value='';
-          jQuery('#' + 
jQuery('#${id}_clear').next().attr('id').replace('_button','') + 
'_${id}_lookupDescription').html('');
-          <#if 
descriptionFieldName?has_content>document.${formName}.${descriptionFieldName}.value='';</#if>">
+        class="clearField">
           <#if 
clearText?has_content>${clearText}<#else>${uiLabelMap.CommonClear}</#if>
       </a>
     </#if>
   </span>
-  <#if ajaxEnabled?has_content && ajaxEnabled && (presentation?has_content && 
"window" == presentation)>
-    <#if ajaxUrl?index_of("_LAST_VIEW_NAME_") < 0>
-      <#local ajaxUrl = ajaxUrl + "&amp;_LAST_VIEW_NAME_=" + lastViewName />
-    </#if>
-    <script language="JavaScript" 
type="text/javascript">ajaxAutoCompleter('${ajaxUrl}', ${showDescription}, 
${defaultMinLength!2}, ${defaultDelay!300});</script><#t/>
-  </#if>
 </#macro>
 
 <#macro renderNextPrev paginateStyle paginateFirstStyle viewIndex highIndex 
listSize viewSize ajaxEnabled javaScriptEnabled ajaxFirstUrl firstUrl 
paginateFirstLabel paginatePreviousStyle ajaxPreviousUrl previousUrl 
paginatePreviousLabel pageLabel ajaxSelectUrl selectUrl ajaxSelectSizeUrl 
selectSizeUrl commonDisplaying paginateNextStyle ajaxNextUrl nextUrl 
paginateNextLabel paginateLastStyle ajaxLastUrl lastUrl paginateLastLabel 
paginateViewSizeLabel>

Modified: 
ofbiz/ofbiz-framework/trunk/themes/common-theme/webapp/common/js/util/OfbizUtil.js
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/themes/common-theme/webapp/common/js/util/OfbizUtil.js?rev=1825205&r1=1825204&r2=1825205&view=diff
==============================================================================
--- 
ofbiz/ofbiz-framework/trunk/themes/common-theme/webapp/common/js/util/OfbizUtil.js
 (original)
+++ 
ofbiz/ofbiz-framework/trunk/themes/common-theme/webapp/common/js/util/OfbizUtil.js
 Sat Feb 24 10:22:18 2018
@@ -117,8 +117,102 @@ function bindObservers(bind_element) {
         if (!confirm(confirmMessage)) {
             e.preventDefault();
         }
-    })
+    });
+    jQuery(bind_element).find("[data-lookup-presentation]").each(function(){
+        var element = jQuery(this);
+        var form = element.form();
+        var formName = form.attr("name");
+        if (!formName) {
+            console.log("Developer: For lookups to work you must provide a 
form name!");
+            return;
+        }
+        var presentation = element.data("lookup-presentation");
+        var ajaxEnabled = element.data("lookup-ajax-enabled");
+        var ajaxUrl = element.data("lookup-ajax-url");
+        var showDescription = element.data("lookup-show-description");
+
+        var defaultMinLength = element.data("lookup-default-minlength");
+        var defaultDelay = element.data("lookup-default-delay");
+        var descriptionFieldName = element.data("lookup-description-field");
+
+        if (presentation && presentation === "window" && descriptionFieldName) 
{
+            var descriptionField = form.find("input[name=" + 
descriptionFieldName+"]").get(0);
+            var fieldFormname = element.data("lookup-field-formname");
+            var lookupArgs = element.data("lookup-args");
+            var args = [];
+            if (lookupArgs){
+                jQuery.each(lookupArgs.split(', '), function (index, value) {
+                    var argValue = form.find("input[name=" + value + 
"]").get(0).value;
+                    args.push(argValue);
+                });
+            }
+
+            var argList = [this, descriptionField, fieldFormname, 
presentation];
+            argList = argList.concat(args);
+            var $a = jQuery("<a/>").one("click", function () {
+                call_fieldlookup3.apply(null, argList);
+            });
+            element.parent().append($a);
+
+        } else if (presentation && presentation === "window"){
+            var fieldFormname = element.data("lookup-field-formname");
+            var lookupArgs = element.data("lookup-args");
+            var args = [];
+            if (lookupArgs){
+                jQuery.each(lookupArgs.split(', '), function (index, value) {
+                    var argValue = form.find("input[name=" + value + 
"]").get(0).value;
+                    args.push(argValue);
+                });
+            }
 
+            var argList = [this, fieldFormname, presentation];
+            argList = argList.concat(args);
+            var $a = jQuery("<a/>").one("click", function () {
+                call_fieldlookup2.apply(null, argList);
+            });
+            element.parent(".field-lookup").append($a);
+        } else {
+            var lookupOptionalTarget = element.data("lookup-optional-target");
+            var dialogOptionalTarget = undefined;
+            if (lookupOptionalTarget)
+                dialogOptionalTarget = form.find("input[name=" + 
element.data("lookup-optional-target")+"]").get(0);
+            var lookupArgs = element.data("lookup-args");
+            var args = [];
+            if (lookupArgs){
+                jQuery.each(lookupArgs.split(', '), function (index, value) {
+                    var argElement = form.find("input[name=" + value + 
"]").get(0);
+                    args.push(argElement);
+                });
+            }
+
+            var options = {
+                requestUrl : element.data("lookup-request-url"),
+                inputFieldId : this.id,
+                dialogTarget : this,
+                dialogOptionalTarget : dialogOptionalTarget,
+                formName : formName,
+                width : element.data("lookup-width"),
+                height : element.data("lookup-height"),
+                position : element.data("lookup-position"),
+                modal : element.data("lookup-modal"),
+                ajaxUrl : ajaxUrl,
+                showDescription : showDescription,
+                presentation : presentation,
+                defaultMinLength : defaultMinLength,
+                defaultDelay : defaultDelay,
+                args : args
+            };
+            new Lookup(options).init();
+        }
+        element.siblings(".clearField").on("click", function (){
+            element.val("");
+            jQuery('#' + element.attr('id') + '_lookupDescription').html('');
+        });
+
+        if (ajaxEnabled && presentation && presentation == "window"){
+            ajaxAutoCompleter(ajaxUrl, showDescription, defaultMinLength, 
defaultDelay);
+        }
+    });
 }
 
 /* SelectAll: This utility can be used when we need to use parent and child 
box combination over any page. Here is the list of tasks it will do:

Modified: 
ofbiz/ofbiz-framework/trunk/themes/common-theme/webapp/common/js/util/fieldlookup.js
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/themes/common-theme/webapp/common/js/util/fieldlookup.js?rev=1825205&r1=1825204&r2=1825205&view=diff
==============================================================================
--- 
ofbiz/ofbiz-framework/trunk/themes/common-theme/webapp/common/js/util/fieldlookup.js
 (original)
+++ 
ofbiz/ofbiz-framework/trunk/themes/common-theme/webapp/common/js/util/fieldlookup.js
 Sat Feb 24 10:22:18 2018
@@ -192,6 +192,8 @@ var Lookup = function(options) {
         defaultDelay : options.defaultDelay || "",
         args : options.args || ""
     }
+    if (options.showDescription)
+        options.showDescription = options.showDescription.toString();
 
     function _init() {
         _lookupId = GLOBAL_LOOKUP_REF.createNextKey();
@@ -324,6 +326,7 @@ var Lookup = function(options) {
             success : function(data) {
                 _lookupContainer.html(data);
                 new ButtonModifier(_lookupId).modifyLookupLinks();
+                bindObservers("#" + _lookupId);
             },
 
             error : function(xhr, reason, exception) {

Modified: ofbiz/ofbiz-framework/trunk/themes/flatgrey/webapp/flatgrey/style.css
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/themes/flatgrey/webapp/flatgrey/style.css?rev=1825205&r1=1825204&r2=1825205&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/themes/flatgrey/webapp/flatgrey/style.css 
(original)
+++ ofbiz/ofbiz-framework/trunk/themes/flatgrey/webapp/flatgrey/style.css Sat 
Feb 24 10:22:18 2018
@@ -1243,6 +1243,7 @@ form .basic-table,
     margin-top: 0.3em;
     width: 16px; /* Setting must be in px */
     height: 16px; /* Setting must be in px */
+    cursor: pointer;
 }
 
 /* --------------------------- */

Modified: 
ofbiz/ofbiz-framework/trunk/themes/rainbowstone/webapp/rainbowstone/style.css
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/themes/rainbowstone/webapp/rainbowstone/style.css?rev=1825205&r1=1825204&r2=1825205&view=diff
==============================================================================
--- 
ofbiz/ofbiz-framework/trunk/themes/rainbowstone/webapp/rainbowstone/style.css 
(original)
+++ 
ofbiz/ofbiz-framework/trunk/themes/rainbowstone/webapp/rainbowstone/style.css 
Sat Feb 24 10:22:18 2018
@@ -891,6 +891,7 @@ text-decoration: underline;
     margin-top: 0.3em;
     width: 16px; /* Setting must be in px */
     height: 16px; /* Setting must be in px */
+    cursor: pointer;
 }
 
 /* --------------------------- */

Modified: 
ofbiz/ofbiz-framework/trunk/themes/tomahawk/webapp/tomahawk/css/style.css
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/themes/tomahawk/webapp/tomahawk/css/style.css?rev=1825205&r1=1825204&r2=1825205&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/themes/tomahawk/webapp/tomahawk/css/style.css 
(original)
+++ ofbiz/ofbiz-framework/trunk/themes/tomahawk/webapp/tomahawk/css/style.css 
Sat Feb 24 10:22:18 2018
@@ -2188,6 +2188,7 @@ render borders around empty <td> element
     margin-top: 3px;
     width: 35px;
     height: 22px;
+    cursor: pointer;
 }
 
 .CalLookupImage {


Reply via email to