Author: nmalin Date: Tue Apr 16 19:31:01 2019 New Revision: 1857660 URL: http://svn.apache.org/viewvc?rev=1857660&view=rev Log: Fixed: Backport, Duplicate a ShoppingCartItem didn't propage OrderItemAttributes (OFBIZ-10929)
When you clone a ShoppingCartItem by constructor : ShoppingCartItem sci = new ShoppingCartItem(ShoppingCartItem item) The ShoppingCartItem.orderItemAttributes wasn't propage from origin. Modified: ofbiz/branches/release16.11/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java Modified: ofbiz/branches/release16.11/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java URL: http://svn.apache.org/viewvc/ofbiz/branches/release16.11/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java?rev=1857660&r1=1857659&r2=1857660&view=diff ============================================================================== --- ofbiz/branches/release16.11/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java (original) +++ ofbiz/branches/release16.11/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java Tue Apr 16 19:31:01 2019 @@ -656,7 +656,7 @@ public class ShoppingCartItem implements this.associatedOrderItemSeqId = item.getAssociatedOrderItemSeqId(); this.orderItemAssocTypeId = item.getOrderItemAssocTypeId(); this.setStatusId(item.getStatusId()); - if (UtilValidate.isEmpty(item.getOrderItemAttributes())) { + if (UtilValidate.isNotEmpty(item.getOrderItemAttributes())) { this.orderItemAttributes = new HashMap<String, String>(); this.orderItemAttributes.putAll(item.getOrderItemAttributes()); }