This is an automated email from the ASF dual-hosted git repository.
surajk pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push:
new a1647a7 Improved: Marked addRequirementTask as deprecated and make it
entity-auto service as it was simply creating record of
WorkRequirementFulfillment. (#100)
a1647a7 is described below
commit a1647a7f63dd2bc91e28d2d2182deed7bbbc3d76
Author: Suraj Khurana <[email protected]>
AuthorDate: Sat May 2 17:26:24 2020 +0530
Improved: Marked addRequirementTask as deprecated and make it entity-auto
service as it was simply creating record of WorkRequirementFulfillment. (#100)
Improved: Marked addRequirementTask as deprecated and make it entity-auto
service as it was simply creating record of WorkRequirementFulfillment.
(OFBIZ-11634)
We have already service createWorkRequirementFulfillment available to do
this job so makring it as deprecated.
Thanks Jacques for review.
---
applications/order/minilang/requirement/RequirementServices.xml | 6 ------
applications/order/servicedef/services_requirement.xml | 6 ++++--
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/applications/order/minilang/requirement/RequirementServices.xml
b/applications/order/minilang/requirement/RequirementServices.xml
index 1eb3845..0720f80 100644
--- a/applications/order/minilang/requirement/RequirementServices.xml
+++ b/applications/order/minilang/requirement/RequirementServices.xml
@@ -35,12 +35,6 @@ under the License.
<create-value value-field="newEntity"/>
</simple-method>
- <simple-method method-name="addTaskToRequirement" short-description="Add a
task to a requirement">
- <make-value entity-name="WorkRequirementFulfillment"
value-field="newEntity"/>
- <set-pk-fields map="parameters" value-field="newEntity"/>
- <create-value value-field="newEntity"/>
- </simple-method>
-
<simple-method method-name="autoAssignRequirementToSupplier"
short-description="If the requirement is a product requirement (purchasing) try
to assign it to the primary supplier">
<entity-one entity-name="Requirement" value-field="requirement"
auto-field-map="true"/>
<check-errors/>
diff --git a/applications/order/servicedef/services_requirement.xml
b/applications/order/servicedef/services_requirement.xml
index c15d91d..642941a 100644
--- a/applications/order/servicedef/services_requirement.xml
+++ b/applications/order/servicedef/services_requirement.xml
@@ -85,9 +85,11 @@ under the License.
<attribute name="custRequestItemSeqId" type="String" mode="IN"
optional="false"/>
</service>
- <service name="addRequirementTask" engine="simple"
-
location="component://order/minilang/requirement/RequirementServices.xml"
invoke="addTaskToRequirement">
+ <service name="addRequirementTask" engine="entity-auto" invoke="create"
default-entity-name="WorkRequirementFulfillment">
<description>Associate an existing task w/ a requirement</description>
+ <deprecated use-instead="createWorkRequirementFulfillment"
since="Upcoming Branch">
+ Use createWorkRequirementFulfillment to create a workeffort
requirement fulfillment, that is an entity-auto service
+ </deprecated>
<attribute name="requirementId" type="String" mode="IN"
optional="false"/>
<attribute name="workEffortId" type="String" mode="IN"
optional="false"/>
<attribute name="workReqFulfTypeId" type="String" mode="IN"
optional="true"/>
