This is an automated email from the ASF dual-hosted git repository.
surajk pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git
The following commit(s) were added to refs/heads/trunk by this push:
new 9c6838e Improved: Refactor simple methods names as per naming
convention best practices. (#20)
9c6838e is described below
commit 9c6838ef0b4f5e2e21b9e3161cd5a53de1df1657
Author: Suraj Khurana <[email protected]>
AuthorDate: Sat May 23 10:34:37 2020 +0530
Improved: Refactor simple methods names as per naming convention best
practices. (#20)
(OFBIZ-11700)
---
projectmgr/minilang/ProjectServices.xml | 4 ++--
projectmgr/minilang/ProjectSimpleEvents.xml | 2 +-
projectmgr/webapp/projectmgr/WEB-INF/controller.xml | 2 +-
scrum/minilang/ScrumEvents.xml | 6 +++---
scrum/webapp/scrum/WEB-INF/controller.xml | 6 +++---
5 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/projectmgr/minilang/ProjectServices.xml
b/projectmgr/minilang/ProjectServices.xml
index 960f1fd..b16d4f1 100644
--- a/projectmgr/minilang/ProjectServices.xml
+++ b/projectmgr/minilang/ProjectServices.xml
@@ -1403,7 +1403,7 @@
<check-errors/>
</if-empty>
- <call-simple-method method-name="InvoiceStatusInProgress"
xml-resource="component://accounting/minilang/invoice/InvoiceServices.xml"/>
+ <call-simple-method method-name="checkInvoiceStatusInProgress"
xml-resource="component://accounting/minilang/invoice/InvoiceServices.xml"/>
<entity-and entity-name="TimeEntry" list="entries">
<field-map field-name="invoiceId"
from-field="parameters.invoiceId"/>
@@ -1478,7 +1478,7 @@
<check-errors/>
</if-empty>
- <call-simple-method method-name="InvoiceStatusInProgress"
xml-resource="component://accounting/minilang/invoice/InvoiceServices.xml"/>
+ <call-simple-method method-name="checkInvoiceStatusInProgress"
xml-resource="component://accounting/minilang/invoice/InvoiceServices.xml"/>
<entity-condition entity-name="ProjectPhaseTaskAndTimeEntryTimeSheet"
list="tasks">
<condition-list combine="and">
diff --git a/projectmgr/minilang/ProjectSimpleEvents.xml
b/projectmgr/minilang/ProjectSimpleEvents.xml
index eadcfe6..55ddb9d 100644
--- a/projectmgr/minilang/ProjectSimpleEvents.xml
+++ b/projectmgr/minilang/ProjectSimpleEvents.xml
@@ -19,7 +19,7 @@
-->
<simple-methods xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xmlns="http://ofbiz.apache.org/Simple-Method";
xsi:schemaLocation="http://ofbiz.apache.org/Simple-Method
http://ofbiz.apache.org/dtds/simple-methods.xsd";>
- <simple-method method-name="CreateCustRequestAndAssignTaskToPerson"
short-description="">
+ <simple-method method-name="createCustRequestAndAssignTaskToPerson"
short-description="">
<set field="parameters.statusId" value="CRQ_ACCEPTED"/><!-- entered by
employee, should only enter accepted customer requests -->
<if-not-empty field="parameters.communicationEventId">
<set-service-fields service-name="createCustRequestFromCommEvent"
map="parameters" to-map="eventCreateCust"/>
diff --git a/projectmgr/webapp/projectmgr/WEB-INF/controller.xml
b/projectmgr/webapp/projectmgr/WEB-INF/controller.xml
index 6534ea8..b977df7 100644
--- a/projectmgr/webapp/projectmgr/WEB-INF/controller.xml
+++ b/projectmgr/webapp/projectmgr/WEB-INF/controller.xml
@@ -534,7 +534,7 @@
</request-map>
<request-map uri="createrequest">
<security https="true" auth="true"/>
- <event type="simple" invoke="CreateCustRequestAndAssignTaskToPerson"
path="component://projectmgr/minilang/ProjectSimpleEvents.xml"/>
+ <event type="simple" invoke="createCustRequestAndAssignTaskToPerson"
path="component://projectmgr/minilang/ProjectSimpleEvents.xml"/>
<response name="success" type="view-last-noparam" value="RequestList"/>
<response name="error" type="view" value="EditRequest"/>
</request-map>
diff --git a/scrum/minilang/ScrumEvents.xml b/scrum/minilang/ScrumEvents.xml
index eb1cedc..9202ea3 100644
--- a/scrum/minilang/ScrumEvents.xml
+++ b/scrum/minilang/ScrumEvents.xml
@@ -390,7 +390,7 @@
</if>
</simple-method>
- <simple-method method-name="DeleteSprint" short-description="Delete
Sprint">
+ <simple-method method-name="deleteSprint" short-description="Delete
Sprint">
<!-- Permission Check -->
<if>
<condition>
@@ -2188,7 +2188,7 @@
<remove-value value-field="workNoteMap"/>
<remove-related relation-name="NoteData" value-field="workNoteMap"/>
</simple-method>
- <simple-method method-name="DeleteTaskFromSprintOverview"
short-description="Delete Task From Sprint Overview Screen">
+ <simple-method method-name="deleteTaskFromSprintOverview"
short-description="Delete Task From Sprint Overview Screen">
<entity-one entity-name="CustRequestWorkEffort"
value-field="taskWorkEffort">
<field-map field-name="workEffortId"
from-field="parameters.workEffort"/>
<field-map field-name="custRequestId"
from-field="parameters.custRequestId"/>
@@ -3328,7 +3328,7 @@
</if-empty>
</simple-method>
- <simple-method method-name="CopyMemberLastSprint" short-description="">
+ <simple-method method-name="copyMemberLastSprint" short-description="">
<entity-and entity-name="WorkEffort" list="sprintList">
<field-map field-name="workEffortParentId"
from-field="parameters.projectId"/>
<field-map field-name="workEffortTypeId" value="SCRUM_SPRINT"/>
diff --git a/scrum/webapp/scrum/WEB-INF/controller.xml
b/scrum/webapp/scrum/WEB-INF/controller.xml
index 41aab3d..28c0df4 100644
--- a/scrum/webapp/scrum/WEB-INF/controller.xml
+++ b/scrum/webapp/scrum/WEB-INF/controller.xml
@@ -104,7 +104,7 @@ under the License.
</request-map>
<request-map uri="DeleteSprint">
<security auth="true" https="true"/>
- <event type="simple" invoke="DeleteSprint"
path="component://scrum/minilang/ScrumEvents.xml"/>
+ <event type="simple" invoke="deleteSprint"
path="component://scrum/minilang/ScrumEvents.xml"/>
<response name="success" type="view" value="SprintList"></response>
</request-map>
<request-map uri="EditSprint">
@@ -1086,7 +1086,7 @@ under the License.
</request-map>
<request-map uri="deleteBacklogItemContent">
<security auth="true" https="true"/>
- <event type="service" invoke="deleteCustRequestContent" />
+ <event type="service" invoke="expireCustRequestContent" />
<response name="success" type="request-redirect"
value="EditBacklogItemContent">
<redirect-parameter name="custRequestId"/>
<redirect-parameter name="productId"/>
@@ -1153,7 +1153,7 @@ under the License.
</request-map>
<request-map uri="CopyMemberLastSprint">
<security https="true" auth="true"/>
- <event type="simple" path="component://scrum/minilang/ScrumEvents.xml"
invoke="CopyMemberLastSprint"/>
+ <event type="simple" path="component://scrum/minilang/ScrumEvents.xml"
invoke="copyMemberLastSprint"/>
<response name="success" type="request-redirect" value="ViewSprint">
<redirect-parameter name="projectId" from="projectId"/>
<redirect-parameter name="sprintId" from="sprintId" />
