[ofbiz-framework] branch trunk updated: Fixed: getEntityRefData service has a weird issue (OFBIZ-11401)

[jleroux]

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 743c790  Fixed: getEntityRefData service has a weird issue 
(OFBIZ-11401)
743c790 is described below

commit 743c790a36fddfa1bc6fab19ba291a2b84911cb6
Author: Jacques Le Roux <jacques.le.r...@les7arts.com>
AuthorDate: Thu Jun 18 17:34:18 2020 +0200

    Fixed: getEntityRefData service has a weird issue (OFBIZ-11401)
    
    It's reproductible on trunk demo though only visible in log, UI shows no 
issue
    
    R17 and R18 are also affected, R16 is OK.
    
    Ankush: This stacktrace should be coming for all entities where
    default-resource-name is defined on entity definition but no property exist 
in
    defined resource for key EntityDescription.entityname and 
FieldDescription.field.
    
    As we want to have these entity labels as much as possible, we can simply 
print
    warning about the missing entity descriptions and field descriptions for
    readability purpose instead of printing huge exceptions stacktrace.
    
    Thanks: Ankush Upadhyay and Pierre Smits for the help
---
 .../src/main/java/org/apache/ofbiz/webtools/WebToolsServices.java  | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git 
a/framework/webtools/src/main/java/org/apache/ofbiz/webtools/WebToolsServices.java
 
b/framework/webtools/src/main/java/org/apache/ofbiz/webtools/WebToolsServices.java
index db27772..a3d10f5 100644
--- 
a/framework/webtools/src/main/java/org/apache/ofbiz/webtools/WebToolsServices.java
+++ 
b/framework/webtools/src/main/java/org/apache/ofbiz/webtools/WebToolsServices.java
@@ -664,7 +664,7 @@ public class WebToolsServices {
                             try {
                                 entityDescription = 
bundle.getString("EntityDescription." + entity.getEntityName());
                             } catch (Exception exception) {
-                                Debug.logError(exception, MODULE);
+                                Debug.logWarning("EntityDescription for entity 
" + entity.getEntityName() + " is missing", MODULE);
                             }
                         }
                         if (UtilValidate.isEmpty(entityDescription)) {
@@ -685,7 +685,8 @@ public class WebToolsServices {
                                 try {
                                     fieldDescription = 
bundle.getString("FieldDescription." + entity.getEntityName() + "." + 
field.getName());
                                 } catch (Exception exception) {
-                                    Debug.logError(exception, MODULE);
+                                    Debug.logWarning("FieldDescription for 
entity.field " + entity.getEntityName() + "."
+                                            + field.getName() + " is missing", 
MODULE);
                                 }
                             }
                             if (UtilValidate.isEmpty(fieldDescription)) {
@@ -695,7 +696,7 @@ public class WebToolsServices {
                                 try {
                                 fieldDescription = 
bundle.getString("FieldDescription." + field.getName());
                                 } catch (Exception exception) {
-                                    Debug.logError(exception, MODULE);
+                                    Debug.logWarning("FieldDescription for 
field " + field.getName() + " is missing", MODULE);
                                 }
                             }
                             if (UtilValidate.isEmpty(fieldDescription)) {