[ofbiz-framework] branch trunk updated: Improved: Create 'New Communication' button should be removed from create new communication screen. (OFBIZ-12027)

[jleroux]

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 66decd8  Improved: Create 'New Communication' button should be removed 
from create new communication screen. (OFBIZ-12027)
66decd8 is described below

commit 66decd89f790494adca16c66183585156f1bfa22
Author: Jacques Le Roux <jacques.le.r...@les7arts.com>
AuthorDate: Tue Dec 29 11:26:19 2020 +0100

    Improved: Create 'New Communication' button should be removed from create 
new communication screen. (OFBIZ-12027)
    
    Steps to replicate the issue :
    Go to Party application.
    On the 'find communications' screen clicks on the 'New communications' 
button.
    The system will navigate you to create/edit communications screen.
    On create/edit communications screen you will see the 'New communications' 
button.
    
    Providing the 'New communications' button on the 'create new communication
    screen' does not make any sense over so it should be removed from here.
    
    Thanks: Shubham Choudhary
---
 applications/party/widget/partymgr/CommunicationEventScreens.xml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/applications/party/widget/partymgr/CommunicationEventScreens.xml 
b/applications/party/widget/partymgr/CommunicationEventScreens.xml
index 00acf3b..857b459 100644
--- a/applications/party/widget/partymgr/CommunicationEventScreens.xml
+++ b/applications/party/widget/partymgr/CommunicationEventScreens.xml
@@ -536,6 +536,7 @@ under the License.
             <actions>
                 <set field="titleProperty" value="PageTitleEditCommunication"/>
                 <set field="tabButtonItem" value="CommunicationEvent"/>
+                <set field="headerItem" value="comm"/>
                 <set field="my" from-field="parameters.my" default-value=""/>
                 <entity-one entity-name="CommunicationEvent" 
value-field="communicationEvent"/>
                 <set field="partyIdFrom" 
from-field="communicationEvent.partyIdFrom" 
default-value="${userLogin.partyId}"/>
@@ -543,7 +544,7 @@ under the License.
                 <set field="contactMechIdTo" 
from-field="parameters.contactMechIdTo" 
default-value="${communicationEvent.contactMechIdTo}"/>
             </actions>
             <widgets>
-                <decorator-screen 
name="Common${my}CommunicationEventDecorator" 
location="${parameters.communicationEventDecoratorLocation}">
+                <decorator-screen 
location="${parameters.mainDecoratorLocation}" name="main-decorator">
                     <decorator-section name="body">
                         <include-screen name="editCommEvent"/>
                     </decorator-section>