[ofbiz-framework] branch trunk updated: Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)

[jleroux]

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 5b4de85  Improved:  Fix some bugs Spotbugs reports (OFBIZ-12386)
5b4de85 is described below

commit 5b4de857dc1c89578e26e491a4f016a4436d5c09
Author: Jacques Le Roux <jacques.le.r...@les7arts.com>
AuthorDate: Fri Nov 19 17:57:17 2021 +0100

    Improved:  Fix some bugs Spotbugs reports (OFBIZ-12386)
    
    There is no usage of generateRandomFinNumber OOTB
    I though put: // FIXME number is null!
    because it passes null to UtilValidate.getLuhnCheckDigit if isId is true
---
 .../main/java/org/apache/ofbiz/order/finaccount/FinAccountHelper.java    | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/applications/order/src/main/java/org/apache/ofbiz/order/finaccount/FinAccountHelper.java
 
b/applications/order/src/main/java/org/apache/ofbiz/order/finaccount/FinAccountHelper.java
index 4985e0c..3447c1f 100644
--- 
a/applications/order/src/main/java/org/apache/ofbiz/order/finaccount/FinAccountHelper.java
+++ 
b/applications/order/src/main/java/org/apache/ofbiz/order/finaccount/FinAccountHelper.java
@@ -297,6 +297,7 @@ public final class FinAccountHelper {
             }
 
             if (isId) {
+                // FIXME number is null!
                 int check = UtilValidate.getLuhnCheckDigit(number);
                 numberBuilder.append(check);
                 number = numberBuilder.toString();