This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 252e275  Improved: removal triggers from screen present as menu-items 
(OFBIZ-12406) (#358)
252e275 is described below

commit 252e2750ebf6048b775d18d94b68c16bd55e904c
Author: Pierre Smits <[email protected]>
AuthorDate: Sat Nov 27 11:27:20 2021 +0100

    Improved: removal triggers from screen present as menu-items (OFBIZ-12406) 
(#358)
    
    Currently, a user with only 'VIEW' permissions, as demonstrated in trunk 
demo with userId = auditor, accessing the InvoiceOverviews screen sees triggers 
(intended for users with 'CREATE' or 'UPDATE' permissions).
    Such triggers are already available via menu-items associated the screen.
    
    modified: InvoiceOverview screen in InvoiceScreens.xml
---
 applications/accounting/widget/InvoiceScreens.xml | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/applications/accounting/widget/InvoiceScreens.xml 
b/applications/accounting/widget/InvoiceScreens.xml
index fb4e7a7..78f5d1b 100644
--- a/applications/accounting/widget/InvoiceScreens.xml
+++ b/applications/accounting/widget/InvoiceScreens.xml
@@ -232,9 +232,6 @@ under the License.
                             </condition>
                             <widgets>
                                 <screenlet 
title="${uiLabelMap.AccountingInvoiceHeader}">
-                                    <link target="editInvoice" 
text="${uiLabelMap.CommonUpdate}" style="buttontext">
-                                        <parameter param-name="invoiceId"/>
-                                    </link>
                                     <include-form name="InvoiceHeader" 
location="component://accounting/widget/InvoiceForms.xml"/>
                                 </screenlet>
                                 <container style="lefthalf">
@@ -243,36 +240,20 @@ under the License.
                                     </screenlet>
                                     <screenlet 
title="${uiLabelMap.AccountingAppliedPayments} 
${appliedAmount?currency(${invoice.currencyUomId})} 
${uiLabelMap.AccountingOpenPayments} 
${notAppliedAmount?currency(${invoice.currencyUomId})}"
                                         
navigation-form-name="ListInvoiceApplications">
-                                        <link target="editInvoiceApplications" 
text="${uiLabelMap.CommonUpdate}" style="buttontext">
-                                            <parameter param-name="invoiceId"/>
-                                        </link>
                                         <include-form 
name="ListInvoiceApplications" 
location="component://accounting/widget/InvoiceForms.xml"/>
                                     </screenlet>
                                 </container>
                                 <container style="righthalf">
                                     <screenlet 
title="${uiLabelMap.AccountingInvoiceRoles}" 
navigation-form-name="InvoiceRoles">
-                                        <container>
-                                            <link target="invoiceRoles" 
text="${uiLabelMap.CommonUpdate}" style="buttontext">
-                                                <parameter 
param-name="invoiceId"/>
-                                            </link>
-                                        </container>
                                         <include-form name="InvoiceRoles" 
location="component://accounting/widget/InvoiceForms.xml"/>
                                     </screenlet>
                                     <screenlet 
title="${uiLabelMap.PartyTerms}">
-                                        <container>
-                                            <link target="invoiceTerms" 
text="${uiLabelMap.CommonUpdate}" style="buttontext">
-                                                <parameter 
param-name="invoiceId"/>
-                                            </link>
-                                        </container>
                                         <include-form name="ListInvoiceTerms" 
location="component://accounting/widget/InvoiceForms.xml"/>
                                         <include-form 
name="ListInvoicePaymentInfo" 
location="component://accounting/widget/InvoiceForms.xml"/>
                                     </screenlet>
                                 </container>
                                 <container style="clear"/>
                                 <screenlet 
title="${uiLabelMap.AccountingInvoiceItems}" 
navigation-form-name="InvoiceItems">
-                                    <link target="listInvoiceItems" 
text="${uiLabelMap.CommonUpdate}" style="buttontext">
-                                        <parameter param-name="invoiceId"/>
-                                    </link>
                                     <include-form name="InvoiceItems" 
location="component://accounting/widget/InvoiceForms.xml"/>
                                 </screenlet>
                                 <section>
@@ -281,9 +262,6 @@ under the License.
                                     </condition>
                                     <widgets>
                                         <screenlet 
title="${uiLabelMap.AccountingInvoiceTimeEntries}" 
navigation-form-name="ListTimeEntries">
-                                            <link 
target="editInvoiceTimeEntries" text="${uiLabelMap.CommonUpdate}" 
style="buttontext">
-                                                <parameter 
param-name="invoiceId"/>
-                                            </link>
                                             <include-form 
name="ListTimeEntries" 
location="component://accounting/widget/InvoiceForms.xml"/>
                                         </screenlet>
                                     </widgets>

Reply via email to