[ofbiz-framework] branch trunk updated: Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)

[jleroux]

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new d4306b9  Improved:  Fix some bugs Spotbugs reports (OFBIZ-12386)
d4306b9 is described below

commit d4306b9f59296c13d73683d1cee1647427a512fd
Author: Jacques Le Roux <jacques.le.r...@les7arts.com>
AuthorDate: Mon Dec 6 09:33:31 2021 +0100

    Improved:  Fix some bugs Spotbugs reports (OFBIZ-12386)
    
    ComparableRange is a super class of DateRange that is Serializable. So
    ComparableRange needs to be Serializable Too. Same with AbstractJob for 
PurgeJob
    and GenericServiceJob
---
 .../src/main/java/org/apache/ofbiz/base/lang/ComparableRange.java   | 6 ++++--
 .../src/main/java/org/apache/ofbiz/service/job/AbstractJob.java     | 3 ++-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git 
a/framework/base/src/main/java/org/apache/ofbiz/base/lang/ComparableRange.java 
b/framework/base/src/main/java/org/apache/ofbiz/base/lang/ComparableRange.java
index 4de918a..34fa0df 100644
--- 
a/framework/base/src/main/java/org/apache/ofbiz/base/lang/ComparableRange.java
+++ 
b/framework/base/src/main/java/org/apache/ofbiz/base/lang/ComparableRange.java
@@ -18,10 +18,12 @@
  
*******************************************************************************/
 package org.apache.ofbiz.base.lang;
 
+import java.io.Serializable;
+
 /** A range of values. */
+@SuppressWarnings("serial")
 @SourceMonitored
-public class ComparableRange<T extends Comparable<T>> implements Range<T>, 
Comparable<ComparableRange<T>> {
-
+public class ComparableRange<T extends Comparable<T>> implements Range<T>, 
Comparable<ComparableRange<T>>, Serializable {
     private final T start;
     private final T end;
     private final boolean isPoint;
diff --git 
a/framework/service/src/main/java/org/apache/ofbiz/service/job/AbstractJob.java 
b/framework/service/src/main/java/org/apache/ofbiz/service/job/AbstractJob.java
index 3f314c1..b5a9953 100644
--- 
a/framework/service/src/main/java/org/apache/ofbiz/service/job/AbstractJob.java
+++ 
b/framework/service/src/main/java/org/apache/ofbiz/service/job/AbstractJob.java
@@ -18,6 +18,7 @@
  
*******************************************************************************/
 package org.apache.ofbiz.service.job;
 
+import java.io.Serializable;
 import java.util.Date;
 
 import org.apache.ofbiz.base.util.Assert;
@@ -28,7 +29,7 @@ import org.apache.ofbiz.entity.transaction.TransactionUtil;
 /**
  * Abstract Job.
  */
-public abstract class AbstractJob implements Job {
+public abstract class AbstractJob implements Job, Serializable {
 
     private static final String MODULE = AbstractJob.class.getName();