This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push:
new 3a81cc5 Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
3a81cc5 is described below
commit 3a81cc5aa3a71ff18d6e1802f4f1004a4b6cc7eb
Author: Jacques Le Roux <[email protected]>
AuthorDate: Sun Dec 26 08:09:28 2021 +0100
Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
In JanrainHelper class the apiKey and baseUrl field are initialised by
UtilProperties.getPropertyValue() and then only read or possibly modified by
the sole constructor. Excludes them from SpotBugs findings
---
spotbugs/exclude.xml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/spotbugs/exclude.xml b/spotbugs/exclude.xml
index 7fe11bd..fd35992 100644
--- a/spotbugs/exclude.xml
+++ b/spotbugs/exclude.xml
@@ -143,5 +143,17 @@
<Field name="servletContext" />
<Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD " />
</Match>
+ <Match>
+ <!-- not a problem apiKey is initialised by
UtilProperties.getPropertyValue() and then only read or possibly modified by
the only constructor -->
+ <Class name="org.apache.ofbiz.ecommerce.janrain.JanrainHelper" />
+ <Field name="apiKey" />
+ <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD " />
+ </Match>
+ <Match>
+ <!-- not a problem baseUrl is initialised by
UtilProperties.getPropertyValue() and then only read or possibly modified by
the only constructor -->
+ <Class name="org.apache.ofbiz.ecommerce.janrain.JanrainHelper" />
+ <Field name="baseUrl" />
+ <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD " />
+ </Match>
<!-- ^ ^ not a problem, false positive -->
</FindBugsFilter>
