(ofbiz-framework) branch trunk updated: Return error when the userLogin service encounters an error during login. It is now more logical to handle unsuccessful logins appropriately and not proceed with 'requirePasswordChange' (OFBIZ-12873)

[deepak]

This is an automated email from the ASF dual-hosted git repository.

deepak pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new ee02a33509 Return error when the userLogin service encounters an error 
during login. It is now more logical to handle unsuccessful logins 
appropriately and not proceed with 'requirePasswordChange' (OFBIZ-12873)
ee02a33509 is described below

commit ee02a33509589856ab1ad08399e8dcee6b0edf58
Author: Deepak Dixit <dee...@apache.org>
AuthorDate: Fri Dec 15 19:44:02 2023 +0530

    Return error when the userLogin service encounters an error during login. 
It is now more logical to handle unsuccessful logins appropriately and not 
proceed with 'requirePasswordChange' (OFBIZ-12873)
---
 .../src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
 
b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
index acaea1582a..cd10879cf6 100644
--- 
a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
+++ 
b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
@@ -610,7 +610,7 @@ public final class LoginWorker {
             String errMsg = UtilProperties.getMessage(RESOURCE, 
"loginevents.following_error_occurred_during_login",
                     messageMap, UtilHttp.getLocale(request));
             request.setAttribute("_ERROR_MESSAGE_", errMsg);
-            return requirePasswordChange ? "requirePasswordChange" : "error";
+            return "error";
         }
     }