(ofbiz-framework) branch release22.01 updated: Return error when the userLogin service encounters an error during login. It is now more logical to handle unsuccessful logins appropriately and not proceed with 'requirePasswordChange' (OFBIZ-12873)

[deepak]

This is an automated email from the ASF dual-hosted git repository.

deepak pushed a commit to branch release22.01
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/release22.01 by this push:
     new 122b7e47e5 Return error when the userLogin service encounters an error 
during login. It is now more logical to handle unsuccessful logins 
appropriately and not proceed with 'requirePasswordChange' (OFBIZ-12873)
122b7e47e5 is described below

commit 122b7e47e5f22425411775346fe7cd2988c997cb
Author: Deepak Dixit <dee...@apache.org>
AuthorDate: Fri Dec 15 19:44:02 2023 +0530

    Return error when the userLogin service encounters an error during login. 
It is now more logical to handle unsuccessful logins appropriately and not 
proceed with 'requirePasswordChange' (OFBIZ-12873)
---
 .../src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
 
b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
index 9d6a687086..17b46d531e 100644
--- 
a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
+++ 
b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
@@ -610,7 +610,7 @@ public final class LoginWorker {
             String errMsg = UtilProperties.getMessage(RESOURCE, 
"loginevents.following_error_occurred_during_login",
                     messageMap, UtilHttp.getLocale(request));
             request.setAttribute("_ERROR_MESSAGE_", errMsg);
-            return requirePasswordChange ? "requirePasswordChange" : "error";
+            return "error";
         }
     }