(ofbiz-framework) branch trunk updated: Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors (OFBIZ-13061)

[jleroux]

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 822b031600 Fixed: Prevents to uselessly clutter the logs up with 
SetTimeZoneFromBrowser errors (OFBIZ-13061)
822b031600 is described below

commit 822b031600475d570f43b1d76b7ac5921acd0892
Author: Jacques Le Roux <jacques.le.r...@les7arts.com>
AuthorDate: Mon Apr 22 10:40:57 2024 +0200

    Fixed: Prevents to uselessly clutter the logs up with 
SetTimeZoneFromBrowser errors (OFBIZ-13061)
    
    Currently the demo logs, and I guess users production logs, are cluttered up
    with very common and unique SetTimeZoneFromBrowser error.
    We can easily prevent that by not returning an error from
    SetTimeZoneFromBrowser.groovy, and so the never ending
    <<Request SetTimeZoneFromBrowser caused an error with the following message:
    User authorization is required for this service: SetTimeZoneFromBrowser>>
    from RequestHandler.java
---
 .../main/groovy/org/apache/ofbiz/common/SetTimeZoneFromBrowser.groovy  | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git 
a/framework/common/src/main/groovy/org/apache/ofbiz/common/SetTimeZoneFromBrowser.groovy
 
b/framework/common/src/main/groovy/org/apache/ofbiz/common/SetTimeZoneFromBrowser.groovy
index 44d493bad5..232e61bada 100644
--- 
a/framework/common/src/main/groovy/org/apache/ofbiz/common/SetTimeZoneFromBrowser.groovy
+++ 
b/framework/common/src/main/groovy/org/apache/ofbiz/common/SetTimeZoneFromBrowser.groovy
@@ -28,7 +28,6 @@ Map setTimeZoneFromBrowser() {
             userLogin.store()
             return ServiceUtil.returnSuccess()
         }
-    } else {
-        return ServiceUtil.returnError()
     }
+    // Do nothing if no userLogin to prevents to uselessly clutter the logs up 
with very common SetTimeZoneFromBrowser errors
 }