(ofbiz-plugins) branch trunk updated: Replaced performFind with performFindList service - Updated code to use performFindList instead of performFind - performFindList directly returns item lists, removing the need to handle iterators

[deepak]

This is an automated email from the ASF dual-hosted git repository.

dixitdeepak pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git


The following commit(s) were added to refs/heads/trunk by this push:
     new a5261f6b1 Replaced performFind with performFindList service - Updated 
code to use performFindList instead of performFind - performFindList directly 
returns item lists, removing the need to handle iterators
a5261f6b1 is described below

commit a5261f6b1ca313d538d114f9c20fbcb4130bf1f0
Author: Deepak Dixit <deepak.di...@hotwax.co>
AuthorDate: Thu May 7 14:35:59 2026 +0530

    Replaced performFind with performFindList service
    - Updated code to use performFindList instead of performFind
    - performFindList directly returns item lists, removing the need to handle 
iterators
---
 .../apache/ofbiz/scrum/AddProductBacklogItem.groovy    | 16 ++--------------
 .../org/apache/ofbiz/scrum/ListScrumResource.groovy    | 16 ++--------------
 .../org/apache/ofbiz/scrum/ListTimeSheets.groovy       | 18 +++---------------
 3 files changed, 7 insertions(+), 43 deletions(-)

diff --git 
a/scrum/src/main/groovy/org/apache/ofbiz/scrum/AddProductBacklogItem.groovy 
b/scrum/src/main/groovy/org/apache/ofbiz/scrum/AddProductBacklogItem.groovy
index c37643888..572a9ebe1 100644
--- a/scrum/src/main/groovy/org/apache/ofbiz/scrum/AddProductBacklogItem.groovy
+++ b/scrum/src/main/groovy/org/apache/ofbiz/scrum/AddProductBacklogItem.groovy
@@ -30,23 +30,11 @@ List<GenericValue> custRequestAndItems = []
 if (parameters.statusId == 'Any') {
     parameters.statusId = ''
 }
-Map performFindResults = run service: 'performFind', with: [entityName: 
'CustRequestAndCustRequestItem',
+Map performFindResults = run service: 'performFindList', with: [entityName: 
'CustRequestAndCustRequestItem',
                                                                inputFields: 
[*: parameters,
                                                                              
custRequestTypeId: 'RF_PROD_BACKLOG'],
                                                                orderBy: 
'custSequenceNum']
-try {
-    custRequestAndItems = performFindResults.listIt.getCompleteList()
-} catch (GenericEntityException e) {
-    logError(e.toString())
-} finally {
-    if (performFindResults.listIt) {
-        try {
-            performFindResults.listIt.close()
-        } catch (GenericEntityException e) {
-            logError(e.toString())
-        }
-    }
-}
+custRequestAndItems = performFindResults.list
 
 // prepare cust request item list [cust request and item Map]
 int countSequence = 1
diff --git 
a/scrum/src/main/groovy/org/apache/ofbiz/scrum/ListScrumResource.groovy 
b/scrum/src/main/groovy/org/apache/ofbiz/scrum/ListScrumResource.groovy
index d9d7f1213..262add30a 100644
--- a/scrum/src/main/groovy/org/apache/ofbiz/scrum/ListScrumResource.groovy
+++ b/scrum/src/main/groovy/org/apache/ofbiz/scrum/ListScrumResource.groovy
@@ -29,20 +29,8 @@ performFindInMap = [entityName: 
'ScrumMemberUserLoginAndSecurityGroup',
 if (parameters.sortField) {
     performFindInMap.orderBy = 'lastName'
 }
-performFindResults = run service: 'performFind', with: performFindInMap
-try {
-    resultList = performFindResults.listIt.getCompleteList()
-} catch (GenericEntityException e) {
-    logError(e)
-} finally {
-    if (performFindResults.listIt != null) {
-        try {
-            performFindResults.listIt.close()
-        } catch (GenericEntityException e) {
-            logError(e)
-        }
-    }
-}
+performFindResults = run service: 'performFindList', with: performFindInMap
+resultList = performFindResults.list
 
 resultList.each { result ->
     if (result.enabled != 'N') {
diff --git a/scrum/src/main/groovy/org/apache/ofbiz/scrum/ListTimeSheets.groovy 
b/scrum/src/main/groovy/org/apache/ofbiz/scrum/ListTimeSheets.groovy
index 392b501ac..8ecb67856 100644
--- a/scrum/src/main/groovy/org/apache/ofbiz/scrum/ListTimeSheets.groovy
+++ b/scrum/src/main/groovy/org/apache/ofbiz/scrum/ListTimeSheets.groovy
@@ -30,24 +30,12 @@ inputFields = [:]
 
 parameters.noConditionFind = parameters.noConditionFind ?: 'N'
 inputFields.putAll(parameters)
-performFindResults = run service: 'performFind', with: [entityName: 
'Timesheet',
+performFindResults = run service: 'performFindList', with: [entityName: 
'Timesheet',
                                                         inputFields: 
inputFields,
                                                         orderBy: 'fromDate 
DESC']
 if (performFindResults.listSize > 0) {
-    try {
-        timesheetsDb = performFindResults.listIt.getCompleteList()
-    } catch (GenericEntityException e) {
-        logError(e, 'Failure in ' + module)
-    } finally {
-        if (performFindResults.listIt != null) {
-            try {
-                performFindResults.listIt.close()
-            } catch (GenericEntityException e) {
-                logError(e)
-            }
-        }
-    }
-
+    timesheetsDb = performFindResults.list
+}
     timesheetsDb.each { timesheetDb ->
         //get hours from EmplLeave
         leaveHours = 0.00