(ofbiz-framework) branch trunk updated: Use try-with-resources for GroovyClassLoader (OFBIZ-13399)

[deepak]

This is an automated email from the ASF dual-hosted git repository.

dixitdeepak pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 66b4ddda54 Use try-with-resources for GroovyClassLoader (OFBIZ-13399)
66b4ddda54 is described below

commit 66b4ddda54e6c138ca2f675f7f4f00e52a54b45f
Author: Deepak Dixit <dee...@apache.org>
AuthorDate: Fri May 22 10:01:55 2026 +0530

    Use try-with-resources for GroovyClassLoader (OFBIZ-13399)
    
    Ensure temporary GroovyClassLoader instances in GroovyUtil.parseClass
    are closed even when Groovy parsing fails. The shared static loader
    lifecycle remains unchanged.
---
 .../main/java/org/apache/ofbiz/base/util/GroovyUtil.java   | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git 
a/framework/base/src/main/java/org/apache/ofbiz/base/util/GroovyUtil.java 
b/framework/base/src/main/java/org/apache/ofbiz/base/util/GroovyUtil.java
index cf9f3c7d65..4db6df99e4 100644
--- a/framework/base/src/main/java/org/apache/ofbiz/base/util/GroovyUtil.java
+++ b/framework/base/src/main/java/org/apache/ofbiz/base/util/GroovyUtil.java
@@ -220,10 +220,9 @@ public final class GroovyUtil {
         if (GROOVY_CLASS_LOADER != null) {
             return GROOVY_CLASS_LOADER.parseClass(classText, location);
         } else {
-            GroovyClassLoader classLoader = new GroovyClassLoader();
-            Class<?> klass = classLoader.parseClass(classText, location);
-            classLoader.close();
-            return klass;
+            try (GroovyClassLoader classLoader = new GroovyClassLoader()) {
+                return classLoader.parseClass(classText, location);
+            }
         }
     }
 
@@ -237,10 +236,9 @@ public final class GroovyUtil {
         if (GROOVY_CLASS_LOADER != null) {
             return GROOVY_CLASS_LOADER.parseClass(text);
         } else {
-            GroovyClassLoader groovyClassLoader = new GroovyClassLoader();
-            Class<?> classLoader = groovyClassLoader.parseClass(text);
-            groovyClassLoader.close();
-            return classLoader;
+            try (GroovyClassLoader groovyClassLoader = new 
GroovyClassLoader()) {
+                return groovyClassLoader.parseClass(text);
+            }
         }
     }