(ofbiz-framework) branch trunk updated: Improvement: Prevent potential resource leak in CoreEvents.java (OFBIZ-13421) (#1241)

[deepak]

This is an automated email from the ASF dual-hosted git repository.

dixitdeepak pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new b06ac9e876 Improvement: Prevent potential resource leak in 
CoreEvents.java (OFBIZ-13421) (#1241)
b06ac9e876 is described below

commit b06ac9e876afc13e8a680e631af99224fbae4318
Author: chandan-khandelwal <chandan.khandel...@hotwaxsystems.com>
AuthorDate: Fri May 22 18:28:27 2026 +0530

    Improvement: Prevent potential resource leak in CoreEvents.java 
(OFBIZ-13421) (#1241)
    
    Improved: Prevent potential resource leak in CoreEvents.java
    (OFBIZ-13421)
    
    Refactor streamFile in CoreEvents.java to use try-with-resources. This
    prevents a potential file descriptor resource leak if the file streaming
    process throws an Exception.
---
 .../src/main/java/org/apache/ofbiz/webapp/event/CoreEvents.java       | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git 
a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/CoreEvents.java 
b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/CoreEvents.java
index f84beac86d..36688ba1e5 100644
--- 
a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/CoreEvents.java
+++ 
b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/CoreEvents.java
@@ -516,10 +516,8 @@ public class CoreEvents {
         if (file.exists()) {
             Long longLen = file.length();
             int length = longLen.intValue();
-            try {
-                FileInputStream fis = new FileInputStream(file);
+            try (FileInputStream fis = new FileInputStream(file)) {
                 UtilHttp.streamContentToBrowser(response, fis, length, null);
-                fis.close();
             } catch (IOException e) {
                 Debug.logError(e, MODULE);
                 return "error";