(ofbiz-framework) branch trunk updated: Improved: FreeMarkerViewHandler should load templates via the FreeMarkerWorker (OFBIZ-3546) (#1256)

[mridulpathak]

This is an automated email from the ASF dual-hosted git repository.

mridulpathak pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new c2731ad7f1 Improved: FreeMarkerViewHandler should load templates via 
the FreeMarkerWorker (OFBIZ-3546) (#1256)
c2731ad7f1 is described below

commit c2731ad7f1423fcb3e4517ec22265cf242498914
Author: Mridul Pathak <mridul...@gmail.com>
AuthorDate: Fri May 29 15:54:06 2026 +0530

    Improved: FreeMarkerViewHandler should load templates via the 
FreeMarkerWorker (OFBIZ-3546) (#1256)
    
    Improved: FreeMarkerViewHandler should load templates via the
    FreeMarkerWorker
    (OFBIZ-3546)
    
    Used MultiTemplateLoader to combine FlexibleTemplateLoader in
    FreemarkerWorker config with WebappTemplateLoader to allow for both
    component templates and webapp templates.
    
    Thanks: Bruna Busco for reporting the issue.
---
 .../ofbiz/webapp/ftl/FreeMarkerViewHandler.java    | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git 
a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/ftl/FreeMarkerViewHandler.java
 
b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/ftl/FreeMarkerViewHandler.java
index 2c859ce8e2..65a258701a 100644
--- 
a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/ftl/FreeMarkerViewHandler.java
+++ 
b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/ftl/FreeMarkerViewHandler.java
@@ -35,6 +35,9 @@ import org.apache.ofbiz.webapp.control.ConfigXMLReader;
 import org.apache.ofbiz.webapp.view.AbstractViewHandler;
 import org.apache.ofbiz.webapp.view.ViewHandlerException;
 
+import freemarker.cache.MultiTemplateLoader;
+import freemarker.cache.TemplateLoader;
+import freemarker.ext.jakarta.servlet.WebappTemplateLoader;
 import freemarker.ext.jakarta.jsp.TaglibFactory;
 import freemarker.ext.jakarta.servlet.HttpRequestHashModel;
 import freemarker.ext.jakarta.servlet.HttpSessionHashModel;
@@ -51,7 +54,15 @@ public class FreeMarkerViewHandler extends 
AbstractViewHandler {
     @Override
     public void init(ServletContext context) throws ViewHandlerException {
         config.setCacheStorage(new OfbizCacheStorage("unknown"));
-        config.setServletContextForTemplateLoading(context, "/");
+        TemplateLoader webappLoader = new WebappTemplateLoader(context, "/");
+        TemplateLoader defaultLoader = config.getTemplateLoader();
+        TemplateLoader[] loaders;
+        if (defaultLoader != null) {
+            loaders = new TemplateLoader[] {defaultLoader, webappLoader};
+        } else {
+            loaders = new TemplateLoader[] {webappLoader};
+        }
+        config.setTemplateLoader(new MultiTemplateLoader(loaders));
     }
 
     @Override
@@ -106,13 +117,8 @@ public class FreeMarkerViewHandler extends 
AbstractViewHandler {
 
         // process the template & flush the output
         try {
-            if (page.startsWith("component://")) {
-                FreeMarkerWorker.renderTemplate(page, context, 
response.getWriter());
-            } else {
-                // backwards compatibility
-                Template template = config.getTemplate(page);
-                FreeMarkerWorker.renderTemplate(template, context, 
response.getWriter());
-            }
+            Template template = config.getTemplate(page);
+            FreeMarkerWorker.renderTemplate(template, context, 
response.getWriter());
             response.flushBuffer();
         } catch (TemplateException te) {
             throw new ViewHandlerException("Problems processing Freemarker 
template", te);