This is an automated email from the ASF dual-hosted git repository.
ashishvijaywargiya pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push:
new 5b46382921 Fix timing-dependent race in
QuoteTests.testCreateQuoteWorkEffortFail (#1659)
5b46382921 is described below
commit 5b4638292130b3a173aac337859c223bad665f4b
Author: Ashish Vijaywargiya <[email protected]>
AuthorDate: Sun Aug 16 15:09:41 2026 +0530
Fix timing-dependent race in QuoteTests.testCreateQuoteWorkEffortFail
(#1659)
The test verified nothing changed by checking for a QuoteWorkEffort row
with lastUpdatedStamp >= a timestamp captured at test start. Since the
prior test creates a row with the same quoteId/workEffortId just before
this one runs, the two timestamps can land in the same millisecond,
making the check match the earlier test's row and fail the assertion
even though nothing was actually changed.
Compare the row before and after the service call instead, which does
not depend on timestamp precision.
---
.../apache/ofbiz/order/order/test/QuoteTests.groovy | 20 ++++++++------------
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git
a/applications/order/src/test/groovy/org/apache/ofbiz/order/order/test/QuoteTests.groovy
b/applications/order/src/test/groovy/org/apache/ofbiz/order/order/test/QuoteTests.groovy
index 329a0dc134..cfa510c67b 100644
---
a/applications/order/src/test/groovy/org/apache/ofbiz/order/order/test/QuoteTests.groovy
+++
b/applications/order/src/test/groovy/org/apache/ofbiz/order/order/test/QuoteTests.groovy
@@ -18,13 +18,7 @@
*/
package org.apache.ofbiz.order.order.test
-import static
org.apache.ofbiz.entity.condition.EntityComparisonOperator.GREATER_THAN_EQUAL_TO
-
-import java.sql.Timestamp
-
-import org.apache.ofbiz.base.util.UtilDateTime
import org.apache.ofbiz.entity.GenericValue
-import org.apache.ofbiz.entity.condition.EntityCondition
import org.apache.ofbiz.order.shoppingcart.ShoppingCart
import org.apache.ofbiz.service.ServiceUtil
import org.apache.ofbiz.testtools.JunitJupiterTest
@@ -60,12 +54,16 @@ class QuoteTests implements JupiterTestHelper {
@Test
@Order(2)
void testCreateQuoteWorkEffortFail() {
- Timestamp startTime = UtilDateTime.nowTimestamp()
GenericValue userLogin = getUserLogin('DemoRepStore')
String quoteId = '9001'
String workEffortId = '9007'
+ // Capture the record as it stands before this test's own call, so the
comparison below
+ // doesn't depend on wall-clock timestamps (racy when tests run within
the same millisecond)
+ GenericValue quoteWorkEffortBefore = from('QuoteWorkEffort')
+ .where(quoteId: quoteId, workEffortId: workEffortId).queryOne()
+
// Execute the service, note break-on-error is false so that the test
// itself doesn't fail and we also need a separate transaction so our
// lookup below doesn't fail due to the rollback
@@ -79,12 +77,10 @@ class QuoteTests implements JupiterTestHelper {
assert ServiceUtil.isError(serviceResult)
// Confirm the database changes, in this case nothing should have
changed
- GenericValue quoteWorkEffort = from('QuoteWorkEffort').where(
- EntityCondition.makeCondition(quoteId: quoteId, workEffortId:
workEffortId),
- EntityCondition.makeCondition('lastUpdatedStamp',
GREATER_THAN_EQUAL_TO, startTime)
- ).queryOne()
+ GenericValue quoteWorkEffort = from('QuoteWorkEffort')
+ .where(quoteId: quoteId, workEffortId: workEffortId).queryOne()
- assert !quoteWorkEffort
+ assert quoteWorkEffort == quoteWorkEffortBefore
}
@Test
