(ofbiz-framework) branch trunk updated: Fixed: visualThemePermissionCheck() checks a permission ID that doesn't exist (OFBIZ-13602)

[mridulpathak]

This is an automated email from the ASF dual-hosted git repository.

mridulpathak pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 8a1c007062 Fixed: visualThemePermissionCheck() checks a permission ID 
that doesn't exist (OFBIZ-13602)
8a1c007062 is described below

commit 8a1c007062556256988582e2fb16a98abe64549f
Author: Mridul Pathak <mridul...@gmail.com>
AuthorDate: Sat Sep 19 18:29:06 2026 +0530

    Fixed: visualThemePermissionCheck() checks a permission ID that doesn't 
exist (OFBIZ-13602)
    
    visualThemePermissionCheck() set primaryPermission to 'VISUAL_THEME', but 
the
    actual seeded SecurityPermission records are VISUALTHEME_CREATE/_UPDATE/
    _DELETE/_ADMIN, with no underscore between "VISUAL" and "THEME". The typo'd
    permission id never matched a granted permission for any user, silently
    locking out every Visual Theme create/update/delete admin action for
    everyone, including SUPER/FULLADMIN. Corrected the literal back to
    'VISUALTHEME'.
    
    Verified with a temporary RED/GREEN test; full common component suite 
passes.
---
 .../org/apache/ofbiz/common/permission/CommonPermissionServices.groovy  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/framework/common/src/main/groovy/org/apache/ofbiz/common/permission/CommonPermissionServices.groovy
 
b/framework/common/src/main/groovy/org/apache/ofbiz/common/permission/CommonPermissionServices.groovy
index b5ca49f108..05e9578028 100644
--- 
a/framework/common/src/main/groovy/org/apache/ofbiz/common/permission/CommonPermissionServices.groovy
+++ 
b/framework/common/src/main/groovy/org/apache/ofbiz/common/permission/CommonPermissionServices.groovy
@@ -101,7 +101,7 @@ Map hasCrudPermission(String perm, Map resultMap) {
  * Visual Theme permission logic
  */
 Map visualThemePermissionCheck() {
-    parameters.primaryPermission = 'VISUAL_THEME'
+    parameters.primaryPermission = 'VISUALTHEME'
     Map result = run service: 'genericBasePermissionCheck', with: parameters
     return result
 }