This is an automated email from the ASF dual-hosted git repository.

mridulpathak pushed a commit to branch release24.09
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/release24.09 by this push:
     new 23ccf7046b Fixed: Regression in the minilang-to-Groovy conversion of 
InventoryIssueServices.groovy (OFBIZ-13614)
23ccf7046b is described below

commit 23ccf7046ba1a7b2dacf2433d73bce25bdd9eb3c
Author: Mridul Pathak <[email protected]>
AuthorDate: Sat Sep 26 18:28:15 2026 +0530

    Fixed: Regression in the minilang-to-Groovy conversion of 
InventoryIssueServices.groovy (OFBIZ-13614)
    
    issueImmediatelyFulfilledOrderItem() no longer throws on a nonexistent 
order/item combination, matching the original mini-lang which evaluated to 
false gracefully on a null base object and returned a clean success no-op 
instead of aborting.
---
 .../ofbiz/product/product/inventory/InventoryIssueServices.groovy       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/applications/product/src/main/groovy/org/apache/ofbiz/product/product/inventory/InventoryIssueServices.groovy
 
b/applications/product/src/main/groovy/org/apache/ofbiz/product/product/inventory/InventoryIssueServices.groovy
index 24a8b2aeda..ed4c7ab942 100644
--- 
a/applications/product/src/main/groovy/org/apache/ofbiz/product/product/inventory/InventoryIssueServices.groovy
+++ 
b/applications/product/src/main/groovy/org/apache/ofbiz/product/product/inventory/InventoryIssueServices.groovy
@@ -72,7 +72,7 @@ Map issueImmediatelyFulfilledOrderItem() {
 
     // kind of like the inventory reservation routine (with a few 
variations...), find InventoryItems to issue from,
     // but instead of doing the reservation just create an issuance and an 
inventory item detail for the change
-    if (orderItem.productId) {
+    if (orderItem?.productId) {
         // NOTE: the inventory will be issued from the 
OrderHeader.originFacilityId
         GenericValue orderHeader = parameters.orderHeader ?:
                 from('OrderHeader').where(parameters).queryOne()

Reply via email to