This is an automated email from the ASF dual-hosted git repository.
mridulpathak pushed a commit to branch release24.09
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/release24.09 by this push:
new c62a5f0467 Keep body-only edits from cancelling the labelling of a new
pull request
c62a5f0467 is described below
commit c62a5f0467aace1854cbac764a968b91bc72e82f
Author: Mridul Pathak <[email protected]>
AuthorDate: Tue Oct 27 18:33:09 2026 +0530
Keep body-only edits from cancelling the labelling of a new pull request
All the PR Labels runs of a pull request shared one concurrency group with
cancel-in-progress, so editing the body of a pull request while the run of its
opening was still queued cancelled that run, and the run of the edit then
skipped its job because neither the title nor the base changed: the pull
request got no labels. Only the runs that label now share the group of their
pull request.
---
.github/workflows/pr-type-label.yml | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/.github/workflows/pr-type-label.yml
b/.github/workflows/pr-type-label.yml
index c3e752097a..ee4ad39fa5 100644
--- a/.github/workflows/pr-type-label.yml
+++ b/.github/workflows/pr-type-label.yml
@@ -44,8 +44,13 @@ on:
permissions: {}
+# Only the runs that label share the group of their pull request, so that a
body-only edit, whose
+# job is skipped, can't cancel the still queued run of the opening of the pull
request.
concurrency:
- group: pr-type-label-${{ github.event.pull_request.number || github.run_id }}
+ group: >-
+ pr-type-label-${{ github.event_name == 'pull_request_target' &&
+ (github.event.action != 'edited' || github.event.changes.title ||
github.event.changes.base) &&
+ github.event.pull_request.number || github.run_id }}
cancel-in-progress: true
jobs:
