This is an automated email from the ASF dual-hosted git repository. jacopoc pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
commit a8f187c49d1f296a7f7734f451950a86e4843b55 Author: Jacopo Cappellato <[email protected]> AuthorDate: Wed Oct 28 15:51:39 2026 +0100 Remove unused EVICTION_EXECUTOR field in SecretValueResolver The field was assigned in the static initializer but never read. The eviction task is scheduled through the local executor variable, and its live daemon worker thread keeps the executor reachable, so the field was not needed to keep the sweep running. Co-Authored-By: Claude Opus 5.5 <[email protected]> --- .../src/main/java/org/apache/ofbiz/base/secret/SecretValueResolver.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/framework/base/src/main/java/org/apache/ofbiz/base/secret/SecretValueResolver.java b/framework/base/src/main/java/org/apache/ofbiz/base/secret/SecretValueResolver.java index 739f4ce3c2..bdfc0c0fb6 100644 --- a/framework/base/src/main/java/org/apache/ofbiz/base/secret/SecretValueResolver.java +++ b/framework/base/src/main/java/org/apache/ofbiz/base/secret/SecretValueResolver.java @@ -123,7 +123,6 @@ public final class SecretValueResolver { private static final ConcurrentHashMap<String, AtomicLong> KEY_LAST_ACCESS_TIMES = new ConcurrentHashMap<>(); // Daemon thread that sweeps expired entries so stale keys don't accumulate indefinitely. - private static final ScheduledExecutorService EVICTION_EXECUTOR; static { ScheduledExecutorService executor = Executors.newSingleThreadScheduledExecutor(r -> { Thread t = new Thread(r, "SecretValueResolver-CacheEviction"); @@ -136,7 +135,6 @@ public final class SecretValueResolver { // Remove per-key locks for keys no longer in the cache to prevent unbounded growth. KEY_LOCKS.keySet().removeIf(k -> !CACHE.containsKey(k)); }, CACHE_TTL_MILLIS, CACHE_TTL_MILLIS, TimeUnit.MILLISECONDS); - EVICTION_EXECUTOR = executor; } private SecretValueResolver() { }
