[ 
https://issues.apache.org/jira/browse/OODT-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116129#comment-13116129
 ] 

Chris A. Mattmann commented on OODT-61:
---------------------------------------

OK, all tests pass for me:

{noformat}
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.oodt.xmlps.mapping.TestMappingReader
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.258 sec
Running org.apache.oodt.xmlps.product.TestXMLPSProductHandler
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.275 sec
Running org.apache.oodt.xmlps.profile.TestXMLPSProfileHandler
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.206 sec
Running org.apache.oodt.xmlps.queryparser.TestHandlerQueryParser
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.145 sec

Results :

Tests run: 11, Failures: 0, Errors: 0, Skipped: 0
{noformat}

I'm going to update the javadoc on #getLocalName to remove the mention of 
appendTableName 
and this is good to go. Committing!

                
> appendTableName property for mapping files in XMLPS breaks columnname-based 
> lookup in ResultSet
> -----------------------------------------------------------------------------------------------
>
>                 Key: OODT-61
>                 URL: https://issues.apache.org/jira/browse/OODT-61
>             Project: OODT
>          Issue Type: Bug
>          Components: xmlps
>    Affects Versions: 0.1-incubating
>         Environment: Mac OS X 10.6, Java SDK 6, Tomcat 7, connecting to SQL 
> Server and Oracle databases.
>            Reporter: Dave Kale
>            Assignee: Chris A. Mattmann
>             Fix For: 0.4
>
>         Attachments: oodt-61-patch.diff
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Basically, I introduced a bug when I added the appendTableName property to 
> the map file reading stuff in XMLPS.  The original goal of appendTableName 
> was to help with disambiguation when joining tables with fields that have 
> identical names.  However, the way "appendTableName" is handled right now, 
> XMLPS tries to used the table-appended field name to retrieve results from 
> the ResultSet, producing the following error:
> Nov 17, 2010 10:48:11 AM org.apache.oodt.xmlps.product.DBMSExecutor toCDERow
> WARNING: Unable to obtain field: [TableName.FieldName] from result set: 
> message: Invalid column name
> I propose that we do one of the following:
> 1. Make the simplest fix, which is not use the appended table name when 
> looking up results in the ResultSet.
> 2. Get rid of the appendTableName property and instead make XMLPS handle 
> disambiguation automatically: when it detects fields of the same name from 
> different tables, it automatically appends table name when constructing 
> queries in which the field shows up in the SELECT part of the query.
> 3. Other options?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to