[ 
https://issues.apache.org/jira/browse/OODT-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217336#comment-13217336
 ] 

[email protected] commented on OODT-390:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4053/
-----------------------------------------------------------

Review request for Chris Mattmann, brian Foster and Ricky Nguyen.


Summary
-------

The optimize function can be time consuming depending on the size of the index. 
It was externalized in the file manager as a tool for just this reason; which 
can be reuse here for optimizing. This change then boils down to removing the 
call to optimize every time a workflow instance was added to the repository. In 
theory this could help speed things up for people using this type of instance 
repository.


This addresses bug OODT-390.
    https://issues.apache.org/jira/browse/OODT-390


Diffs
-----

  
http://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/instrepo/LuceneWorkflowInstanceRepository.java
 1294242 

Diff: https://reviews.apache.org/r/4053/diff


Testing
-------


Thanks,

Paul


                
> Remove Embedded Optimize from Lucene Workflow Instance Repository
> -----------------------------------------------------------------
>
>                 Key: OODT-390
>                 URL: https://issues.apache.org/jira/browse/OODT-390
>             Project: OODT
>          Issue Type: Improvement
>          Components: workflow manager
>    Affects Versions: 0.3
>            Reporter: Paul Ramirez
>            Assignee: Paul Ramirez
>             Fix For: 0.4
>
>         Attachments: oodt-390-patch.txt
>
>
> Optimize should not be called in the internals of the instance repository for 
> lucene. This functionality should be relegated to an external tool as was 
> done with the lucene file manager catalog. That tool can actually be reused 
> to optimize this index. Calling optimize on the index on each add could cause 
> some performance issues and making this an external function should rectify 
> that. If one is working in a system where they have large batches they should 
> run the optimize tool when the see degradation or on a semi-regular basis. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to