[
https://issues.apache.org/jira/browse/OODT-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218938#comment-13218938
]
[email protected] commented on OODT-361:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4089/#review5437
-----------------------------------------------------------
trunk/commons/src/main/java/org/apache/oodt/commons/util/DateConvert.java
<https://reviews.apache.org/r/4089/#comment11841>
might want to also add here "...24 characters in length or null." to the
exception message.
- Chris
On 2012-02-28 20:05:18, Ricky Nguyen wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4089/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-28 20:05:18)
bq.
bq.
bq. Review request for oodt.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. When DateConvert.isoParse is given a null input, it throws NPE.
bq. Solution is throw ParseException if input is null. WorkflowInstance
catches ParseException and ignores it.
bq.
bq.
bq. This addresses bug OODT-361.
bq. https://issues.apache.org/jira/browse/OODT-361
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/commons/src/main/java/org/apache/oodt/commons/util/DateConvert.java
1294802
bq.
bq. Diff: https://reviews.apache.org/r/4089/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran HelloWorld, GoodbyeWorld.
bq.
bq.
bq. Thanks,
bq.
bq. Ricky
bq.
bq.
> Workflow test event fails with NPE
> ----------------------------------
>
> Key: OODT-361
> URL: https://issues.apache.org/jira/browse/OODT-361
> Project: OODT
> Issue Type: Bug
> Components: workflow manager
> Affects Versions: 0.4
> Reporter: Ricky Nguyen
> Priority: Minor
> Fix For: 0.4
>
> Attachments: rickdn-oodt-361.patch
>
>
> Running the "hello world" example from
> http://oodt.apache.org/components/maven/workflow/user/basic.html causes a NPE.
> {noformat}
> ./wmgr-client -u http://localhost:9001 -op -se -en test
> Dec 2, 2011 2:04:08 PM
> org.apache.oodt.cas.workflow.system.XmlRpcWorkflowManager handleEvent
> INFO: WorkflowManager: Received event: test
> Dec 2, 2011 2:04:08 PM
> org.apache.oodt.cas.workflow.system.XmlRpcWorkflowManager handleEvent
> INFO: WorkflowManager: Workflow testWorkflow retrieved for event test
> Dec 2, 2011 2:04:08 PM org.apache.oodt.cas.workflow.engine.WorkflowProcessor
> checkTaskRequiredMetadata
> INFO: Task: [Hello World] has no required metadata fields
> Exception in thread "Thread-4" java.lang.NullPointerException
> at
> org.apache.oodt.commons.util.DateConvert.isoParse(DateConvert.java:166)
> at
> org.apache.oodt.cas.workflow.structs.WorkflowInstance.setCurrentTaskEndDateTimeIsoStr(WorkflowInstance.java:315)
> at
> org.apache.oodt.cas.workflow.engine.SequentialProcessor.start(SequentialProcessor.java:206)
> at
> org.apache.oodt.cas.workflow.engine.ThreadPoolWorkflowEngine$ThreadedProcessor.run(ThreadPoolWorkflowEngine.java:495)
> at EDU.oswego.cs.dl.util.concurrent.PooledExecutor$Worker.run(Unknown
> Source)
> at java.lang.Thread.run(Thread.java:680)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
