[
https://issues.apache.org/jira/browse/OODT-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229582#comment-13229582
]
[email protected] commented on OODT-409:
----------------------------------------------------
bq. On 2012-03-14 16:05:06, Paul Ramirez wrote:
bq. >
trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java,
line 47
bq. > <https://reviews.apache.org/r/4326/diff/1/?file=92060#file92060line47>
bq. >
bq. > shouldn't this be:
bq. >
bq. > return Boolean.getBoolean(System.getProperty(USE_LEGACY_PROPERTY)) ?
legacyName : name;
bq. >
bq. >
hey paul... i think you are think of Boolean.parseBoolean(String)... here is
the javadoc on: Boolean.getBoolean(String):
Returns true if and only if the system property named by the argument exists
and is equal to the string "true". (Beginning with version 1.0.2 of the JavaTM
platform, the test of this string is case insensitive.) A system property is
accessible through getProperty, a method defined by the System class.
If there is no property with the specified name, or if the specified name is
empty or null, then false is returned.
- brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4326/#review5943
-----------------------------------------------------------
On 2012-03-14 05:18:33, brian Foster wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4326/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-14 05:18:33)
bq.
bq.
bq. Review request for oodt, Chris Mattmann and Paul Ramirez.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The enum for met keys will allow for backwards compatibility to be toggled
on/off easily
bq.
bq.
bq. This addresses bug OODT-409.
bq. https://issues.apache.org/jira/browse/OODT-409
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java
1300432
bq.
trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/XmlFilePgeConfigBuilder.java
1300432
bq.
trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java
PRE-CREATION
bq.
trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetadataKeys.java
1300432
bq.
trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskStatus.java
PRE-CREATION
bq. trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java
1300432
bq.
trunk/pge/src/test/org/apache/oodt/cas/pge/metadata/TestPgeTaskMetKeys.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4326/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added/Updated Unit-Tests
bq.
bq.
bq. Thanks,
bq.
bq. brian
bq.
bq.
> Convert CAS-PGE metadata keys and workflow statuses from static Strings to
> enums
> --------------------------------------------------------------------------------
>
> Key: OODT-409
> URL: https://issues.apache.org/jira/browse/OODT-409
> Project: OODT
> Issue Type: Sub-task
> Components: pge wrapper framework
> Affects Versions: 0.3
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.4
>
> Attachments: OODT-409.2012-03-13.patch.txt
>
>
> The enum for met keys will allow for backwards compatibility to be toggled
> on/off easily
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
