[ 
https://issues.apache.org/jira/browse/OODT-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230927#comment-13230927
 ] 

[email protected] commented on OODT-413:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4374/#review6026
-----------------------------------------------------------



trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/LuceneCatalog.java
<https://reviews.apache.org/r/4374/#comment13010>

    What about:
    
    String element = elements.get(i);
    if (fullMetadata.containsKey(element) {
       reducedMetadata.addMetadata(element, 
fullMetadata.getAllMetadata(element);
    }
    
    also add addMetadata() really should be replaceMetadata()... although in 
this cause unless the same element is in the elements List more than once 
addMetadata() will work the same


- brian


On 2012-03-16 03:18:23, Ricky Nguyen wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4374/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-16 03:18:23)
bq.  
bq.  
bq.  Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, 
Sheryl John, and Thomas Bennett.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  filemgr query throws NPE when some products have undefined metadata values
bq.  
bq.  
bq.  This addresses bug OODT-413.
bq.      https://issues.apache.org/jira/browse/OODT-413
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/LuceneCatalog.java
 1301315 
bq.    
trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestLuceneCatalog.java
 1301315 
bq.  
bq.  Diff: https://reviews.apache.org/r/4374/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  tested at CHLA with command:
bq.  
bq.  ./filemgr-client -u $FILEMGR_URL -op -sql -of '$VpsEpisodeStartTime' -q 
"SELECT VpsEpisodeStartTime FROM CernerEvents"
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ricky
bq.  
bq.


                
> filemgr query throws NPE when some products have undefined metadata values
> --------------------------------------------------------------------------
>
>                 Key: OODT-413
>                 URL: https://issues.apache.org/jira/browse/OODT-413
>             Project: OODT
>          Issue Type: Bug
>          Components: catalog, file manager
>    Affects Versions: 0.3
>            Reporter: Ricky Nguyen
>             Fix For: 0.4
>
>
> We have a product type called CernerEvents. Some products of this type have 
> values defined for met key "VpsEpisodeStartTime" and some products do not.
> When we run the query:
> {noformat}
> ./filemgr-client -u $FILEMGR_URL -op -sql -of '$VpsEpisodeStartTime' -q 
> "SELECT VpsEpisodeStartTime FROM CernerEvents"
> {noformat}
> Then the following exception is seen (on XML-RPC server side):
> {noformat}
> java.lang.NullPointerException
>       at java.util.Vector.addAll(Unknown Source)
>       at 
> org.apache.oodt.cas.metadata.Metadata$Group.addValues(Metadata.java:499)
>       at org.apache.oodt.cas.metadata.Metadata.addMetadata(Metadata.java:124)
>       at 
> org.apache.oodt.cas.filemgr.catalog.LuceneCatalog.getReducedMetadata(LuceneCatalog.java:623)
>       at 
> org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.getReducedMetadata(XmlRpcFileManager.java:1178)
>       at 
> org.apache.oodt.cas.filemgr.system.XmlRpcFileManager.complexQuery(XmlRpcFileManager.java:606)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>       at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>       at java.lang.reflect.Method.invoke(Unknown Source)
>       at org.apache.xmlrpc.Invoker.execute(Invoker.java:130)
>       at org.apache.xmlrpc.XmlRpcWorker.invokeHandler(XmlRpcWorker.java:84)
>       at org.apache.xmlrpc.XmlRpcWorker.execute(XmlRpcWorker.java:146)
>       at org.apache.xmlrpc.XmlRpcServer.execute(XmlRpcServer.java:139)
>       at org.apache.xmlrpc.XmlRpcServer.execute(XmlRpcServer.java:125)
>       at org.apache.xmlrpc.WebServer$Connection.run(WebServer.java:761)
>       at org.apache.xmlrpc.WebServer$Runner.run(WebServer.java:642)
>       at java.lang.Thread.run(Unknown Source)
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to