[ 
https://issues.apache.org/jira/browse/OODT-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233246#comment-13233246
 ] 

[email protected] commented on OODT-425:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4410/#review6111
-----------------------------------------------------------

Ship it!


LGTM.

- Chris


On 2012-03-20 01:41:27, brian Foster wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4410/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-20 01:41:27)
bq.  
bq.  
bq.  Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and 
Thomas Bennett.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  listFiles()[0] needs a filter, so that if logger lck files aren't deleted 
fast enough the test doesn't parse the lck file instead of the log file
bq.  
bq.  
bq.  This addresses bug OODT-425.
bq.      https://issues.apache.org/jira/browse/OODT-425
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 
1302703 
bq.  
bq.  Diff: https://reviews.apache.org/r/4410/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  This patch is for a unit-test
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  brian
bq.  
bq.


                
> CAS-PGE logger unit-test fails because it sometimes finds logger lock file
> --------------------------------------------------------------------------
>
>                 Key: OODT-425
>                 URL: https://issues.apache.org/jira/browse/OODT-425
>             Project: OODT
>          Issue Type: Bug
>          Components: pge wrapper framework
>    Affects Versions: 0.3
>         Environment: none
>            Reporter: Brian Foster
>            Assignee: Brian Foster
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: OODT-425.2012-03-19.patch.txt
>
>
> listFiles()[0] needs a filter, so that if logger lck files aren't deleted 
> fast enough the test doesn't parse the lck file instead of the log file

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to