[ 
https://issues.apache.org/jira/browse/OODT-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237120#comment-13237120
 ] 

[email protected] commented on OODT-427:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4451/#review6310
-----------------------------------------------------------



trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestSqlQueryCliAction.java
<https://reviews.apache.org/r/4451/#comment13697>

    multi-value met is comma-separated too, so I removed expected values and 
test for remaining delimiter.



trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResult.java
<https://reviews.apache.org/r/4451/#comment13698>

    multi-value met is comma-separated too, so I removed expected values and 
test for remaining delimiter.



trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResult.java
<https://reviews.apache.org/r/4451/#comment13699>

    here is the test bfoster suggested


- Ricky


On 2012-03-23 21:02:03, Ricky Nguyen wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4451/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-23 21:02:03)
bq.  
bq.  
bq.  Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, 
Sheryl John, and Thomas Bennett.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Cleaned up metadata to string methods of QueryResult. If metadata was 
empty, it was trying to delete a trailing comma that doesn't exist.
bq.  
bq.  
bq.  This addresses bug OODT-427.
bq.      https://issues.apache.org/jira/browse/OODT-427
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResult.java
 1303205 
bq.    
trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestSqlQueryCliAction.java
 1303205 
bq.    
trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResult.java
 PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4451/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Added unit test to check for empty metadata.
bq.  
bq.  Changed existing unit test to account for implementation-dependent 
ordering of keys.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ricky
bq.  
bq.


                
> filemgr query throws "String index out of range: -1" when some products have 
> undefined metadata values
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OODT-427
>                 URL: https://issues.apache.org/jira/browse/OODT-427
>             Project: OODT
>          Issue Type: Bug
>          Components: file manager
>    Affects Versions: 0.3
>            Reporter: Ricky Nguyen
>             Fix For: 0.4
>
>
> To reproduce:
> 1) ingest a ProductType without metadata (except ProductType defined)
> 2) run a sql query without output format
> 3) String index out of bounds thrown as shown below
> [vpicu@palmer bin]$ ./filemgr-client -u $FILEMGR_URL -op -sql -q 'SELECT 
> EpisodeStartTime FROM Events'
> Mar 22, 2012 12:17:54 PM 
> org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient <init>
> INFO: Loading File Manager Configuration Properties from: 
> [../etc/filemgr.properties]
> ERROR: Failed to perform sql query : sortBy 'null', outputFormat 'null', and 
> delimiter '
> ', filterAlgor 'null', startDateTimeMetKey 'null', endDateTimeMetKey 'null', 
> priorityMetKey 'null', null' : String index out of range: -1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to