[
https://issues.apache.org/jira/browse/OODT-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238792#comment-13238792
]
[email protected] commented on OODT-428:
----------------------------------------------------
bq. On 2012-03-26 14:22:31, Chris Mattmann wrote:
bq. >
trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java,
line 60
bq. > <https://reviews.apache.org/r/4454/diff/1/?file=94689#file94689line60>
bq. >
bq. > Agree with Tom here, do we need a check on if getValues() == null
too?
i think what i'll do here is check if it is empty and then throw an Exception
explicitly so it is clear that a no arg option it wrong here... boolean options
should have a static arg specifying either true or false value.
- brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4454/#review6347
-----------------------------------------------------------
On 2012-03-22 21:27:55, brian Foster wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4454/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-22 21:27:55)
bq.
bq.
bq. Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and
Thomas Bennett.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. It currently was setting lists keys to: value1,value2,value3,...
bq.
bq. This patch will instead change it to:
bq. key[0] = value1
bq. key[1] = value2
bq.
bq.
bq. This addresses bug OODT-428.
bq. https://issues.apache.org/jira/browse/OODT-428
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java
1304041
bq.
bq. Diff: https://reviews.apache.org/r/4454/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. still need a unit-test for this... will write when i get the time
bq.
bq.
bq. Thanks,
bq.
bq. brian
bq.
bq.
> CrawlerBeansPropHandler doesn't set list properties for Spring
> PropertyOverrideConfigurer correctly
> ---------------------------------------------------------------------------------------------------
>
> Key: OODT-428
> URL: https://issues.apache.org/jira/browse/OODT-428
> Project: OODT
> Issue Type: Bug
> Components: crawler
> Affects Versions: 0.3
> Environment: none
> Reporter: Brian Foster
> Assignee: Brian Foster
> Priority: Minor
> Fix For: 0.4
>
> Attachments: OODT-428.2012-03-22.patch.txt
>
>
> It currently was setting lists keys to: value1,value2,value3,...
> This patch will instead change it to:
> key[0] = value1
> key[1] = value2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
