[
https://issues.apache.org/jira/browse/OODT-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238834#comment-13238834
]
[email protected] commented on OODT-429:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4458/#review6371
-----------------------------------------------------------
Ship it!
LGTM
- brian
On 2012-03-23 21:19:16, Ricky Nguyen wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4458/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-23 21:19:16)
bq.
bq.
bq. Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez,
Sheryl John, and Thomas Bennett.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. putting nulls last
bq.
bq.
bq. This addresses bug OODT-429.
bq. https://issues.apache.org/jira/browse/OODT-429
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java
1303205
bq.
trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4458/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. wrote unit test
bq.
bq.
bq. Thanks,
bq.
bq. Ricky
bq.
bq.
> filemgr query throws NPE when sorting by key with possibly empty values
> -----------------------------------------------------------------------
>
> Key: OODT-429
> URL: https://issues.apache.org/jira/browse/OODT-429
> Project: OODT
> Issue Type: Bug
> Components: file manager
> Affects Versions: 0.3
> Reporter: Ricky Nguyen
> Fix For: 0.4
>
>
> For a given met element, if any product has a null value, the entire sort
> fails with NPE.
> We should decide whether nulls appear at the beginning or the end of such a
> sort. My vote is at the end, since nulls are usually the least interesting
> value.
> However, consider the use case of sorting by ProductReceivedTime. Sort only
> occurs in ascending order (I am not aware of descending capability). If
> nulls appeared at the end, it would be slightly difficult to get the latest
> product (programmatically). For this type of sort, it would be useful to put
> nulls at the beginning, or even remove them altogether. Thoughts?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
